darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-16 20:49:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Remove update_with_properties method

Browse Source 
It’s more Pythonic, and better abstracted from the underlying API to
use keyword arguments instead.
This commit is contained in:
Chris Hill-Scott
2018-11-05 17:37:50 +00:00
parent b3a7210baf
commit 1c9e42f85d
3 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/models/service.py
View File

@@ -50,9 +50,6 @@ class Service():
def update(self, **kwargs):
return service_api_client.update_service(self.id, **kwargs)
def update_with_properties(self, properties):
return service_api_client.update_service_with_properties(self.id, properties)
def switch_permission(self, permission):
return self.force_permission(
permission,
@@ -68,12 +65,10 @@ class Service():
)
def update_permissions(self, permissions):
return self.update_with_properties({'permissions': list(permissions)})
return self.update(permissions=list(permissions))
def toggle_research_mode(self):
self.update_with_properties({
'research_mode': not self.research_mode,
})
self.update(research_mode=not self.research_mode)
@property
def trial_mode(self):