darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-10 01:55:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

Updating some of the full screen table code

Browse Source
This commit is contained in:
Jonathan Bobel
2025-04-22 10:45:11 -04:00
parent b6a6ffb2ab
commit 1b9e19072e
3 changed files with 4 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/assets/javascripts/fullscreenTable.js
View File

@@ -22,7 +22,6 @@
this.$scrollableTable this.$scrollableTable
.on('scroll', this.toggleShadows) .on('scroll', this.toggleShadows)
.on('scroll', this.maintainHeight) .on('scroll', this.maintainHeight)
.on('focus blur', () => this.$component.toggleClass('js-focus-style'));
if ( if (
window.GOVUK.stickAtBottomWhenScrolling && window.GOVUK.stickAtBottomWhenScrolling &&
@@ -31,17 +30,17 @@
window.GOVUK.stickAtBottomWhenScrolling.recalculate(); window.GOVUK.stickAtBottomWhenScrolling.recalculate();
} }
this.maintainWidth(); this.maintainWidth();npm
}; };
this.insertShims = () => { this.insertShims = () => {
const attributesForFocus = 'role aria-labelledby tabindex'; const attributesForFocus = 'role aria-labelledby';
let captionId = this.$table.find('caption').text().toLowerCase().replace(/[^A-Za-z]+/g, ''); let captionId = this.$table.find('caption').text().toLowerCase().replace(/[^A-Za-z]+/g, '');
this.$table.find('caption').attr('id', captionId); this.$table.find('caption').attr('id', captionId);
this.$table.wrap(`<div class="fullscreen-scrollable-table" role="region" aria-labelledby="${captionId}" tabindex="0"/>`); this.$table.wrap(`<div class="fullscreen-scrollable-table" role="region" aria-labelledby="${captionId}"/>`);
this.$component this.$component
.append( .append(

2
app/templates/views/send.html
View File

@@ -77,7 +77,7 @@
<div class="spreadsheet" data-module="fullscreen-table"> <div class="spreadsheet" data-module="fullscreen-table">
{% call(item, row_number) list_table( {% call(item, row_number) list_table(
example, example,
caption="Example", caption="Example spreadsheet",
caption_visible=False, caption_visible=False,
field_headings=[''] + column_headings field_headings=[''] + column_headings
) %} ) %}

20
tests/javascripts/fullscreenTable.test.js
View File

@@ -347,24 +347,4 @@ describe('FullscreenTable', () => {
}); });
describe("when the table is focused", () => {
beforeEach(() => {
// start module
window.GOVUK.modules.start();
tableFrame = document.querySelector('.fullscreen-scrollable-table');
tableFrame.focus();
});
test("it should make the parent frame a focus style", () => {
expect(container.classList.contains('js-focus-style')).toBe(true);
});
});
}); });