From a27dbd24a75a5d8520635bd6d994e7f9fee22951 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Fri, 19 Feb 2021 13:36:50 +0000 Subject: [PATCH] =?UTF-8?q?Fix=20the=20=E2=80=98revoke=E2=80=99=20links=20?= =?UTF-8?q?on=20the=20API=20keys=20page?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit They were missing the `govuk-link--destructive` class which turns them red, consistent with other links we use for deleting or suspending things. --- app/templates/views/api/keys.html | 2 +- tests/app/main/views/test_api_integration.py | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/app/templates/views/api/keys.html b/app/templates/views/api/keys.html index 0de391650..f4c969d02 100644 --- a/app/templates/views/api/keys.html +++ b/app/templates/views/api/keys.html @@ -46,7 +46,7 @@ {% endcall %} {% else %} {% call field(align='right', status='error') %} - + Revoke {{ item.name }} {% endcall %} diff --git a/tests/app/main/views/test_api_integration.py b/tests/app/main/views/test_api_integration.py index 135387493..f9ffbeb13 100644 --- a/tests/app/main/views/test_api_integration.py +++ b/tests/app/main/views/test_api_integration.py @@ -191,14 +191,23 @@ def test_should_show_empty_api_keys_page( def test_should_show_api_keys_page( client_request, mock_get_api_keys, + fake_uuid, ): page = client_request.get('main.api_keys', service_id=SERVICE_ONE_ID) rows = [normalize_spaces(row.text) for row in page.select('main tr')] + revoke_link = page.select_one('main tr a.govuk-link.govuk-link--destructive') assert rows[0] == 'API keys Action' assert rows[1] == 'another key name Revoked 1 January at 1:00am' assert rows[2] == 'some key name Revoke some key name' + assert normalize_spaces(revoke_link.text) == 'Revoke some key name' + assert revoke_link['href'] == url_for( + 'main.revoke_api_key', + service_id=SERVICE_ONE_ID, + key_id=fake_uuid, + ) + mock_get_api_keys.assert_called_once_with(SERVICE_ONE_ID)