darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 17:45:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #967 from alphagov/fix-param-tests

Browse Source 
fix query param testing once and for all. hopefully
This commit is contained in:
Chris Hill-Scott
2016-10-07 13:43:49 +01:00
committed by GitHub
parent 1d18afa231 b01323c28c
commit 14c9f39342
1 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/app/main/views/test_jobs.py
View File

@@ -1,6 +1,6 @@
import json import json
import uuid import uuid
from urllib.parse import quote from urllib.parse import urlparse, quote, parse_qs
import pytest import pytest
from flask import url_for from flask import url_for
@@ -327,24 +327,15 @@ def test_can_show_notifications(
status=status_argument status=status_argument
) == page.findAll("a", {"download": "download"})[0]['href'] ) == page.findAll("a", {"download": "download"})[0]['href']
assert url_for(
'.get_notifications_as_json',
service_id=service_one['id'],
message_type=message_type,
status=status_argument,
page=expected_page_argument
) == page.find("div", {'data-key': 'notifications'})['data-resource']
path_to_json = page.find("div", {'data-key': 'notifications'})['data-resource'] path_to_json = page.find("div", {'data-key': 'notifications'})['data-resource']
assert ( url = urlparse(path_to_json)
'/services/{}/notifications/{}.json?status={}&page={}'.format( assert url.path == '/services/{}/notifications/{}.json'.format(service_one['id'], message_type)
service_one['id'], message_type, status_argument, expected_page_argument query_dict = parse_qs(url.query)
) in path_to_json or if status_argument:
'/services/{}/notifications/{}.json?page={}&status={}'.format( assert query_dict['status'] == [status_argument]
service_one['id'], message_type, expected_page_argument, status_argument if expected_page_argument:
) in path_to_json assert query_dict['page'] == [str(expected_page_argument)]
)
mock_get_notifications.assert_called_with( mock_get_notifications.assert_called_with(
limit_days=7, limit_days=7,