darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-05 08:31:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Define user inside each test

Browse Source 
This user is only re-used once, which isn’t a big saving. By putting it
inside the test it’s easy to see what special conditions are being set
up that result in the expected outcometest result.
This commit is contained in:
Chris Hill-Scott
2022-06-06 11:51:01 +01:00
parent 60870c69a7
commit 122a045142
1 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
tests/app/utils/test_user.py
View File

@@ -6,12 +6,6 @@ from app.main.views.index import index
from app.utils.user import user_has_permissions
from tests.conftest import create_user, sample_uuid
_user_with_permissions = create_user(
id=sample_uuid(),
permissions={'foo': ['manage_users', 'manage_templates', 'manage_settings']},
services=['foo', 'bar'],
)
@pytest.mark.parametrize('permissions', (
pytest.param(
@@ -29,7 +23,12 @@ def test_permissions(
permissions,
):
request.view_args.update({'service_id': 'foo'})
client_request.login(_user_with_permissions)
user = create_user(
id=sample_uuid(),
permissions={'foo': ['manage_users', 'manage_templates', 'manage_settings']},
services=['foo', 'bar'],
)
client_request.login(user)
decorator = user_has_permissions(*permissions)
decorated_index = decorator(index)
@@ -133,7 +132,12 @@ def test_user_doesnt_have_permissions_for_organisation(
def test_user_with_no_permissions_to_service_goes_to_templates(
client_request,
):
client_request.login(_user_with_permissions)
user = create_user(
id=sample_uuid(),
permissions={'foo': ['manage_users', 'manage_templates', 'manage_settings']},
services=['foo', 'bar'],
)
client_request.login(user)
request.view_args = {'service_id': 'bar'}
@user_has_permissions()