darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 04:28:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #779 from GSA/778-dashboard-button-unstyled

Browse Source 
Styling update to fix broken link when status is failing
This commit is contained in:
Carlo Costino
2023-09-18 17:38:02 -04:00
committed by GitHub
parent 5683c50cc4 a752566e2f
commit 10d207eac4
4 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/sass/uswds/_uswds-theme-custom-styles.scss
View File

@@ -259,6 +259,9 @@ td.table-empty-message {
background: color("green-cool-40v"); background: color("green-cool-40v");
display: flex; display: flex;
padding: units(1) units(2); padding: units(1) units(2);
&--failing {
background: color("red-warm-50v");
}
} }
} }
.usa-table { .usa-table {

2
app/templates/components/big-number.html
View File

@@ -39,7 +39,7 @@
<span class="big-number-with-status"> <span class="big-number-with-status">
{{ big_number(number, label, link=link, smaller=smaller, smallest=smallest) }} {{ big_number(number, label, link=link, smaller=smaller, smallest=smallest) }}
{% if show_failures %} {% if show_failures %}
<span class="big-number-status{% if danger_zone %}-failing{% endif %}"> <span class="big-number-status{% if danger_zone %} big-number-status--failing{% endif %}">
{% if failures %} {% if failures %}
{% if failure_link %} {% if failure_link %}
<a class="usa-link" href="{{ failure_link }}"> <a class="usa-link" href="{{ failure_link }}">

2
app/templates/components/status-box.html
View File

@@ -1,6 +1,6 @@
{% macro status_box(number, label, failing=false, percentage=None, url=None) %} {% macro status_box(number, label, failing=false, percentage=None, url=None) %}
<div class="big-number-with-status"> <div class="big-number-with-status">
<div class="big-number-status{% if failing %}-failing{% endif %}"> <div class="big-number-status{% if failing %} big-number-status--failing{% endif %}">
{% if url %} {% if url %}
<a class="usa-link" href="{{ url }}">{{ number }} {{ label }}</a> <a class="usa-link" href="{{ url }}">{{ number }} {{ label }}</a>
{% else %} {% else %}

2
tests/app/main/views/test_platform_admin.py
View File

@@ -735,7 +735,7 @@ def test_platform_admin_displays_stats_in_right_boxes_and_with_correct_styling(
assert ( assert (
"1 technical failures" "1 technical failures"
in page.find_all("div", class_="grid-col-6")[1] in page.find_all("div", class_="grid-col-6")[1]
.find("div", class_="big-number-status-failing") .find("div", class_="big-number-status--failing")
.text .text
) )