Review usage of secondary/back links

This commit examines all the pages that use the page footer component, and
determines whether they should have a back button, a secondary link, both or
neither.

app/templates/views/api-keys/create.html

@@ -14,11 +14,7 @@
 
   <form method="post">
     {{ textbox(key_name, hint='eg CRM application') }}
-    {{ page_footer(
-      'Continue',
-      back_link=url_for('.api_keys', service_id=service_id),
-      back_link_text='Back to API keys'
-    ) }}
+    {{ page_footer('Continue') }}
   </form>
 
 {% endblock %}

app/templates/views/api-keys/show.html

@@ -26,8 +26,8 @@
     </div>
 
     {{ page_footer(
-      back_link=url_for('.api_keys', service_id=service_id),
-      back_link_text='Back to API keys'
+      secondary_link=url_for('.api_keys', service_id=service_id),
+      secondary_link_text='Back to API keys'
     ) }}
 
 {% endblock %}

app/templates/views/edit-template.html

@@ -26,8 +26,8 @@ GOV.UK Notify | Edit template
         'Save',
         delete_link=url_for('.delete_service_template', service_id=service_id, template_id=template_id) if template_id or None,
         delete_link_text='delete this template',
-        back_link=url_for('.manage_service_templates', service_id=service_id),
-        back_link_text='Back to templates'
+        secondary_link=url_for('.manage_service_templates', service_id=service_id),
+        secondary_link_text='Back to templates'
       ) }}
     </form>
 

app/templates/views/notification.html

@@ -26,8 +26,8 @@ GOV.UK Notify | Notifications activity
     </div>
 
     {{ page_footer(
-      back_link = url_for('.view_job', service_id=service_id, job_id=job_id),
-      back_link_text = 'View other messages in this job'
+      secondary_link = url_for('.view_job', service_id=service_id, job_id=job_id),
+      secondary_link_text = 'View other messages in this job'
     ) }}
 
 {% endblock %}

app/templates/views/service-settings/name.html

@@ -24,7 +24,8 @@ GOV.UK Notify | Service settings
         {{ textbox(form.name) }}
         {{ page_footer(
           'Save',
-          back_link=url_for('.service_settings', service_id=service_id)
+          back_link=url_for('.service_settings', service_id=service_id),
+          back_link_text='Back to settings'
         ) }}
       </form>
     </div>

app/templates/views/service-settings/request-to-go-live.html

@@ -39,7 +39,8 @@
       <form method="post">
         {{ page_footer(
           'Send request',
-          back_link=url_for('.service_settings', service_id=service_id)
+          back_link=url_for('.service_settings', service_id=service_id),
+          back_link_text='Back to settings'
         ) }}
       </form>
 

app/templates/views/service-settings/status.html

@@ -23,9 +23,10 @@ GOV.UK Notify | Service settings
 
       <form method="post">
         {{ page_footer(
-          'Turn off all outgoing notifications',
+          'Suspend API keys',
           destructive=True,
-          back_link=url_for('.service_settings', service_id=service_id)
+          back_link=url_for('.service_settings', service_id=service_id),
+          back_link_text='Back to settings'
         ) }}
       </form>
 

app/templates/views/signin.html

@@ -17,7 +17,7 @@ Sign in
     <form autocomplete="off" method="post">
       {{ textbox(form.email_address) }}
       {{ textbox(form.password) }}
-      {{ page_footer("Continue", back_link=url_for('.forgot_password'), back_link_text="Forgotten password?") }}
+      {{ page_footer("Continue", secondary_link=url_for('.forgot_password'), secondary_link_text="Forgotten password?") }}
     </form>
   </div>
 </div>

app/templates/views/user-profile/change-password.html

@@ -17,8 +17,8 @@ GOV.UK Notify | Service settings
         {{ textbox(form.new_password) }}
         {{ page_footer(
           'Save',
-          back_link=url_for('.user_profile'),
-          back_link_text="Back to your profile"
+          secondary_link=url_for('.user_profile'),
+          secondary_link_text="Back to your profile"
         ) }}
       </form>
     </div>