From 0eb967bb7c023bdca5675c54904434e7ac78067e Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Thu, 25 Nov 2021 10:07:53 +0000 Subject: [PATCH] Refactor into list expression This is maybe a bit of personal preference but generally I find list expressions a bit more Pythonic that `append`-ing. --- app/main/views/organisations.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/app/main/views/organisations.py b/app/main/views/organisations.py index aaa6e1bea..f29f47e04 100644 --- a/app/main/views/organisations.py +++ b/app/main/views/organisations.py @@ -191,10 +191,14 @@ def download_organisation_usage_report(org_id): list(unit_column_names.items()) + list(monetary_column_names.items()) ) - org_usage_data = [[x for x in column_names.values()]] - - for service in services_usage: - org_usage_data.append([service[attribute] for attribute in column_names.keys()]) + org_usage_data = [ + list(column_names.values()) + ] + [ + [ + service[attribute] for attribute in column_names.keys() + ] + for service in services_usage + ] return Spreadsheet.from_rows(org_usage_data).as_csv_data, 200, { 'Content-Type': 'text/csv; charset=utf-8',