darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-24 01:49:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix linter errors

Browse Source
This commit is contained in:
Leo Hemsted
2017-10-27 10:56:03 +01:00
parent 828c2de475
commit 0ea68f9c6d
4 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/main/views/test_conversation.py
View File

@@ -50,7 +50,7 @@ def test_get_user_phone_number_when_only_outbound_exists(mocker):
mock_get_notification.assert_called_once_with('service', 'notification')
def test_get_user_phone_number_raises_if_both_API_requests_fail(mocker):
def test_get_user_phone_number_raises_if_both_api_requests_fail(mocker):
mock_get_inbound_sms = mocker.patch(
'app.main.views.conversation.service_api_client.get_inbound_sms_by_id',
side_effect=HTTPError,

20
tests/app/main/views/test_letter_jobs.py
View File

@@ -31,7 +31,7 @@ valid_letter_jobs = [
send_letter_jobs_response = {"response": "Task created to send files to DVLA"}
class letter_jobs_header(IntEnum):
class LetterJobsHeader(IntEnum):
SERVICE_NAME = 0
JOB_ID = 1
NOTIFICATION_COUNT = 2
@@ -58,15 +58,15 @@ def test_get_letter_jobs_returns_list_of_all_letter_jobs(logged_in_platform_admi
for row_pos in range(len(rows)):
cols = rows[row_pos].find_all('td')
assert valid_letter_jobs[row_pos]['service_name']['name'] == cols[letter_jobs_header.SERVICE_NAME].text
assert valid_letter_jobs[row_pos]['id'] == cols[letter_jobs_header.JOB_ID].text
assert valid_letter_jobs[row_pos]['notification_count'] == int(cols[letter_jobs_header.NOTIFICATION_COUNT].text)
assert valid_letter_jobs[row_pos]['job_status'] == cols[letter_jobs_header.JOB_STATUS].text
assert valid_letter_jobs[row_pos]['service_name']['name'] == cols[LetterJobsHeader.SERVICE_NAME].text
assert valid_letter_jobs[row_pos]['id'] == cols[LetterJobsHeader.JOB_ID].text
assert valid_letter_jobs[row_pos]['notification_count'] == int(cols[LetterJobsHeader.NOTIFICATION_COUNT].text)
assert valid_letter_jobs[row_pos]['job_status'] == cols[LetterJobsHeader.JOB_STATUS].text
assert format_datetime_short(
valid_letter_jobs[row_pos]['created_at']) == cols[letter_jobs_header.CREATED_AT].text
valid_letter_jobs[row_pos]['created_at']) == cols[LetterJobsHeader.CREATED_AT].text
if not (valid_letter_jobs[row_pos]['job_status'] == 'ready to send' or
valid_letter_jobs[row_pos]['job_status'] == 'sent to dvla'):
assert 'disabled' in str(cols[letter_jobs_header.CHECKBOX])
assert 'disabled' in str(cols[LetterJobsHeader.CHECKBOX])
def test_post_letter_jobs_select_1_letter_job_submits_1_job(logged_in_platform_admin_client, mocker):
@@ -92,9 +92,9 @@ def test_post_letter_jobs_select_1_letter_job_submits_1_job(logged_in_platform_a
colr1 = rows[1].find_all('td')
colr2 = rows[2].find_all('td')
assert colr0[letter_jobs_header.TEMP_STATUS].text == "sending"
assert colr1[letter_jobs_header.TEMP_STATUS].text == ""
assert colr2[letter_jobs_header.TEMP_STATUS].text == ""
assert colr0[LetterJobsHeader.TEMP_STATUS].text == "sending"
assert colr1[LetterJobsHeader.TEMP_STATUS].text == ""
assert colr2[LetterJobsHeader.TEMP_STATUS].text == ""
message = page.find('p', attrs={'id': 'message'}).text
assert "Task created to send files to DVLA" in message