darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-16 03:10:16 -04:00
Code Issues Packages Projects Releases Wiki Activity

Update service_api_client to use new endpoints

Browse Source 
API now has separate endpoints to archive email reply-to addresses and
SMS senders, so we no longer need to use the endpoints for updating.
This commit is contained in:
Katie Smith
2018-04-26 15:09:37 +01:00
parent 965bc76c42
commit 0e370d511e
4 changed files with 32 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/app/main/views/test_service_settings.py
View File

@@ -1193,9 +1193,9 @@ def test_delete_reply_to_email_address(
service_one,
fake_uuid,
get_non_default_reply_to_email_address,
mock_update_reply_to_email_address,
mocker,
):
mock_delete = mocker.patch('app.service_api_client.delete_reply_to_email_address')
client_request.post(
'.service_delete_email_reply_to',
service_id=SERVICE_ONE_ID,
@@ -1206,12 +1206,7 @@ def test_delete_reply_to_email_address(
_external=True,
)
)
mock_update_reply_to_email_address.assert_called_once_with(
SERVICE_ONE_ID,
active=False,
reply_to_email_id=fake_uuid,
)
mock_delete.assert_called_once_with(service_id=SERVICE_ONE_ID, reply_to_email_id=fake_uuid)
@pytest.mark.parametrize('fixture, data, api_default_args', [
@@ -1435,9 +1430,9 @@ def test_delete_sms_sender(
service_one,
fake_uuid,
get_non_default_sms_sender,
mock_update_sms_sender,
mocker,
):
mock_delete = mocker.patch('app.service_api_client.delete_sms_sender')
client_request.post(
'.service_delete_sms_sender',
service_id=SERVICE_ONE_ID,
@@ -1448,12 +1443,7 @@ def test_delete_sms_sender(
_external=True,
)
)
mock_update_sms_sender.assert_called_once_with(
SERVICE_ONE_ID,
active=False,
sms_sender_id='1234',
)
mock_delete.assert_called_once_with(service_id=SERVICE_ONE_ID, sms_sender_id='1234')
@pytest.mark.parametrize('fixture, hide_textbox, fixture_sender_id', [

2
tests/app/notify_client/test_service_api_client.py
View File

@@ -344,10 +344,12 @@ def test_returns_value_from_cache(
(service_api_client, 'update_service_inbound_api', [SERVICE_ONE_ID] + [''] * 4, {}),
(service_api_client, 'add_reply_to_email_address', [SERVICE_ONE_ID, ''], {}),
(service_api_client, 'update_reply_to_email_address', [SERVICE_ONE_ID] + [''] * 2, {}),
(service_api_client, 'delete_reply_to_email_address', [SERVICE_ONE_ID, ''], {}),
(service_api_client, 'add_letter_contact', [SERVICE_ONE_ID, ''], {}),
(service_api_client, 'update_letter_contact', [SERVICE_ONE_ID] + [''] * 2, {}),
(service_api_client, 'add_sms_sender', [SERVICE_ONE_ID, ''], {}),
(service_api_client, 'update_sms_sender', [SERVICE_ONE_ID] + [''] * 2, {}),
(service_api_client, 'delete_sms_sender', [SERVICE_ONE_ID, ''], {}),
(service_api_client, 'update_service_callback_api', [SERVICE_ONE_ID] + [''] * 4, {}),
(service_api_client, 'create_service_callback_api', [SERVICE_ONE_ID] + [''] * 3, {}),
(user_api_client, 'add_user_to_service', [SERVICE_ONE_ID, fake_uuid(), []], {}),