darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-04 05:31:44 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor to add separate letter branding client

Browse Source 
We were getting all letter logos from a method in the email branding
client. Since we will be adding more client methods to deal with
letters, it makes things clearer to separate the email and letter
branding clients.
This commit is contained in:
Katie Smith
2019-01-23 12:27:14 +00:00
parent 284ec3ee3e
commit 0bf3a4b16d
10 changed files with 41 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/conftest.py
View File

@@ -2547,8 +2547,8 @@ def mock_get_email_branding_that_can_fit_onscreen(mocker):
@pytest.fixture(scope='function')
def mock_get_letter_email_branding(mocker):
def _get_letter_email_branding():
def mock_get_letter_branding(mocker):
def _get_letter_branding():
return {
'001': 'HM Government',
'500': 'Land Registry',
@@ -2556,7 +2556,7 @@ def mock_get_letter_email_branding(mocker):
}
return mocker.patch(
'app.email_branding_client.get_letter_email_branding', side_effect=_get_letter_email_branding
'app.letter_branding_client.get_letter_branding', side_effect=_get_letter_branding
)
@@ -2566,7 +2566,7 @@ def mock_no_email_branding(mocker):
return []
return mocker.patch(
'app.email_branding_client.get_letter_email_branding', side_effect=_get_email_branding
'app.email_branding_client.get_all_email_branding', side_effect=_get_email_branding
)