From f3c5d966f73d56db0d927e8d5a9312c197d1a8f1 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Fri, 14 Feb 2020 13:59:54 +0000 Subject: [PATCH 001/196] Simplify numbered lists of instructions --- .../guidance/branding-and-customisation.html | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/app/templates/views/guidance/branding-and-customisation.html b/app/templates/views/guidance/branding-and-customisation.html index 1f22ce366..88a3ec9ba 100644 --- a/app/templates/views/guidance/branding-and-customisation.html +++ b/app/templates/views/guidance/branding-and-customisation.html @@ -26,9 +26,8 @@

To change your email branding:

    -
  1. Sign in to Notify.
  2. -
  3. Go to the Settings page.
  4. -
  5. In the Email settings section, select Change on the Email branding row.
  6. +
  7. Go to the Email settings section of the Settings page.
  8. +
  9. Select Change on the Email branding row.

Add a reply-to email address

@@ -38,9 +37,8 @@

To add a reply-to email address:

    -
  1. Sign in to Notify.
  2. -
  3. Go to the Settings page.
  4. -
  5. In the Email settings section, select Manage on the Reply-to email addresses row.
  6. +
  7. Go to the Email settings section of the Settings page.
  8. +
  9. Select Manage on the Reply-to email addresses row.
  10. Select Add reply-to address.
@@ -51,9 +49,8 @@

To change the text message sender from the default of ‘GOVUK’:

    -
  1. Sign in to Notify.
  2. -
  3. Go to the Settings page.
  4. -
  5. In the Text message settings section, select Manage on the Text message senders row.
  6. +
  7. Go to the Text message settings section of the Settings page.
  8. +
  9. Select Manage on the Text message senders row.
  10. Select Change or Add text message sender.
@@ -64,9 +61,8 @@

To add a logo to your letters:

    -
  1. Sign in to Notify.
  2. -
  3. Go to the Settings page.
  4. -
  5. In the Letter settings section, select Change on the Letter branding row.
  6. +
  7. Go to the Letter settings section of the Settings page.
  8. +
  9. Select Change on the Letter branding row.
{% endblock %} From 29c8050bc4700933914061825ad76a86252b50e1 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Fri, 14 Feb 2020 14:02:08 +0000 Subject: [PATCH 002/196] Simplify numbered lists of instructions --- app/templates/views/guidance/create-and-send-messages.html | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/templates/views/guidance/create-and-send-messages.html b/app/templates/views/guidance/create-and-send-messages.html index 2fc567a6d..09b8334ba 100644 --- a/app/templates/views/guidance/create-and-send-messages.html +++ b/app/templates/views/guidance/create-and-send-messages.html @@ -16,8 +16,7 @@

To send a batch of messages at once:

    -
  1. Sign in to Notify.
  2. -
  3. Go to the Templates page and choose an existing template.
  4. +
  5. Go to the Templates page and choose an existing template.
  6. Select Send.
  7. If you’re sending emails, select Upload a list of email addresses. If you’re sending text messages, select Upload a list of phone numbers. If you’re sending letters, select Upload a list of addresses.
  8. From 390fcc2269200514940016c13d31e234d788c4f7 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Fri, 14 Feb 2020 14:04:46 +0000 Subject: [PATCH 003/196] Simplify numbered lists of instructions --- .../views/guidance/edit-and-format-messages.html | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/app/templates/views/guidance/edit-and-format-messages.html b/app/templates/views/guidance/edit-and-format-messages.html index 96e22b191..6e80f3dee 100644 --- a/app/templates/views/guidance/edit-and-format-messages.html +++ b/app/templates/views/guidance/edit-and-format-messages.html @@ -23,8 +23,7 @@

    You can see a list of formatting instructions on the edit template page:

      -
    1. Sign in to Notify.
    2. -
    3. Go to the Templates page.
    4. +
    5. Go to the Templates page.
    6. Add a new template or choose an existing template and select Edit.
    @@ -63,8 +62,7 @@

    To add a placeholder to the template:

      -
    1. Sign in to Notify.
    2. -
    3. Go to the Templates page.
    4. +
    5. Go to the Templates page.
    6. Add a new template or choose an existing template and select Edit.
    7. Add a placeholder using double brackets. For example: Hello ((first name)), your reference is ((ref number)).
    8. Select Save.
    9. @@ -84,8 +82,7 @@

      To add optional content to your emails and text messages:

        -
      1. Sign in to Notify.
      2. -
      3. Go to the Templates page.
      4. +
      5. Go to the Templates page.
      6. Add a new template or choose an existing template and select Edit.
      7. Use double brackets and ?? to define optional content. For example, if you only want to show something to people who are under 18: ((under18??Please get your application signed by a parent or guardian.))
      8. Select Save.
      9. From 2184f4c7047b0ba23570ca67ec930d7aa7e7f3ad Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Fri, 14 Feb 2020 14:09:32 +0000 Subject: [PATCH 004/196] Simplify numbered list of instructions Simplify numbered list of instructions and change file links --- app/templates/views/guidance/upload-a-letter.html | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/templates/views/guidance/upload-a-letter.html b/app/templates/views/guidance/upload-a-letter.html index 7d62565bb..2fbbec5d2 100644 --- a/app/templates/views/guidance/upload-a-letter.html +++ b/app/templates/views/guidance/upload-a-letter.html @@ -15,8 +15,7 @@

        To upload and send a letter from a PDF file:

          -
        1. Sign in to Notify.
        2. -
        3. Go to the Uploads page.
        4. +
        5. Go to the Uploads page.
        6. Select Upload a letter.
        7. Select Choose file.
        @@ -34,11 +33,11 @@

        The content of your letter must appear inside the printable area.

        -

        To help you set up your letter, you can download:

        +

        To help you set up your letter, you can download our:

        From 78ac345148a11ac93a242f5ef2a516f25b79e7f2 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 17 Feb 2020 12:58:05 +0000 Subject: [PATCH 005/196] Put day of week on This helps people understand how delivery dates fit into the week, because if sending a letter spans the weekend it will take a bit longer. We can remove `|string` now because `utc_string_to_aware_gmt_datetime` now accepts datetimes. --- app/__init__.py | 5 +++++ app/templates/views/notifications/notification.html | 2 +- tests/app/main/views/test_notifications.py | 6 ++++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/app/__init__.py b/app/__init__.py index 4daf81b80..0242fea30 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -334,6 +334,10 @@ def format_date_human(date): return get_human_day(date) +def format_day_of_week(date): + return utc_string_to_aware_gmt_datetime(date).strftime('%A') + + def _format_datetime_short(datetime): return datetime.strftime('%d %B').lstrip('0') @@ -743,6 +747,7 @@ def add_template_filters(application): format_date_normal, format_date_short, format_datetime_relative, + format_day_of_week, format_delta, format_notification_status, format_notification_type, diff --git a/app/templates/views/notifications/notification.html b/app/templates/views/notifications/notification.html index f422414ea..f2004a6ec 100644 --- a/app/templates/views/notifications/notification.html +++ b/app/templates/views/notifications/notification.html @@ -67,7 +67,7 @@ {{ letter_print_day }}

        - Estimated delivery date: {{ estimated_letter_delivery_date|string|format_date_short }} + Estimated delivery date: {{ estimated_letter_delivery_date|format_day_of_week }} {{ estimated_letter_delivery_date|format_date_short }}

        {% endif %} {% endif %} diff --git a/tests/app/main/views/test_notifications.py b/tests/app/main/views/test_notifications.py index 012ccaa1a..426aeade2 100644 --- a/tests/app/main/views/test_notifications.py +++ b/tests/app/main/views/test_notifications.py @@ -202,7 +202,7 @@ def test_notification_page_shows_page_for_letter_notification( 'Printing starts today at 5:30pm' ) assert normalize_spaces(page.select('main p:nth-of-type(3)')[0].text) == ( - 'Estimated delivery date: 6 January' + 'Estimated delivery date: Wednesday 6 January' ) assert len(page.select('.letter-postage')) == 1 assert normalize_spaces(page.select_one('.letter-postage').text) == ( @@ -473,7 +473,9 @@ def test_notification_page_shows_page_for_first_class_letter_notification( ) assert normalize_spaces(page.select('main p:nth-of-type(2)')[0].text) == 'Printing starts tomorrow at 5:30pm' - assert normalize_spaces(page.select('main p:nth-of-type(3)')[0].text) == 'Estimated delivery date: 5 January' + assert normalize_spaces(page.select('main p:nth-of-type(3)')[0].text) == ( + 'Estimated delivery date: Tuesday 5 January' + ) assert normalize_spaces(page.select_one('.letter-postage').text) == ( 'Postage: first class' ) From f4e4de0d03b90c4150452c18958fee02fc5fa72c Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Tue, 18 Feb 2020 10:35:21 +0000 Subject: [PATCH 006/196] Fix settings links --- .../views/guidance/branding-and-customisation.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/templates/views/guidance/branding-and-customisation.html b/app/templates/views/guidance/branding-and-customisation.html index 88a3ec9ba..18bb83068 100644 --- a/app/templates/views/guidance/branding-and-customisation.html +++ b/app/templates/views/guidance/branding-and-customisation.html @@ -26,7 +26,7 @@

        To change your email branding:

          -
        1. Go to the Email settings section of the Settings page.
        2. +
        3. Go to the Email settings section of the Settings page.
        4. Select Change on the Email branding row.
        @@ -37,7 +37,7 @@

        To add a reply-to email address:

          -
        1. Go to the Email settings section of the Settings page.
        2. +
        3. Go to the Email settings section of the Settings page.
        4. Select Manage on the Reply-to email addresses row.
        5. Select Add reply-to address.
        @@ -49,7 +49,7 @@

        To change the text message sender from the default of ‘GOVUK’:

          -
        1. Go to the Text message settings section of the Settings page.
        2. +
        3. Go to the Text message settings section of the Settings page.
        4. Select Manage on the Text message senders row.
        5. Select Change or Add text message sender.
        @@ -61,7 +61,7 @@

        To add a logo to your letters:

          -
        1. Go to the Letter settings section of the Settings page.
        2. +
        3. Go to the Letter settings section of the Settings page.
        4. Select Change on the Letter branding row.
        From 46a4e1c6124ad3a12a03d9e5082bce3017ba945e Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 19 Feb 2020 08:20:38 +0000 Subject: [PATCH 007/196] Add a macro for generating current service links MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a convenient way of being able to link into pages of the the app from guidance. It handles the case where the current service is not known, either because the user hasn’t chosen one, or because they’re not signed in. This commit also cleans up some unused Jinja imports. --- .../components/current-service-link.html | 7 ++++ .../guidance/branding-and-customisation.html | 33 +++++++++---------- .../guidance/create-and-send-messages.html | 11 +++---- .../guidance/edit-and-format-messages.html | 9 +++-- .../views/guidance/send-files-by-email.html | 7 ++-- .../views/guidance/upload-a-letter.html | 15 ++++----- 6 files changed, 41 insertions(+), 41 deletions(-) create mode 100644 app/templates/components/current-service-link.html diff --git a/app/templates/components/current-service-link.html b/app/templates/components/current-service-link.html new file mode 100644 index 000000000..807ba8ac4 --- /dev/null +++ b/app/templates/components/current-service-link.html @@ -0,0 +1,7 @@ +{% macro current_service_link(endpoint, link_text) %} + {% if current_service %} + {{ link_text }} + {% else %} + {{ link_text|capitalize }} + {% endif %} +{% endmacro %} diff --git a/app/templates/views/guidance/branding-and-customisation.html b/app/templates/views/guidance/branding-and-customisation.html index 18bb83068..cc68bcb75 100644 --- a/app/templates/views/guidance/branding-and-customisation.html +++ b/app/templates/views/guidance/branding-and-customisation.html @@ -1,6 +1,5 @@ {% extends "content_template.html" %} -{% from "components/table.html" import mapping_table, row, text_field, edit_field, field with context %} -{% from "components/sub-navigation.html" import sub_navigation %} +{% from "components/current-service-link.html" import current_service_link %} {% block per_page_title %} Branding and customisation @@ -9,59 +8,59 @@ {% block content_column_content %}

        Branding and customisation

        - +

        This page explains how to:

        - + - +

        Change your email branding

        The default branding for email templates is the GOV.UK logo.

        - +

        To change your email branding:

          -
        1. Go to the Email settings section of the Settings page.
        2. +
        3. Go to the Email settings section of the {{ current_service_link('main.service_settings', 'settings') }} page.
        4. Select Change on the Email branding row.

        Add a reply-to email address

        - +

        You can choose the email address that your users reply to. You must add at least one reply-to address for your service before you can request to go live.

        To add a reply-to email address:

          -
        1. Go to the Email settings section of the Settings page.
        2. +
        3. Go to the Email settings section of the {{ current_service_link('main.service_settings', 'settings') }} page.
        4. Select Manage on the Reply-to email addresses row.
        5. Select Add reply-to address.
        - +

        Change the text message sender

        - +

        The text message sender tells your users who the message is from.

        To change the text message sender from the default of ‘GOVUK’:

        - +
          -
        1. Go to the Text message settings section of the Settings page.
        2. +
        3. Go to the Text message settings section of the {{ current_service_link('main.service_settings', 'settings') }} page.
        4. Select Manage on the Text message senders row.
        5. Select Change or Add text message sender.

        Change your letter branding

        - +

        Letter templates do not have default branding.

        - +

        To add a logo to your letters:

        - +
          -
        1. Go to the Letter settings section of the Settings page.
        2. +
        3. Go to the Letter settings section of the {{ current_service_link('main.service_settings', 'settings') }} page.
        4. Select Change on the Letter branding row.
        diff --git a/app/templates/views/guidance/create-and-send-messages.html b/app/templates/views/guidance/create-and-send-messages.html index 09b8334ba..fa905b33d 100644 --- a/app/templates/views/guidance/create-and-send-messages.html +++ b/app/templates/views/guidance/create-and-send-messages.html @@ -1,6 +1,5 @@ {% extends "content_template.html" %} -{% from "components/table.html" import mapping_table, row, text_field, edit_field, field with context %} -{% from "components/sub-navigation.html" import sub_navigation %} +{% from "components/current-service-link.html" import current_service_link %} {% block per_page_title %} Send messages @@ -9,15 +8,15 @@ {% block content_column_content %}

        Send messages

        - +

        Create an account to see a short tutorial explaining how to create and send messages.

        - +

        Bulk sending

        To send a batch of messages at once:

          -
        1. Go to the Templates page and choose an existing template.
        2. +
        3. Go to the {{ current_service_link('main.choose_template', 'templates') }} page and choose an existing template.
        4. Select Send.
        5. If you’re sending emails, select Upload a list of email addresses. If you’re sending text messages, select Upload a list of phone numbers. If you’re sending letters, select Upload a list of addresses.
        6. - + {% endblock %} diff --git a/app/templates/views/guidance/edit-and-format-messages.html b/app/templates/views/guidance/edit-and-format-messages.html index 6e80f3dee..a80655a81 100644 --- a/app/templates/views/guidance/edit-and-format-messages.html +++ b/app/templates/views/guidance/edit-and-format-messages.html @@ -1,6 +1,5 @@ {% extends "content_template.html" %} -{% from "components/table.html" import mapping_table, row, text_field, edit_field, field with context %} -{% from "components/sub-navigation.html" import sub_navigation %} +{% from "components/current-service-link.html" import current_service_link %} {% block per_page_title %} Edit and format messages @@ -23,7 +22,7 @@

          You can see a list of formatting instructions on the edit template page:

            -
          1. Go to the Templates page.
          2. +
          3. Go to the {{ current_service_link('main.choose_template', 'templates') }} page.
          4. Add a new template or choose an existing template and select Edit.
          @@ -62,7 +61,7 @@

          To add a placeholder to the template:

            -
          1. Go to the Templates page.
          2. +
          3. Go to the {{ current_service_link('main.choose_template', 'templates') }} page.
          4. Add a new template or choose an existing template and select Edit.
          5. Add a placeholder using double brackets. For example: Hello ((first name)), your reference is ((ref number)).
          6. Select Save.
          7. @@ -82,7 +81,7 @@

            To add optional content to your emails and text messages:

              -
            1. Go to the Templates page.
            2. +
            3. Go to the {{ current_service_link('main.choose_template', 'templates') }} page.
            4. Add a new template or choose an existing template and select Edit.
            5. Use double brackets and ?? to define optional content. For example, if you only want to show something to people who are under 18: ((under18??Please get your application signed by a parent or guardian.))
            6. Select Save.
            7. diff --git a/app/templates/views/guidance/send-files-by-email.html b/app/templates/views/guidance/send-files-by-email.html index 329eb24b9..331039a2e 100644 --- a/app/templates/views/guidance/send-files-by-email.html +++ b/app/templates/views/guidance/send-files-by-email.html @@ -1,6 +1,4 @@ {% extends "content_template.html" %} -{% from "components/table.html" import mapping_table, row, text_field, edit_field, field with context %} -{% from "components/sub-navigation.html" import sub_navigation %} {% block per_page_title %} Send files by email @@ -9,10 +7,9 @@ {% block content_column_content %}

              Send files by email

              - +

              Contact us if you want to send files by email.

              Then follow the instructions to send a file by email in our API documentation.

              - + {% endblock %} - diff --git a/app/templates/views/guidance/upload-a-letter.html b/app/templates/views/guidance/upload-a-letter.html index 2fbbec5d2..42f33d765 100644 --- a/app/templates/views/guidance/upload-a-letter.html +++ b/app/templates/views/guidance/upload-a-letter.html @@ -1,6 +1,5 @@ {% extends "content_template.html" %} -{% from "components/table.html" import mapping_table, row, text_field, edit_field, field with context %} -{% from "components/sub-navigation.html" import sub_navigation %} +{% from "components/current-service-link.html" import current_service_link %} {% block per_page_title %} Upload a letter @@ -9,13 +8,13 @@ {% block content_column_content %}

              Upload a letter

              - +

              You can upload and send your own letters instead of creating a reusable letter template.

              - +

              To upload and send a letter from a PDF file:

              - +
                -
              1. Go to the Uploads page.
              2. +
              3. Go to the {{ current_service_link('main.uploads', 'uploads') }} page.
              4. Select Upload a letter.
              5. Select Choose file.
              @@ -30,9 +29,9 @@
            8. 10 pages or less
            9. smaller than 2MB
            10. - +

              The content of your letter must appear inside the printable area.

              - +

              To help you set up your letter, you can download our:

                From 904007201f8adf32fb7f9cf71bc7cc255a869018 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 19 Feb 2020 17:11:31 +0000 Subject: [PATCH 008/196] Make date of sending relative MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a friendlier and better way of showing dates anywhere except in a report which might be archived and referred back to later. Bit trickier to implement here because a dat requires ‘on’ beforehand, but we don’t say ‘on today’ in English. --- app/__init__.py | 21 +++++++-- .../views/notifications/notification.html | 2 +- tests/app/main/views/test_notifications.py | 45 ++++++++++++++----- 3 files changed, 52 insertions(+), 16 deletions(-) diff --git a/app/__init__.py b/app/__init__.py index 0242fea30..c2921bafc 100644 --- a/app/__init__.py +++ b/app/__init__.py @@ -291,7 +291,7 @@ def format_time_24h(date): return utc_string_to_aware_gmt_datetime(date).strftime('%H:%M') -def get_human_day(time): +def get_human_day(time, date_prefix=''): # Add 1 minute to transform 00:00 into ‘midnight today’ instead of ‘midnight tomorrow’ date = (utc_string_to_aware_gmt_datetime(time) - timedelta(minutes=1)).date() @@ -304,8 +304,15 @@ def get_human_day(time): if date == (now - timedelta(days=1)).date(): return 'yesterday' if date.strftime('%Y') != now.strftime('%Y'): - return '{} {}'.format(_format_datetime_short(date), date.strftime('%Y')) - return _format_datetime_short(date) + return '{} {} {}'.format( + date_prefix, + _format_datetime_short(date), + date.strftime('%Y'), + ).strip() + return '{} {}'.format( + date_prefix, + _format_datetime_short(date), + ).strip() def format_time(date): @@ -334,6 +341,13 @@ def format_date_human(date): return get_human_day(date) +def format_datetime_human(date, date_prefix=''): + return '{} at {}'.format( + get_human_day(date, date_prefix='on'), + format_time(date), + ) + + def format_day_of_week(date): return utc_string_to_aware_gmt_datetime(date).strftime('%A') @@ -746,6 +760,7 @@ def add_template_filters(application): format_date_human, format_date_normal, format_date_short, + format_datetime_human, format_datetime_relative, format_day_of_week, format_delta, diff --git a/app/templates/views/notifications/notification.html b/app/templates/views/notifications/notification.html index f2004a6ec..825adc81f 100644 --- a/app/templates/views/notifications/notification.html +++ b/app/templates/views/notifications/notification.html @@ -34,7 +34,7 @@ {% elif created_by %} by {{ created_by.name }} {% endif %} - on {{ created_at|format_datetime_short }} + {{ created_at|format_datetime_human }}

                {% if template.template_type == 'letter' %} diff --git a/tests/app/main/views/test_notifications.py b/tests/app/main/views/test_notifications.py index 426aeade2..10fc2d4d2 100644 --- a/tests/app/main/views/test_notifications.py +++ b/tests/app/main/views/test_notifications.py @@ -152,22 +152,43 @@ def test_notification_status_shows_expected_back_link( assert back_link is None -@freeze_time("2012-01-01 01:01") +@pytest.mark.parametrize('time_of_viewing_page, expected_message', ( + ('2012-01-01 01:01', ( + "‘sample template’ was sent by Test User today at 1:01am" + )), + ('2012-01-02 01:01', ( + "‘sample template’ was sent by Test User yesterday at 1:01am" + )), + ('2012-01-03 01:01', ( + "‘sample template’ was sent by Test User on 1 January at 1:01am" + )), + ('2013-01-03 01:01', ( + "‘sample template’ was sent by Test User on 1 January 2012 at 1:01am" + )), +)) def test_notification_page_doesnt_link_to_template_in_tour( + mocker, client_request, fake_uuid, mock_get_notification, + time_of_viewing_page, + expected_message, ): - page = client_request.get( - 'main.view_notification', - service_id=SERVICE_ONE_ID, - notification_id=fake_uuid, - help=3, - ) + with freeze_time('2012-01-01 01:01'): + notification = create_notification() + mocker.patch('app.notification_api_client.get_notification', return_value=notification) + + with freeze_time(time_of_viewing_page): + page = client_request.get( + 'main.view_notification', + service_id=SERVICE_ONE_ID, + notification_id=fake_uuid, + help=3, + ) assert normalize_spaces(page.select('main p:nth-of-type(1)')[0].text) == ( - "‘sample template’ was sent by Test User on 1 January at 1:01am" + expected_message ) assert len(page.select('main p:nth-of-type(1) a')) == 0 @@ -196,7 +217,7 @@ def test_notification_page_shows_page_for_letter_notification( ) assert normalize_spaces(page.select('main p:nth-of-type(1)')[0].text) == ( - "‘sample template’ was sent by Test User on 1 January at 1:01am" + "‘sample template’ was sent by Test User today at 1:01am" ) assert normalize_spaces(page.select('main p:nth-of-type(2)')[0].text) == ( 'Printing starts today at 5:30pm' @@ -230,13 +251,13 @@ def test_notification_page_shows_page_for_letter_notification( @pytest.mark.parametrize('is_precompiled_letter, expected_p1, expected_p2, expected_postage', ( ( True, - 'Provided as PDF on 1 January at 1:01am', + 'Provided as PDF today at 1:01am', 'This letter passed our checks, but we will not print it because you used a test key.', 'Postage: second class' ), ( False, - '‘sample template’ was sent on 1 January at 1:01am', + '‘sample template’ was sent today at 1:01am', 'We will not print this letter because you used a test key.', 'Postage: second class', ), @@ -377,7 +398,7 @@ def test_notification_page_shows_cancelled_or_failed_letter( ) assert normalize_spaces(page.select('main p')[0].text) == ( - "‘sample template’ was sent by Test User on 1 January at 1:01am" + "‘sample template’ was sent by Test User today at 1:01am" ) assert normalize_spaces(page.select('main p')[1].text) == ( expected_message From 46e16c64fc5732673a76432e32485ea3fa20a566 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Wed, 19 Feb 2020 17:18:03 +0000 Subject: [PATCH 009/196] =?UTF-8?q?Say=20=E2=80=98Uploaded=E2=80=99=20for?= =?UTF-8?q?=20one-off=20precompiled=20letters?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This calls back to what the user has actively done. _Provided as a PDF_ is more passive and suitable for PDF letters sent using the API. --- .../views/notifications/notification.html | 6 ++- tests/app/main/views/test_notifications.py | 45 +++++++++++++++++++ 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/app/templates/views/notifications/notification.html b/app/templates/views/notifications/notification.html index 825adc81f..8aa91cb08 100644 --- a/app/templates/views/notifications/notification.html +++ b/app/templates/views/notifications/notification.html @@ -17,7 +17,11 @@ ) }}

                {% if is_precompiled_letter %} - Provided as PDF + {% if created_by %} + Uploaded + {% else %} + Provided as PDF + {% endif %} {% else %} {% if help %} ‘{{ template.name }}’ diff --git a/tests/app/main/views/test_notifications.py b/tests/app/main/views/test_notifications.py index 10fc2d4d2..590e61c89 100644 --- a/tests/app/main/views/test_notifications.py +++ b/tests/app/main/views/test_notifications.py @@ -247,6 +247,51 @@ def test_notification_page_shows_page_for_letter_notification( assert mock_page_count.call_args_list[0][1]['values'] == {'name': 'Jo'} +@freeze_time("2020-01-01 00:00") +def test_notification_page_shows_uploaded_letter( + client_request, + mocker, + fake_uuid, +): + mocker.patch( + 'app.main.views.notifications.view_letter_notification_as_preview', + return_value=(b'foo', { + 'message': '', + 'invalid_pages': '[]', + 'page_count': '1' + }) + ) + mocker.patch( + 'app.main.views.notifications.pdf_page_count', + return_value=1 + ) + mocker.patch( + 'app.main.views.notifications.get_page_count_for_letter', + return_value=1, + ) + + notification = create_notification( + notification_status='created', + template_type='letter', + is_precompiled_letter=True, + sent_one_off=True, + ) + mocker.patch('app.notification_api_client.get_notification', return_value=notification) + + page = client_request.get( + 'main.view_notification', + service_id=SERVICE_ONE_ID, + notification_id=fake_uuid, + ) + + assert normalize_spaces(page.select('main p:nth-of-type(1)')[0].text) == ( + 'Uploaded by Test User yesterday at midnight' + ) + assert normalize_spaces(page.select('main p:nth-of-type(2)')[0].text) == ( + 'Printing starts today at 5:30pm' + ) + + @freeze_time("2016-01-01 01:01") @pytest.mark.parametrize('is_precompiled_letter, expected_p1, expected_p2, expected_postage', ( ( From cd36182ea67e64a3f300adfef74b5de4c4121353 Mon Sep 17 00:00:00 2001 From: Tom Byers Date: Fri, 6 Dec 2019 07:53:46 +0000 Subject: [PATCH 010/196] Update all links to use GOVUK Frontend style Includes: - turning off :visited styles to match existing design - swapping heading classes used to make links bold for the GOVUK Frontend bold override class - adding visually hidden text to some links to make them work when isolated from their context We may need to revisit whether some links, such as those for documentation and features, may benefit from having some indication that their target has been visited. --- app/templates/components/big-number.html | 4 ++-- app/templates/components/browse-list.html | 2 +- app/templates/components/file-upload.html | 2 +- app/templates/components/folder-path.html | 12 +++++----- app/templates/components/page-footer.html | 4 ++-- app/templates/components/pill.html | 2 +- .../components/previous-next-navigation.html | 4 ++-- app/templates/components/show-more.html | 2 +- app/templates/components/status-box.html | 2 +- app/templates/components/sub-navigation.html | 2 +- app/templates/components/table.html | 6 ++--- app/templates/components/task-list.html | 2 +- app/templates/components/textbox.html | 2 +- app/templates/error/401.html | 2 +- app/templates/error/404.html | 2 +- app/templates/error/410.html | 2 +- app/templates/error/413.html | 2 +- app/templates/error/500.html | 4 ++-- app/templates/main_nav.html | 22 +++++++++---------- app/templates/org_nav.html | 8 +++---- app/templates/org_template.html | 4 ++-- .../check/not-allowed-to-send-to.html | 2 +- .../partials/check/too-many-messages.html | 2 +- .../trying-to-send-letters-in-trial-mode.html | 2 +- .../partials/jobs/notifications.html | 6 ++--- .../partials/notifications/status.html | 2 +- .../templates/guidance-character-count.html | 2 +- .../partials/templates/guidance-postage.html | 2 +- .../templates/guidance-send-a-document.html | 2 +- app/templates/partials/tour.html | 2 +- .../views/activity/notifications.html | 2 +- .../views/agreement/agreement-public.html | 2 +- .../agreement/service-agreement-choose.html | 2 +- .../agreement/service-agreement-signed.html | 2 +- .../views/agreement/service-agreement.html | 2 +- .../callbacks/delivery-status-callback.html | 2 +- .../received-text-messages-callback.html | 2 +- app/templates/views/api/index.html | 10 ++++----- app/templates/views/api/keys.html | 2 +- app/templates/views/api/whitelist.html | 6 ++--- app/templates/views/check/column-errors.html | 6 ++--- app/templates/views/check/ok.html | 4 ++-- app/templates/views/check/row-errors.html | 4 ++-- app/templates/views/choose-account.html | 6 ++--- .../views/conversations/conversation.html | 2 +- .../views/dashboard/_inbox_messages.html | 4 ++-- app/templates/views/dashboard/_jobs.html | 4 ++-- app/templates/views/dashboard/_upcoming.html | 2 +- .../dashboard/all-template-statistics.html | 2 +- .../views/dashboard/template-statistics.html | 2 +- .../views/dashboard/write-first-messages.html | 2 +- app/templates/views/documentation.html | 4 ++-- .../views/edit-user-permissions.html | 10 +++++++-- .../views/email-branding/select-branding.html | 2 +- app/templates/views/email-link-invalid.html | 2 +- app/templates/views/features.html | 18 +++++++-------- app/templates/views/features/emails.html | 10 ++++----- app/templates/views/features/letters.html | 8 +++---- .../views/features/text-messages.html | 8 +++---- .../find-services/find-services-by-name.html | 2 +- .../views/find-users/find-users-by-email.html | 2 +- .../views/find-users/user-information.html | 6 ++--- app/templates/views/get-started.html | 20 ++++++++--------- app/templates/views/inbound-sms-admin.html | 2 +- app/templates/views/integration-testing.html | 2 +- app/templates/views/jobs/job.html | 2 +- .../select-letter-branding.html | 2 +- app/templates/views/manage-users.html | 4 ++-- app/templates/views/message-status.html | 4 ++-- app/templates/views/notifications.html | 2 +- app/templates/views/notifications/check.html | 2 +- .../views/notifications/notification.html | 10 ++++----- .../views/organisations/add-organisation.html | 4 ++-- app/templates/views/organisations/index.html | 4 ++-- .../organisations/organisation/index.html | 2 +- .../organisation/trial-mode-services.html | 2 +- .../organisation/users/index.html | 2 +- .../views/platform-admin/_base_template.html | 2 +- .../views/platform-admin/reports.html | 8 +++---- .../views/platform-admin/services.html | 2 +- app/templates/views/pricing/how-to-pay.html | 4 ++-- app/templates/views/pricing/index.html | 6 ++--- app/templates/views/privacy.html | 10 ++++----- app/templates/views/providers/providers.html | 2 +- app/templates/views/roadmap.html | 2 +- app/templates/views/security.html | 12 +++++----- app/templates/views/send-test.html | 4 ++-- app/templates/views/send.html | 2 +- app/templates/views/service-settings.html | 12 +++++----- .../email-reply-to/_verify-updates.html | 2 +- .../service-settings/email_reply_to.html | 2 +- .../letter-contact-details.html | 4 ++-- .../preview-letter-branding.html | 2 +- .../service-settings/request-to-go-live.html | 2 +- .../views/service-settings/set-auth-type.html | 4 ++-- .../service-settings/set-inbound-sms.html | 6 ++--- .../set-international-sms.html | 2 +- .../views/service-settings/set-letter.html | 2 +- .../views/service-settings/set-sms.html | 2 +- .../views/service-settings/sms-senders.html | 2 +- app/templates/views/signedout.html | 12 +++++----- app/templates/views/signin.html | 2 +- app/templates/views/styleguide.html | 8 +++---- app/templates/views/support/bat-phone.html | 6 ++--- app/templates/views/support/index.html | 2 +- .../views/support/report-problem.html | 2 +- app/templates/views/templates/_template.html | 16 +++++++------- .../views/templates/_template_list.html | 6 ++--- .../views/templates/action_blocked.html | 2 +- .../views/templates/choose-reply.html | 6 ++--- app/templates/views/templates/choose.html | 2 +- .../views/templates/choose_history.html | 2 +- app/templates/views/templates/copy.html | 10 ++++----- .../views/templates/set-template-sender.html | 2 +- app/templates/views/templates/template.html | 6 ++--- app/templates/views/terms-of-use.html | 10 ++++----- app/templates/views/trial-mode.html | 2 +- app/templates/views/uploads/choose-file.html | 2 +- app/templates/views/uploads/preview.html | 2 +- app/templates/views/usage.html | 2 +- app/templates/views/using-notify.html | 14 ++++++------ app/templates/withnav_template.html | 4 ++-- app/templates/withoutnav_template.html | 2 +- 123 files changed, 272 insertions(+), 266 deletions(-) diff --git a/app/templates/components/big-number.html b/app/templates/components/big-number.html index 8ca33b3fb..8b5176a04 100644 --- a/app/templates/components/big-number.html +++ b/app/templates/components/big-number.html @@ -1,6 +1,6 @@ {% macro big_number(number, label, link=None, currency='', smaller=False, smallest=False) %} {% if link %} - + {% endif %}

                @@ -42,7 +42,7 @@
                {% if failures %} {% if failure_link %} - + {{ "{:,}".format(failures) }} failed – {{ failure_percentage }}% diff --git a/app/templates/components/browse-list.html b/app/templates/components/browse-list.html index d59e9ae37..43ce53729 100644 --- a/app/templates/components/browse-list.html +++ b/app/templates/components/browse-list.html @@ -5,7 +5,7 @@ {% for item in items %} {% if item.title and item.link %}
              • - {{ item.title }} + {{ item.title }} {% if item.hint %}
                {{ item.hint }} diff --git a/app/templates/components/file-upload.html b/app/templates/components/file-upload.html index 647629248..1908f1e48 100644 --- a/app/templates/components/file-upload.html +++ b/app/templates/components/file-upload.html @@ -32,7 +32,7 @@ {% if alternate_link and alternate_link_text %} - or {{ alternate_link_text }} + or {{ alternate_link_text }} {% endif %} diff --git a/app/templates/components/folder-path.html b/app/templates/components/folder-path.html index 5400e91c2..0d1900745 100644 --- a/app/templates/components/folder-path.html +++ b/app/templates/components/folder-path.html @@ -17,12 +17,12 @@ {% else %} {% if folder.id %} {% if current_user.has_template_folder_permission(folder) %} - {{ folder.name }} + {{ folder.name }} {% else %} {{ folder.name }} {% endif %} {% else %} - Templates + Templates {% endif %} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% endif %} @@ -40,7 +40,7 @@ {% if folder_path %}

                {% if folder_path|length == 1 %} - Services + Services {{ folder_path_separator() }} {% endif %} {% for folder in folder_path %} @@ -51,15 +51,15 @@ {% else %} {% if folder.id %} {% if current_user.has_template_folder_permission(folder) %} - {{ folder.name }} + {{ folder.name }} {% else %} {{ folder.name }} {% endif %} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% elif folder.parent_id == None %} - {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} + {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% else %} - {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} + {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% endif %} {% endif %} {% endfor %} diff --git a/app/templates/components/page-footer.html b/app/templates/components/page-footer.html index fb9f478be..deae3e7cf 100644 --- a/app/templates/components/page-footer.html +++ b/app/templates/components/page-footer.html @@ -26,11 +26,11 @@ {% endif %} {% if delete_link %} - {{ delete_link_text }} + {{ delete_link_text }} {% endif %} {% if secondary_link and secondary_link_text %} - {{ secondary_link_text }} + {{ secondary_link_text }} {% endif %}

                {% endmacro %} diff --git a/app/templates/components/pill.html b/app/templates/components/pill.html index bcbb5408b..d6a416522 100644 --- a/app/templates/components/pill.html +++ b/app/templates/components/pill.html @@ -13,7 +13,7 @@
                {% else %}
              • - + {% endif %} {% if show_count %} {{ big_number(count, **big_number_args) }} diff --git a/app/templates/components/previous-next-navigation.html b/app/templates/components/previous-next-navigation.html index b73846c6a..483dc3f18 100644 --- a/app/templates/components/previous-next-navigation.html +++ b/app/templates/components/previous-next-navigation.html @@ -4,7 +4,7 @@
              • diff --git a/app/templates/error/401.html b/app/templates/error/401.html index 74747f50e..be999a765 100644 --- a/app/templates/error/401.html +++ b/app/templates/error/401.html @@ -4,6 +4,6 @@

                You’re not authorised to see this page

                -

                Sign in to GOV.UK Notify and try again.

                +

                Sign in to GOV.UK Notify and try again.

                {% endblock %} diff --git a/app/templates/error/404.html b/app/templates/error/404.html index acb43af52..170b4acc0 100644 --- a/app/templates/error/404.html +++ b/app/templates/error/404.html @@ -13,7 +13,7 @@ If you pasted the web address, check you copied the entire address.

                - If the web address is correct or you selected a link or button, contact us. + If the web address is correct or you selected a link or button, contact us.

                diff --git a/app/templates/error/410.html b/app/templates/error/410.html index acb43af52..170b4acc0 100644 --- a/app/templates/error/410.html +++ b/app/templates/error/410.html @@ -13,7 +13,7 @@ If you pasted the web address, check you copied the entire address.

                - If the web address is correct or you selected a link or button, contact us. + If the web address is correct or you selected a link or button, contact us.

                diff --git a/app/templates/error/413.html b/app/templates/error/413.html index 4dfddc603..28304e083 100644 --- a/app/templates/error/413.html +++ b/app/templates/error/413.html @@ -12,7 +12,7 @@ Files must be smaller than 5 MB.

                - Go back and try again. + Go back and try again.

                diff --git a/app/templates/error/500.html b/app/templates/error/500.html index 0d3109996..0d352163b 100644 --- a/app/templates/error/500.html +++ b/app/templates/error/500.html @@ -10,10 +10,10 @@ Try again later.

                - You can check our system status page to see if there are any known issues. + You can check our system status page to see if there are any known issues.

                - To report a problem, email notify-support@digital.cabinet-office.gov.uk + To report a problem, email notify-support@digital.cabinet-office.gov.uk

                diff --git a/app/templates/main_nav.html b/app/templates/main_nav.html index 92c05dd6c..50e17b29d 100644 --- a/app/templates/main_nav.html +++ b/app/templates/main_nav.html @@ -5,32 +5,32 @@ diff --git a/app/templates/org_nav.html b/app/templates/org_nav.html index a9f518e11..dcf8cba8f 100644 --- a/app/templates/org_nav.html +++ b/app/templates/org_nav.html @@ -1,10 +1,10 @@ diff --git a/app/templates/org_template.html b/app/templates/org_template.html index 32bbdab14..8de05e493 100644 --- a/app/templates/org_template.html +++ b/app/templates/org_template.html @@ -8,12 +8,12 @@
                diff --git a/app/templates/partials/check/not-allowed-to-send-to.html b/app/templates/partials/check/not-allowed-to-send-to.html index 7ab180295..d3ee32933 100644 --- a/app/templates/partials/check/not-allowed-to-send-to.html +++ b/app/templates/partials/check/not-allowed-to-send-to.html @@ -7,6 +7,6 @@ {%- endif %}

                - In trial mode you can only + In trial mode you can only send to yourself and members of your team

                diff --git a/app/templates/partials/check/too-many-messages.html b/app/templates/partials/check/too-many-messages.html index a26fb9a13..341622ba5 100644 --- a/app/templates/partials/check/too-many-messages.html +++ b/app/templates/partials/check/too-many-messages.html @@ -8,7 +8,7 @@

                You can only send {{ current_service.message_limit }} messages per day {%- if current_service.trial_mode %} - in trial mode + in trial mode {%- endif -%} .

                diff --git a/app/templates/partials/check/trying-to-send-letters-in-trial-mode.html b/app/templates/partials/check/trying-to-send-letters-in-trial-mode.html index 43f225e75..55c8f784d 100644 --- a/app/templates/partials/check/trying-to-send-letters-in-trial-mode.html +++ b/app/templates/partials/check/trying-to-send-letters-in-trial-mode.html @@ -3,6 +3,6 @@ {{ 'this letter' if count_of_recipients == 1 else 'these letters' }}

                - In trial mode you + In trial mode you can only preview how your letters will look

                diff --git a/app/templates/partials/jobs/notifications.html b/app/templates/partials/jobs/notifications.html index 869573da2..842a9d805 100644 --- a/app/templates/partials/jobs/notifications.html +++ b/app/templates/partials/jobs/notifications.html @@ -7,7 +7,7 @@

                Sending - {{ job.template.name }} + {{ job.template.name }} {{ job.scheduled_for|format_datetime_relative }}

                @@ -77,7 +77,7 @@ {% endif %} {% endfor %} {% if notification.status not in ('pending-virus-check', 'virus-scan-failed') %} - View {{ message_count_label(1, notification.template.template_type, suffix='') }} + View {{ message_count_label(1, notification.template.template_type, suffix='') }} {% endif %}
                diff --git a/app/templates/views/api/keys.html b/app/templates/views/api/keys.html index affe25b99..b9d0ba773 100644 --- a/app/templates/views/api/keys.html +++ b/app/templates/views/api/keys.html @@ -46,7 +46,7 @@ {% endcall %} {% else %} {% call field(align='right', status='error') %} - Revoke + Revoke {% endcall %} {% endif %} {% endcall %} diff --git a/app/templates/views/api/whitelist.html b/app/templates/views/api/whitelist.html index 18bc8a624..264397842 100644 --- a/app/templates/views/api/whitelist.html +++ b/app/templates/views/api/whitelist.html @@ -22,12 +22,12 @@ @@ -41,7 +41,7 @@

                You and members of - your team + your team are included in the whitelist automatically.

                diff --git a/app/templates/views/check/column-errors.html b/app/templates/views/check/column-errors.html index 976c7a17d..b9e641594 100644 --- a/app/templates/views/check/column-errors.html +++ b/app/templates/views/check/column-errors.html @@ -9,7 +9,7 @@ {% set file_contents_header_id = 'file-preview' %} {% macro skip_to_file_contents() %}

                - Skip to file contents + Skip to file contents

                {% endmacro %} @@ -150,7 +150,7 @@ ) }} {% endif %}
                - Back to top + Back to top
                {% if not request.args.from_test %} @@ -176,7 +176,7 @@ (not errors or recipients.more_rows_than_can_send) and displayed_index != preview_row ) %} - {{ displayed_index }} + {{ displayed_index }} {% else %} {{ displayed_index }} {% endif %} diff --git a/app/templates/views/check/ok.html b/app/templates/views/check/ok.html index a50744189..3ec9d2ac9 100644 --- a/app/templates/views/check/ok.html +++ b/app/templates/views/check/ok.html @@ -9,7 +9,7 @@ {% set file_contents_header_id = 'file-preview' %} {% macro skip_to_file_contents() %}

                - Skip to file contents + Skip to file contents

                {% endmacro %} @@ -76,7 +76,7 @@ {% if (item.index + 2) == preview_row %} {{ item.index + 2 }} {% else %} - {{ item.index + 2 }} + {{ item.index + 2 }} {% endif %} {% endcall %} diff --git a/app/templates/views/check/row-errors.html b/app/templates/views/check/row-errors.html index 6df7563fc..69b6bc373 100644 --- a/app/templates/views/check/row-errors.html +++ b/app/templates/views/check/row-errors.html @@ -9,7 +9,7 @@ {% set file_contents_header_id = 'file-preview' %} {% macro skip_to_file_contents() %}

                - Skip to file contents + Skip to file contents

                {% endmacro %} @@ -55,7 +55,7 @@ button_text='Upload your file again' ) }}
                - Back to top + Back to top
                diff --git a/app/templates/views/choose-account.html b/app/templates/views/choose-account.html index bfde30431..2eeb04202 100644 --- a/app/templates/views/choose-account.html +++ b/app/templates/views/choose-account.html @@ -21,7 +21,7 @@ {% endif %} {% for org in organisations %}
              • - {{ org.name }} + {{ org.name }}

                {{ org.count_of_live_services }} live service{% if org.count_of_live_services != 1 %}s{% endif %} @@ -30,7 +30,7 @@ {% endfor %} {% for service in services %}

              • - {{ service.name }} + {{ service.name }}
              • {% endfor %} {% if show_heading %} @@ -64,7 +64,7 @@

                A developer should be able to set up the API client and start sending test messages in around 30 minutes. A full integration can take a few days, depending on the other systems you’re using.

                Integrate directly with the API

                If you cannot use the client libraries, you can integrate directly with the API instead.

                -

                Read the REST API documentation (this link opens in a new tab).

                +

                Read the REST API documentation (this link opens in a new tab).

                {% endblock %} diff --git a/app/templates/views/edit-user-permissions.html b/app/templates/views/edit-user-permissions.html index 9847bf65b..e7d8fd378 100644 --- a/app/templates/views/edit-user-permissions.html +++ b/app/templates/views/edit-user-permissions.html @@ -25,11 +25,17 @@ ) }}

                - {{ user.email_address }} Change + {{ user.email_address }}  + + Change email address +

                {% if mobile_number %}

                - {{ mobile_number }} Change + {{ mobile_number }}  + + Change mobile number +

                {% endif %}
                diff --git a/app/templates/views/email-branding/select-branding.html b/app/templates/views/email-branding/select-branding.html index 9ffdcc341..267e04143 100644 --- a/app/templates/views/email-branding/select-branding.html +++ b/app/templates/views/email-branding/select-branding.html @@ -15,7 +15,7 @@ {% for brand in email_brandings %} diff --git a/app/templates/views/features.html b/app/templates/views/features.html index a0cdf2be3..fd9adcf40 100644 --- a/app/templates/views/features.html +++ b/app/templates/views/features.html @@ -12,13 +12,13 @@

                If you work for central government, a local authority or the NHS, you can use GOV.UK Notify to keep your users updated.

                Notify makes it easy to create, customise and send:

                You do not need any technical knowledge to use Notify.

                {% if not current_user.is_authenticated %} -

                Create an account for free and try it yourself.

                +

                Create an account for free and try it yourself.

                {% endif %}

                Reusable message templates

                @@ -34,11 +34,11 @@

                API integration

                You can integrate the Notify API with your web application or back-office system to send messages automatically.

                -

                Read our API documentation for more information.

                +

                Read our API documentation for more information.

                Reporting

                Notify’s real-time dashboard lets you see the number of messages sent. You can also check the current status of any message to see when it was delivered.

                -

                Read more about the delivery status of your messages.

                +

                Read more about the delivery status of your messages.

                Permissions

                Control which members of your team can see, create, edit and send messages.

                @@ -58,7 +58,7 @@

                We send messages through several different providers. If one provider fails, Notify switches to another so that your messages are not affected.

                -

                Visit GOV.UK Performance to see how Notify is performing.

                +

                Visit GOV.UK Performance to see how Notify is performing.

                Security

                Notify protects and manages data to meet the needs of government services.

                @@ -68,10 +68,10 @@

                Two-factor authentication

                Notify uses two-factor authentication (2FA) to keep your account secure. When you sign in, we’ll send a unique one-time code to your phone and ask you to enter it before we let you use your account.

                -

                Read more about security. +

                Read more about security.

                Support

                Notify provides 24-hour online support. If you have an emergency outside office hours, we’ll reply within 30 minutes.

                -

                Find out more about support.

                +

                Find out more about support.

                {% endblock %} diff --git a/app/templates/views/features/emails.html b/app/templates/views/features/emails.html index f9ddc5693..b66a87763 100644 --- a/app/templates/views/features/emails.html +++ b/app/templates/views/features/emails.html @@ -10,7 +10,7 @@

                Emails

                Send an unlimited number of emails for free with GOV.UK Notify.

                {% if not current_user.is_authenticated %} -

                Create an account and try Notify for yourself.

                +

                Create an account and try Notify for yourself.

                {% endif %}

                Features

                @@ -20,7 +20,7 @@
              • personalise the content of your emails
              • send and schedule bulk messages
              -

              You can also integrate with our API to send emails automatically.

              +

              You can also integrate with our API to send emails automatically.

              Email branding

              Add your organisation’s logo and brand colour to email templates.

              @@ -35,8 +35,8 @@
            11. email attachments are often marked as spam
            12. -

              Contact us if you want to send files by email.

              -

              Read our API documentation for more information.

              +

              Contact us if you want to send files by email.

              +

              Read our API documentation for more information.

              Add a reply-to address

              Notify lets you choose the email address that users reply to.

              @@ -45,6 +45,6 @@

              Pricing

              It’s free to send emails through Notify.

              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/features/letters.html b/app/templates/views/features/letters.html index c779951b3..19ccbf6a6 100644 --- a/app/templates/views/features/letters.html +++ b/app/templates/views/features/letters.html @@ -10,7 +10,7 @@

              Letters

              GOV.UK Notify will print, pack and post your letters for you.

              {% if not current_user.is_authenticated %} -

              Create an account and try Notify for yourself.

              +

              Create an account and try Notify for yourself.

              {% endif %}

              Features

              @@ -20,7 +20,7 @@
            13. personalise the content of your letter
            14. send bulk mail
            15. -

              You can also integrate with our API to send letters automatically.

              +

              You can also integrate with our API to send letters automatically.

              Choose your postage

              Notify can send letters by first or second class post.

              @@ -33,7 +33,7 @@

              Upload your own letters

              You can create reusable letter templates in Notify, or upload and send your own letters with the Notify API.

              -

              Read our documentation.

              +

              Read our documentation.

              Pricing

              It costs between 30p and 76p (plus VAT) to send a letter. Prices include:

              @@ -44,6 +44,6 @@
            16. first or second class postage
            17. Letters can be up to 10 pages long (5 double-sided sheets of paper).

              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/features/text-messages.html b/app/templates/views/features/text-messages.html index 270e192f5..80d6f644b 100644 --- a/app/templates/views/features/text-messages.html +++ b/app/templates/views/features/text-messages.html @@ -10,7 +10,7 @@

              Text messages

              Send thousands of free text messages to UK and international numbers with GOV.UK Notify.

              {% if not current_user.is_authenticated %} -

              Create an account and try Notify for yourself.

              +

              Create an account and try Notify for yourself.

              {% endif %}

              Features

              @@ -19,12 +19,12 @@
            18. create reusable text message templates
            19. personalise the content of your texts
            20. send and schedule bulk messages
            21. -

              You can also integrate with our API to send text messages automatically.

              +

              You can also integrate with our API to send text messages automatically.

              Receive text messages

              Let people send messages to your service or reply to your texts.

              You can see and reply to the messages you receive when you sign in to Notify. If you’re using our API, you can set up your own automated processes to manage replies.

              -

              Contact us to request a unique number for text message replies.

              +

              Contact us to request a unique number for text message replies.

              Show people who your texts are from

              When you send a text message with Notify, the sender name tells people who it's from.

              @@ -36,6 +36,6 @@
              • 250,000 free text messages for central government services
              • 25,000 free text messages for other public sector services
              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/find-services/find-services-by-name.html b/app/templates/views/find-services/find-services-by-name.html index 04ef957bf..a1fa28fda 100644 --- a/app/templates/views/find-services/find-services-by-name.html +++ b/app/templates/views/find-services/find-services-by-name.html @@ -43,7 +43,7 @@
                {% for service in services_found %}
              • - {{ service.name }} + {{ service.name }}

              • {% endfor %} diff --git a/app/templates/views/find-users/find-users-by-email.html b/app/templates/views/find-users/find-users-by-email.html index fc9380456..296977b9f 100644 --- a/app/templates/views/find-users/find-users-by-email.html +++ b/app/templates/views/find-users/find-users-by-email.html @@ -43,7 +43,7 @@
                  {% for user in users_found %}
                • - {{ user.email_address }} + {{ user.email_address }}

                  {{ user.name }}


                • diff --git a/app/templates/views/find-users/user-information.html b/app/templates/views/find-users/user-information.html index aa8d699a2..43bb4c5c3 100644 --- a/app/templates/views/find-users/user-information.html +++ b/app/templates/views/find-users/user-information.html @@ -19,7 +19,7 @@ @@ -35,7 +35,7 @@ @@ -62,7 +62,7 @@ {% endif %} {% if user.state == 'active' %} - + Archive user diff --git a/app/templates/views/get-started.html b/app/templates/views/get-started.html index 6b553053f..b54ad105d 100644 --- a/app/templates/views/get-started.html +++ b/app/templates/views/get-started.html @@ -14,7 +14,7 @@
                  1. Check if GOV.UK Notify is right for you

                    -

                    Read about our features, pricing and roadmap.

                    +

                    Read about our features, pricing and roadmap.

                    {{ govukDetails({ "summaryText": "Organisations that can use Notify", "html": ''' @@ -35,32 +35,32 @@
                  2. Create an account

                    {% if not current_user.is_authenticated %} -

                    Create an account for free and add your first Notify service. When you add a new service it will start in trial mode.

                    +

                    Create an account for free and add your first Notify service. When you add a new service it will start in trial mode.

                    {% else %} -

                    Create an account for free and add your first Notify service. When you add a new service, it will start in trial mode.

                    +

                    Create an account for free and add your first Notify service. When you add a new service, it will start in trial mode.

                    {% endif %}
                  3. Write some messages

                    -

                    Add message templates with examples of the content you plan to send. You can use our guidance to help you.

                    +

                    Add message templates with examples of the content you plan to send. You can use our guidance to help you.

                  4. Set up your service

                    {% if not current_user.is_authenticated or not current_service %}

                    Review your settings to add message branding, reply-to addresses and sender information.

                    -

                    Add team members and check their permissions.

                    +

                    Add team members and check their permissions.

                    {% else %} -

                    Review your settings to add message branding, reply-to addresses and sender information.

                    -

                    Add team members and check their permissions.

                    +

                    Review your settings to add message branding, reply-to addresses and sender information.

                    +

                    Add team members and check their permissions.

                    {% endif %}
                  5. Set up an API integration (optional)

                    You can use the Notify API to send messages automatically.

                    -

                    Our documentation explains how to integrate the API with a web application or back office system.

                    +

                    Our documentation explains how to integrate the API with a web application or back office system.

                  6. @@ -68,9 +68,9 @@ {% if not current_user.is_authenticated or not current_service %}

                    When you’re ready to send messages to people outside your team, go to the Settings page and select Request to go live. We’ll approve your request within one working day.

                    {% else %} -

                    You should request to go live when you’re ready to send messages to people outside your team. We’ll approve your request within one working day.

                    +

                    You should request to go live when you’re ready to send messages to people outside your team. We’ll approve your request within one working day.

                    {% endif %} -

                    Check how to pay if you’re planning to send letters or exceed the free text message allowance.

                    +

                    Check how to pay if you’re planning to send letters or exceed the free text message allowance.

                  diff --git a/app/templates/views/inbound-sms-admin.html b/app/templates/views/inbound-sms-admin.html index 31ecef8f3..8a83b6313 100644 --- a/app/templates/views/inbound-sms-admin.html +++ b/app/templates/views/inbound-sms-admin.html @@ -58,7 +58,7 @@ Inbound Numbers {% endif %} - {{ value.service.name }} + {{ value.service.name }} {% endfor %} diff --git a/app/templates/views/integration-testing.html b/app/templates/views/integration-testing.html index c1a18677a..121fca034 100644 --- a/app/templates/views/integration-testing.html +++ b/app/templates/views/integration-testing.html @@ -14,7 +14,7 @@

                  This information has moved.

                  - Refer to the documentation + Refer to the documentation for the client library you are using.

                  diff --git a/app/templates/views/jobs/job.html b/app/templates/views/jobs/job.html index 79080d928..2e06b56a4 100644 --- a/app/templates/views/jobs/job.html +++ b/app/templates/views/jobs/job.html @@ -25,7 +25,7 @@
                -

                If signing in with a text message is a problem for your team, contact us to find out about using an email link instead.

                +

                If signing in with a text message is a problem for your team, contact us to find out about using an email link instead.

                Information risk management

                Our approach to information risk management follows NCSC guidance. It assesses:

                @@ -65,8 +65,8 @@

                How we manage risks on Notify

                Things we do to manage risks on Notify include:

                  -
                • formal risk assessments based on ISO 2700:2011 and National Cyber Security Centre guidance
                • -
                • CHECK-based testing, both annually and when any major changes are made to Notify
                • +
                • formal risk assessments based on ISO 2700:2011 and National Cyber Security Centre guidance
                • +
                • CHECK-based testing, both annually and when any major changes are made to Notify
                • residual risk statement preparation and active management of the risk treatment plan
                • regular updates to the Privacy Impact Assessment
                • security impact assessments
                • @@ -77,8 +77,8 @@

                  Notify also has approval from the Office of the Government’s SIRO to host data within the EEA.

                  Classifications and security vetting

                  -

                  You can use Notify to send messages classified as ‘OFFICIAL’ or ‘OFFICIAL-SENSITIVE’ under the Government Security Classifications policy.

                  -

                  You must not use Notify to send ‘special category data’, as defined in the General Data Protection Regulation (GDPR).

                  -

                  The Notify team has Security Check (SC) level clearance from United Kingdom Security Vetting (UKSV).

                  +

                  You can use Notify to send messages classified as ‘OFFICIAL’ or ‘OFFICIAL-SENSITIVE’ under the Government Security Classifications policy.

                  +

                  You must not use Notify to send ‘special category data’, as defined in the General Data Protection Regulation (GDPR).

                  +

                  The Notify team has Security Check (SC) level clearance from United Kingdom Security Vetting (UKSV).

                  {% endblock %} diff --git a/app/templates/views/send-test.html b/app/templates/views/send-test.html index 20c1728f3..5ed3da4a1 100644 --- a/app/templates/views/send-test.html +++ b/app/templates/views/send-test.html @@ -31,13 +31,13 @@ {% if skip_link %} {% endif %} {% if link_to_upload %}

                  - + Upload a list of {{ recipient_count_label(999, template.template_type) }}

                  diff --git a/app/templates/views/send.html b/app/templates/views/send.html index 64772b9e6..f9bc93275 100644 --- a/app/templates/views/send.html +++ b/app/templates/views/send.html @@ -46,7 +46,7 @@ {% endcall %}

                  Your file will populate this template ({{ template.name }})

                  diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index a073efb1d..2e819dd6a 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -263,7 +263,7 @@

                  {% if current_user.has_permissions('manage_service') %} To remove these restrictions, you can send us a - request to go live. + request to go live. {% else %} Your service manager can ask to have these restrictions removed. {% endif %} @@ -279,7 +279,7 @@

                  Problems or comments? - Give feedback. + Give feedback.

                  {% endif %} @@ -318,7 +318,7 @@ {{ text_field('Organisation')}} {% call field() %} {% if current_service.organisation_id %} - + {{ current_service.organisation.name }} {% else %} @@ -375,13 +375,13 @@ {% if current_service.active and (current_service.trial_mode or current_user.platform_admin) %}

                  - + Delete this service {% if current_user.platform_admin %} - + Suspend service @@ -394,7 +394,7 @@ Service suspended - + Resume service diff --git a/app/templates/views/service-settings/email-reply-to/_verify-updates.html b/app/templates/views/service-settings/email-reply-to/_verify-updates.html index ccd22dfd5..a6cc0d476 100644 --- a/app/templates/views/service-settings/email-reply-to/_verify-updates.html +++ b/app/templates/views/service-settings/email-reply-to/_verify-updates.html @@ -15,7 +15,7 @@

                  - Refresh + Refresh

                  {% elif verification_status == "success" %} {{ banner("‘{}’ is ready to use".format(reply_to_email_address), type='default', with_tick=True) }} diff --git a/app/templates/views/service-settings/email_reply_to.html b/app/templates/views/service-settings/email_reply_to.html index 3c687ddd9..c163fdaec 100644 --- a/app/templates/views/service-settings/email_reply_to.html +++ b/app/templates/views/service-settings/email_reply_to.html @@ -31,7 +31,7 @@ {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if current_service.count_email_reply_to_addresses > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/service-settings/letter-contact-details.html b/app/templates/views/service-settings/letter-contact-details.html index 57527ec58..f57c5b2f0 100644 --- a/app/templates/views/service-settings/letter-contact-details.html +++ b/app/templates/views/service-settings/letter-contact-details.html @@ -22,7 +22,7 @@ Blank {% if current_service.default_letter_contact_block %} {% if current_user.has_permissions('manage_service') %} - Make default + Make default {% endif %} {% else %} (default) @@ -40,7 +40,7 @@ {% endif %}

                  {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if letter_contact_details|length > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/service-settings/preview-letter-branding.html b/app/templates/views/service-settings/preview-letter-branding.html index 9a5395e48..82e54509d 100644 --- a/app/templates/views/service-settings/preview-letter-branding.html +++ b/app/templates/views/service-settings/preview-letter-branding.html @@ -17,7 +17,7 @@ {{ form.hidden_tag() }} {% endcall %} diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index 15ea7e6a1..46991cd0c 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -69,7 +69,7 @@ When we receive your request we’ll get back to you within one working day.

                  - By requesting to go live you’re agreeing to our terms of use. + By requesting to go live you’re agreeing to our terms of use.

                  {% call form_wrapper() %} {{ page_footer('Request to go live') }} diff --git a/app/templates/views/service-settings/set-auth-type.html b/app/templates/views/service-settings/set-auth-type.html index 722f24bbe..aaa2c2744 100644 --- a/app/templates/views/service-settings/set-auth-type.html +++ b/app/templates/views/service-settings/set-auth-type.html @@ -24,7 +24,7 @@ or an email link.

                  - You can set the sign-in method for individual team members. + You can set the sign-in method for individual team members.

                  {% else %}

                  @@ -34,7 +34,7 @@ Your team members sign in with a text message code.

                  - Contact us if signing in with a text message is a problem for your team. + Contact us if signing in with a text message is a problem for your team.

                  {% endif %} diff --git a/app/templates/views/service-settings/set-inbound-sms.html b/app/templates/views/service-settings/set-inbound-sms.html index 72a2cb743..bd9fda22f 100644 --- a/app/templates/views/service-settings/set-inbound-sms.html +++ b/app/templates/views/service-settings/set-inbound-sms.html @@ -23,17 +23,17 @@ You can still send text messages from a sender name if you need to, but users will not be able to reply to those messages.

                  - Contact us if you want to switch this feature off. + Contact us if you want to switch this feature off.

                  {% if current_user.has_permissions('manage_api_keys') %}

                  You can set up callbacks for received text messages on the - API integration page. + API integration page.

                  {% endif %} {% else %}

                  - Contact us if you want to be able to receive text messages from your users. + Contact us if you want to be able to receive text messages from your users.

                  We’ll create a unique phone number for your service that they can reply to. diff --git a/app/templates/views/service-settings/set-international-sms.html b/app/templates/views/service-settings/set-international-sms.html index 8327c8b4d..400d47cc5 100644 --- a/app/templates/views/service-settings/set-international-sms.html +++ b/app/templates/views/service-settings/set-international-sms.html @@ -20,7 +20,7 @@ Messages to international mobile numbers are charged at 1, 2, or 3 times the cost of messages to UK mobile numbers.

                  - See pricing for the list + See pricing for the list of rates.

                  {% call form_wrapper() %} diff --git a/app/templates/views/service-settings/set-letter.html b/app/templates/views/service-settings/set-letter.html index 7d2f85c64..96f8b4e0c 100644 --- a/app/templates/views/service-settings/set-letter.html +++ b/app/templates/views/service-settings/set-letter.html @@ -20,7 +20,7 @@ It costs between 30p and 76p to send a letter using Notify.

                  - See pricing for the list + See pricing for the list of rates.

                  {% call form_wrapper() %} diff --git a/app/templates/views/service-settings/set-sms.html b/app/templates/views/service-settings/set-sms.html index ef7d62ecb..1c442e1b8 100644 --- a/app/templates/views/service-settings/set-sms.html +++ b/app/templates/views/service-settings/set-sms.html @@ -26,7 +26,7 @@ after your free allowance.

                  - See pricing for more details. + See pricing for more details.

                  {% call form_wrapper() %} {{ radios(form.enabled) }} diff --git a/app/templates/views/service-settings/sms-senders.html b/app/templates/views/service-settings/sms-senders.html index e36003fc9..7fcf59770 100644 --- a/app/templates/views/service-settings/sms-senders.html +++ b/app/templates/views/service-settings/sms-senders.html @@ -33,7 +33,7 @@ {% endif %} {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if current_service.count_sms_senders > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/signedout.html b/app/templates/views/signedout.html index 66e379a32..2b6bd0479 100644 --- a/app/templates/views/signedout.html +++ b/app/templates/views/signedout.html @@ -16,10 +16,10 @@ @@ -38,7 +38,7 @@ "classes": "product-page-button button-container__button govuk-!-margin-right-3", "href": url_for('main.register' ) }) }} - or sign in if you’ve used + or sign in if you’ve used it before @@ -135,7 +135,7 @@

                  See the - list of services and organisations. + list of services and organisations.

                  @@ -163,7 +163,7 @@

                  There’s no monthly charge, no setup fee and no procurement process.

                  -

                  Find out more about pricing. +

                  Find out more about pricing.

                  @@ -180,7 +180,7 @@ and is supported 24 hours a day, 7 days a week.

                  - Contact us if you have a question or want + Contact us if you have a question or want to give feedback.

                  diff --git a/app/templates/views/signin.html b/app/templates/views/signin.html index 047d51c8c..c51349b9a 100644 --- a/app/templates/views/signin.html +++ b/app/templates/views/signin.html @@ -27,7 +27,7 @@

                  Sign in

                  If you do not have an account, you can - create one now. + create one now.

                  {% endif %} diff --git a/app/templates/views/styleguide.html b/app/templates/views/styleguide.html index 430ffb399..34cbe4ea6 100644 --- a/app/templates/views/styleguide.html +++ b/app/templates/views/styleguide.html @@ -16,11 +16,11 @@ {% block maincolumn_content %}

                  - www.notify.works/_styleguide + www.notify.works/_styleguide

                  - View source + View source

                  Banner

                  @@ -125,7 +125,7 @@ {{ boolean_field(True) }} {{ boolean_field(False) }} {% call field(align='right') %} - Change + Change {% endcall %} {% endcall %} {% endcall %} @@ -173,7 +173,7 @@ {% endcall %} {% endcall %} diff --git a/app/templates/views/support/bat-phone.html b/app/templates/views/support/bat-phone.html index 6a48c0d4b..82b7b6972 100644 --- a/app/templates/views/support/bat-phone.html +++ b/app/templates/views/support/bat-phone.html @@ -15,7 +15,7 @@

                  First, check the - system status page. + system status page. You do not need to contact us if the problem you’re having is listed on that page.

                  @@ -33,11 +33,11 @@

                  Any other problems

                  - Fill in this form + Fill in this form and we’ll get back to you by the next working day.

                  - Back to support + Back to support

                  diff --git a/app/templates/views/support/index.html b/app/templates/views/support/index.html index f6106e732..77ba37be2 100644 --- a/app/templates/views/support/index.html +++ b/app/templates/views/support/index.html @@ -20,7 +20,7 @@ {{ page_footer('Continue') }} {% endcall %} -

                  You can also contact us on Slack.

                  +

                  You can also contact us on Slack.

                  Office hours

                  Our office hours are 9:30am to 5:30pm, Monday to Friday.

                  diff --git a/app/templates/views/support/report-problem.html b/app/templates/views/support/report-problem.html index 12f40e2c1..99c250640 100644 --- a/app/templates/views/support/report-problem.html +++ b/app/templates/views/support/report-problem.html @@ -19,7 +19,7 @@

                  - Check our system status + Check our system status page to see if there are any known issues with GOV.UK Notify.

                  diff --git a/app/templates/views/templates/_template.html b/app/templates/views/templates/_template.html index eecee2ece..a6550a7a7 100644 --- a/app/templates/views/templates/_template.html +++ b/app/templates/views/templates/_template.html @@ -23,7 +23,7 @@ {% endif %} {% if current_user.has_permissions('send_messages', restrict_admin_usage=True) and not letter_too_long %} @@ -31,14 +31,14 @@ {% else %} {% if current_user.has_permissions('send_messages', restrict_admin_usage=True) %} {% endif %} {% if current_user.has_permissions('manage_templates') %} @@ -51,14 +51,14 @@
                  {% if current_user.has_permissions('manage_templates') and template.template_type == 'letter' %} {% if not current_service.letter_branding_id %} - Add logo + Add logo {% endif %} - Change - Edit + Change + Edit {% if current_service.count_letter_contact_details %} - Edit + Edit {% else %} - Edit + Edit {% endif %} {% endif %} {{ template|string }} diff --git a/app/templates/views/templates/_template_list.html b/app/templates/views/templates/_template_list.html index 03956452b..5bcb03501 100644 --- a/app/templates/views/templates/_template_list.html +++ b/app/templates/views/templates/_template_list.html @@ -34,16 +34,16 @@ {% endif %}

                  {% for ancestor in item.ancestors %} - + {{- format_item_name(ancestor.name) -}} {% endfor %} {% if item.is_folder %} - + {{ format_item_name(item.name) }} {% else %} - + {{ format_item_name(item.name) }} {% endif %} diff --git a/app/templates/views/templates/action_blocked.html b/app/templates/views/templates/action_blocked.html index 84bb59b8e..c7b4b09c3 100644 --- a/app/templates/views/templates/action_blocked.html +++ b/app/templates/views/templates/action_blocked.html @@ -21,7 +21,7 @@

                  If you need to send {{ message_count_label(999, notification_type, suffix='') }} - get in touch with the GOV.UK Notify team. + get in touch with the GOV.UK Notify team.

                  diff --git a/app/templates/views/templates/choose-reply.html b/app/templates/views/templates/choose-reply.html index fa1681cef..823790da5 100644 --- a/app/templates/views/templates/choose-reply.html +++ b/app/templates/views/templates/choose-reply.html @@ -42,16 +42,16 @@

                  {% for ancestor in item.ancestors %} - + {{ ancestor.name }} / {% endfor %} {% if item.is_folder %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %} diff --git a/app/templates/views/templates/choose.html b/app/templates/views/templates/choose.html index 95691fc49..99812fc89 100644 --- a/app/templates/views/templates/choose.html +++ b/app/templates/views/templates/choose.html @@ -54,7 +54,7 @@

                  {% if current_user.has_permissions('manage_templates') and current_template_folder_id and user_has_template_folder_permission %} {% endif %}
                  diff --git a/app/templates/views/templates/choose_history.html b/app/templates/views/templates/choose_history.html index f8a045028..327932172 100644 --- a/app/templates/views/templates/choose_history.html +++ b/app/templates/views/templates/choose_history.html @@ -14,6 +14,6 @@ {% endfor %}

                  - Back to current templates + Back to current templates

                  {% endblock %} diff --git a/app/templates/views/templates/copy.html b/app/templates/views/templates/copy.html index 84c5a36ed..7aac461ec 100644 --- a/app/templates/views/templates/copy.html +++ b/app/templates/views/templates/copy.html @@ -25,23 +25,23 @@

                  {% for ancestor in item.ancestors %} {% if ancestor.is_service %} - + {% else %} - + {% endif %} {{ ancestor.name }} {% endfor %} {% if item.is_service %} - + {{ item.name }} {% elif item.is_folder %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %} diff --git a/app/templates/views/templates/set-template-sender.html b/app/templates/views/templates/set-template-sender.html index 75f76f686..5f8d449bf 100644 --- a/app/templates/views/templates/set-template-sender.html +++ b/app/templates/views/templates/set-template-sender.html @@ -23,7 +23,7 @@ hide_legend=True ) }} {{ page_footer('Continue') }} - Add new sender + Add new sender {% endcall %} diff --git a/app/templates/views/templates/template.html b/app/templates/views/templates/template.html index 410680fe7..bce2ec075 100644 --- a/app/templates/views/templates/template.html +++ b/app/templates/views/templates/template.html @@ -60,21 +60,21 @@

                    - See previous versions + See previous versions
                  {% endif %} {% if current_user.has_permissions('manage_templates') and user_has_template_permission %} {% if not template._template.archived %} - Delete this template + Delete this template   {% endif %} {% if template.template_type != 'letter' %} {% if not template._template.redact_personalisation %} - Hide personalisation after sending + Hide personalisation after sending {% else %}

                  Personalisation is hidden after sending

                  diff --git a/app/templates/views/terms-of-use.html b/app/templates/views/terms-of-use.html index 5109906c8..2974c2734 100644 --- a/app/templates/views/terms-of-use.html +++ b/app/templates/views/terms-of-use.html @@ -20,9 +20,9 @@
                • tell us immediately if you have any security breaches
                • keep your API keys secure
                • get the right levels of consent (to send messages and to use data)
                • -
                • not send unsolicited messages, only ones related to a transaction or something the user has subscribed to be updated about (check the Service Manual if you’re not sure)
                • +
                • not send unsolicited messages, only ones related to a transaction or something the user has subscribed to be updated about (check the Service Manual if you’re not sure)
                • - send messages that meet the GOV.UK Service Manual standards for writing text messages and emails
                • + send messages that meet the GOV.UK Service Manual standards for writing text messages and emails
                • not send messages containing any personally or commercially sensitive information
                • check that the data you add to Notify is accurate and complies with data protection legislation
                @@ -32,14 +32,14 @@
                • send all the messages you pass to us, as long as they meet our guidelines
                • - show how Notify is performing (through our performance and status pages) + show how Notify is performing (through our performance and status pages)
                • -
                • keep your data secure
                • +
                • keep your data secure
                • give you one month’s notice by email if we change our terms of use or delivery providers

                Leaving Notify

                -

                You can leave Notify at any time. Just contact us and we’ll close your account.

                +

                You can leave Notify at any time. Just contact us and we’ll close your account.

                When you leave Notify, all your data will be deleted.

                {% endblock %} diff --git a/app/templates/views/trial-mode.html b/app/templates/views/trial-mode.html index 316bc3b30..a367876c2 100644 --- a/app/templates/views/trial-mode.html +++ b/app/templates/views/trial-mode.html @@ -18,7 +18,7 @@ {% if current_service and current_service.trial_mode %}

                - To remove these restrictions, you can request to go live.

                + To remove these restrictions, you can request to go live.

                {% else %}

                To remove these restrictions: diff --git a/app/templates/views/uploads/choose-file.html b/app/templates/views/uploads/choose-file.html index 3897a6019..897926997 100644 --- a/app/templates/views/uploads/choose-file.html +++ b/app/templates/views/uploads/choose-file.html @@ -33,7 +33,7 @@ )}}

                You can upload a single letter as a PDF.

                -

                Your file must meet our letter specification.

                +

                Your file must meet our letter specification.

                diff --git a/app/templates/views/uploads/preview.html b/app/templates/views/uploads/preview.html index 718cf8c6d..05e70e5a8 100644 --- a/app/templates/views/uploads/preview.html +++ b/app/templates/views/uploads/preview.html @@ -24,7 +24,7 @@ button_text='Upload your file again' ) }} - Back to top + Back to top {% elif current_service.trial_mode %} diff --git a/app/templates/views/usage.html b/app/templates/views/usage.html index 294d25dfd..a91a4814f 100644 --- a/app/templates/views/usage.html +++ b/app/templates/views/usage.html @@ -132,7 +132,7 @@

                What counts as 1 text message?
                - See pricing. + See pricing.

                diff --git a/app/templates/views/using-notify.html b/app/templates/views/using-notify.html index f986accf4..41127b2b6 100644 --- a/app/templates/views/using-notify.html +++ b/app/templates/views/using-notify.html @@ -19,11 +19,11 @@

                Find out more about:

                - - - - {% block page_title %}GOV.UK - The best place to find government services and information{% endblock %} - - - - - - - - - - - - - - - - - - - - - - - - {% block head %}{% endblock %} - - - - - - - - - {% block body_start %}{% endblock %} - - - - - - - - - - {% block after_header %}{% endblock %} - -
                - - {% block content %}{% endblock %} - - - - - - - - {% block body_end %}{% endblock %} - - - - - From 853b2b137c6cffb39de42bd9c00eaf67f4336755 Mon Sep 17 00:00:00 2001 From: karlchillmaid Date: Thu, 20 Feb 2020 12:03:02 +0000 Subject: [PATCH 041/196] Remove links to templates and permissions --- app/templates/views/get-started.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/templates/views/get-started.html b/app/templates/views/get-started.html index 6b553053f..2fc4390c1 100644 --- a/app/templates/views/get-started.html +++ b/app/templates/views/get-started.html @@ -43,17 +43,17 @@
              • Write some messages

                -

                Add message templates with examples of the content you plan to send. You can use our guidance to help you.

                +

                Add message templates with examples of the content you plan to send. You can use our guidance to help you.

              • Set up your service

                {% if not current_user.is_authenticated or not current_service %}

                Review your settings to add message branding, reply-to addresses and sender information.

                -

                Add team members and check their permissions.

                +

                Add team members and check their permissions.

                {% else %}

                Review your settings to add message branding, reply-to addresses and sender information.

                -

                Add team members and check their permissions.

                +

                Add team members and check their permissions.

                {% endif %}
              • From 5b306dde4d78a25ec6c3baf9d9e8ef631293c46e Mon Sep 17 00:00:00 2001 From: Tom Byers Date: Mon, 24 Feb 2020 11:56:38 +0000 Subject: [PATCH 042/196] Revert "Convert all links to govuk frontend" --- app/assets/error_pages/5xx.html | 2 +- app/assets/javascripts/templateFolderForm.js | 2 +- app/assets/stylesheets/_grids.scss | 16 +++++ app/assets/stylesheets/app.scss | 6 ++ app/assets/stylesheets/components/banner.scss | 29 +++++--- .../stylesheets/components/big-number.scss | 1 + .../stylesheets/components/browse-list.scss | 17 ++++- .../stylesheets/components/file-upload.scss | 2 +- .../stylesheets/components/message.scss | 11 ++- .../stylesheets/components/navigation.scss | 72 ++++++++++--------- .../stylesheets/components/page-footer.scss | 17 +++++ app/assets/stylesheets/components/table.scss | 31 ++++++-- .../stylesheets/components/task-list.scss | 5 ++ .../stylesheets/components/tick-cross.scss | 22 ++++-- .../vendor/previous-next-navigation.scss | 4 ++ app/assets/stylesheets/globals.scss | 38 +++++++--- .../govuk-frontend/extensions.scss | 27 ------- app/assets/stylesheets/local/_typography.scss | 62 ---------------- app/assets/stylesheets/main.scss | 1 - .../stylesheets/views/notification.scss | 8 ++- app/main/validators.py | 3 +- app/navigation.py | 6 +- app/templates/components/big-number.html | 4 +- app/templates/components/browse-list.html | 2 +- app/templates/components/file-upload.html | 2 +- app/templates/components/folder-path.html | 12 ++-- app/templates/components/page-footer.html | 4 +- app/templates/components/pill.html | 2 +- .../components/previous-next-navigation.html | 4 +- app/templates/components/show-more.html | 2 +- app/templates/components/status-box.html | 2 +- app/templates/components/sub-navigation.html | 2 +- app/templates/components/table.html | 9 ++- app/templates/components/task-list.html | 2 +- app/templates/components/textbox.html | 2 +- app/templates/error/401.html | 2 +- app/templates/error/404.html | 2 +- app/templates/error/410.html | 2 +- app/templates/error/413.html | 2 +- app/templates/error/500.html | 4 +- app/templates/main_nav.html | 22 +++--- app/templates/org_nav.html | 8 +-- app/templates/org_template.html | 6 +- .../check/not-allowed-to-send-to.html | 2 +- .../partials/check/too-many-messages.html | 2 +- .../trying-to-send-letters-in-trial-mode.html | 2 +- .../partials/jobs/notifications.html | 6 +- .../partials/notifications/status.html | 10 ++- .../templates/guidance-character-count.html | 2 +- .../partials/templates/guidance-postage.html | 2 +- .../templates/guidance-send-a-document.html | 2 +- app/templates/partials/tour.html | 2 +- .../views/activity/notifications.html | 2 +- .../views/agreement/agreement-public.html | 2 +- .../agreement/service-agreement-choose.html | 2 +- .../agreement/service-agreement-signed.html | 2 +- .../views/agreement/service-agreement.html | 2 +- .../callbacks/delivery-status-callback.html | 2 +- .../received-text-messages-callback.html | 2 +- app/templates/views/api/index.html | 10 +-- app/templates/views/api/keys.html | 2 +- app/templates/views/api/whitelist.html | 6 +- app/templates/views/check/column-errors.html | 6 +- app/templates/views/check/ok.html | 4 +- app/templates/views/check/row-errors.html | 4 +- app/templates/views/choose-account.html | 6 +- .../views/conversations/conversation.html | 2 +- .../views/dashboard/_inbox_messages.html | 4 +- app/templates/views/dashboard/_jobs.html | 4 +- app/templates/views/dashboard/_upcoming.html | 2 +- .../dashboard/all-template-statistics.html | 2 +- .../views/dashboard/template-statistics.html | 2 +- .../views/dashboard/write-first-messages.html | 2 +- app/templates/views/documentation.html | 4 +- .../views/edit-user-permissions.html | 10 +-- .../views/email-branding/select-branding.html | 2 +- app/templates/views/email-link-invalid.html | 2 +- app/templates/views/features.html | 20 +++--- app/templates/views/features/emails.html | 14 ++-- app/templates/views/features/letters.html | 10 +-- .../views/features/text-messages.html | 10 +-- .../find-services/find-services-by-name.html | 2 +- .../views/find-users/find-users-by-email.html | 2 +- .../views/find-users/user-information.html | 6 +- app/templates/views/get-started.html | 18 ++--- .../guidance/branding-and-customisation.html | 10 +-- .../guidance/create-and-send-messages.html | 2 +- .../guidance/edit-and-format-messages.html | 10 +-- app/templates/views/guidance/index.html | 14 ++-- .../views/guidance/send-files-by-email.html | 4 +- .../views/guidance/upload-a-letter.html | 4 +- app/templates/views/inbound-sms-admin.html | 14 ++-- app/templates/views/integration-testing.html | 2 +- app/templates/views/jobs/job.html | 2 +- .../select-letter-branding.html | 2 +- app/templates/views/manage-users.html | 4 +- app/templates/views/message-status.html | 4 +- app/templates/views/notifications.html | 2 +- app/templates/views/notifications/check.html | 2 +- .../views/notifications/notification.html | 10 +-- .../views/organisations/add-organisation.html | 4 +- app/templates/views/organisations/index.html | 6 +- .../organisations/organisation/index.html | 2 +- .../organisation/trial-mode-services.html | 2 +- .../organisation/users/index.html | 2 +- .../views/platform-admin/_base_template.html | 2 +- .../views/platform-admin/reports.html | 8 +-- .../views/platform-admin/services.html | 2 +- app/templates/views/pricing/how-to-pay.html | 4 +- app/templates/views/pricing/index.html | 6 +- app/templates/views/privacy.html | 10 +-- app/templates/views/providers/providers.html | 2 +- app/templates/views/roadmap.html | 2 +- app/templates/views/security.html | 12 ++-- app/templates/views/send-test.html | 4 +- app/templates/views/send.html | 2 +- app/templates/views/service-settings.html | 12 ++-- .../email-reply-to/_verify-updates.html | 2 +- .../service-settings/email_reply_to.html | 2 +- .../letter-contact-details.html | 4 +- .../preview-letter-branding.html | 2 +- .../service-settings/request-to-go-live.html | 2 +- .../views/service-settings/set-auth-type.html | 4 +- .../service-settings/set-inbound-sms.html | 6 +- .../set-international-sms.html | 2 +- .../views/service-settings/set-letter.html | 2 +- .../views/service-settings/set-sms.html | 2 +- .../views/service-settings/sms-senders.html | 2 +- app/templates/views/signedout.html | 12 ++-- app/templates/views/signin.html | 2 +- app/templates/views/styleguide.html | 8 +-- app/templates/views/support/bat-phone.html | 6 +- app/templates/views/support/index.html | 2 +- .../views/support/report-problem.html | 2 +- app/templates/views/templates/_template.html | 16 ++--- .../views/templates/_template_list.html | 6 +- .../views/templates/action_blocked.html | 2 +- .../views/templates/choose-reply.html | 6 +- app/templates/views/templates/choose.html | 2 +- .../views/templates/choose_history.html | 2 +- app/templates/views/templates/copy.html | 10 +-- .../views/templates/set-template-sender.html | 2 +- app/templates/views/templates/template.html | 6 +- app/templates/views/terms-of-use.html | 10 +-- app/templates/views/trial-mode.html | 4 +- app/templates/views/uploads/choose-file.html | 2 +- app/templates/views/uploads/preview.html | 2 +- app/templates/views/usage.html | 2 +- app/templates/views/using-notify.html | 14 ++-- app/templates/withnav_template.html | 6 +- app/templates/withoutnav_template.html | 2 +- app/utils.py | 30 ++------ .../views/organisations/test_organisation.py | 2 +- tests/app/main/views/test_agreement.py | 8 +-- tests/app/main/views/test_find_services.py | 4 +- tests/app/main/views/test_manage_users.py | 2 +- tests/app/main/views/test_user_profile.py | 2 +- tests/javascripts/cookieMessage.test.js | 4 +- tests/javascripts/cookieSettings.test.js | 2 +- tests/javascripts/liveSearch.test.js | 2 +- .../stick-to-window-when-scrolling.test.js | 2 +- tests/javascripts/support/helpers/html.js | 2 +- tests/javascripts/updateContent.test.js | 6 +- 163 files changed, 548 insertions(+), 521 deletions(-) delete mode 100644 app/assets/stylesheets/local/_typography.scss diff --git a/app/assets/error_pages/5xx.html b/app/assets/error_pages/5xx.html index 8fd9ef8bd..1f802e608 100644 --- a/app/assets/error_pages/5xx.html +++ b/app/assets/error_pages/5xx.html @@ -75,7 +75,7 @@ Try again later.

                - You can check our system status page to see if there are any known issues.
                To report a problem, email notify-support@digital.cabinet-office.gov.uk + You can check our system status page to see if there are any known issues.
                To report a problem, email notify-support@digital.cabinet-office.gov.uk diff --git a/app/assets/javascripts/templateFolderForm.js b/app/assets/javascripts/templateFolderForm.js index 22a7f1a68..f81a9eabe 100644 --- a/app/assets/javascripts/templateFolderForm.js +++ b/app/assets/javascripts/templateFolderForm.js @@ -114,7 +114,7 @@ this.makeButton = (text, opts) => { let $btn = $('') .html(text) - .addClass('govuk-link govuk-link--no-visited-state js-cancel') + .addClass('js-cancel') // isn't set if cancelSelector is undefined .data('target', opts.cancelSelector || undefined) .attr('tabindex', '0') diff --git a/app/assets/stylesheets/_grids.scss b/app/assets/stylesheets/_grids.scss index 024091fb3..85551da03 100644 --- a/app/assets/stylesheets/_grids.scss +++ b/app/assets/stylesheets/_grids.scss @@ -120,3 +120,19 @@ .align-with-big-number-hint { margin-top: $gutter / 0.6; } + +.global-cookie-message { + p { + @extend %site-width-container; + } +} + +.footer-nav { + @include copy-16; + margin-bottom: $gutter-two-thirds; + + a { + display: inline-block; + margin-right: $gutter-half; + } +} diff --git a/app/assets/stylesheets/app.scss b/app/assets/stylesheets/app.scss index f3c76bd47..c195d3eed 100644 --- a/app/assets/stylesheets/app.scss +++ b/app/assets/stylesheets/app.scss @@ -1,4 +1,10 @@ // Extra CSS overlaying elements +a { + &:visited { + color: $link-colour; + } +} + .form-control-1-1 { width: 100%; } diff --git a/app/assets/stylesheets/components/banner.scss b/app/assets/stylesheets/components/banner.scss index 9eed69c66..dac7613d4 100644 --- a/app/assets/stylesheets/components/banner.scss +++ b/app/assets/stylesheets/components/banner.scss @@ -55,6 +55,19 @@ outline: 3px solid $yellow; } + a { + + &:link, + &:visited { + color: $error-colour; + } + + &:hover { + color: $mellow-red; + } + + } + .list { margin-bottom: 0; } @@ -95,7 +108,7 @@ a { - font-weight: bold; + @include bold-19; display: block; padding: 0 ; margin: 0 0 $gutter 0; @@ -105,18 +118,18 @@ color: $white; } - &:focus, + &:hover, &:active { - color: $govuk-focus-text-colour; - outline: 10px solid $yellow; - } - - &:hover { - color: $white; background-color: $link-hover-colour; outline: 10px solid $link-hover-colour; } + &:active, + &:focus { + background-color: $yellow; + outline: 10px solid $yellow; + } + } .greyed-out-step { diff --git a/app/assets/stylesheets/components/big-number.scss b/app/assets/stylesheets/components/big-number.scss index 035c99e70..7e4fa81a8 100644 --- a/app/assets/stylesheets/components/big-number.scss +++ b/app/assets/stylesheets/components/big-number.scss @@ -130,6 +130,7 @@ &:active, &:focus { color: $black; + border-bottom: 1px solid $black; } } diff --git a/app/assets/stylesheets/components/browse-list.scss b/app/assets/stylesheets/components/browse-list.scss index ec7008737..bc63bd9a6 100644 --- a/app/assets/stylesheets/components/browse-list.scss +++ b/app/assets/stylesheets/components/browse-list.scss @@ -17,7 +17,22 @@ } &-link { - @include govuk-font(24, $weight: bold); + @include bold-24; + + &-destructive { + @include bold-24; + color: $error-colour; + + &:visited, + &:link { + @include bold-24; + color: $error-colour; + } + + &:hover { + color: $mellow-red; + } + } } &-hint { diff --git a/app/assets/stylesheets/components/file-upload.scss b/app/assets/stylesheets/components/file-upload.scss index 8ff2e92a9..35adb510e 100644 --- a/app/assets/stylesheets/components/file-upload.scss +++ b/app/assets/stylesheets/components/file-upload.scss @@ -43,7 +43,7 @@ line-height: 35px; a { - font-weight: bold; + @include bold-19; } } diff --git a/app/assets/stylesheets/components/message.scss b/app/assets/stylesheets/components/message.scss index 4b6b889be..e6773357b 100644 --- a/app/assets/stylesheets/components/message.scss +++ b/app/assets/stylesheets/components/message.scss @@ -34,8 +34,15 @@ margin-bottom: -$gutter; padding-bottom: $gutter; - &:hover .message-name-separator:before { - border-color: $link-hover-colour; + &:hover { + color: $link-hover-colour; + + .message-name-separator { + &:before { + border-color: $link-hover-colour; + } + } + } &:focus { diff --git a/app/assets/stylesheets/components/navigation.scss b/app/assets/stylesheets/components/navigation.scss index 5b71a68dd..08b6476d4 100644 --- a/app/assets/stylesheets/components/navigation.scss +++ b/app/assets/stylesheets/components/navigation.scss @@ -1,74 +1,64 @@ .navigation { - @include govuk-font($size: 19); padding: 0 $gutter 0 0; $padding-top: 14px; $padding-bottom: 11px; - &-service-name, - &-organisation-link { - display: inline-block; - overflow: hidden; - // aligning to the baseline with overflow: hidden adds to the parent's height - // aligning to the top doesn't - // see: https://stackoverflow.com/questions/23529369/why-does-x-overflowhidden-cause-extra-space-below#answer-51088033 - vertical-align: top; - white-space: nowrap; - text-overflow: ellipsis; - } - - &-service-switch, - &-service-back-to, - &-organisation-link { - - &:link, - &:visited { - text-decoration: none; - } - - &:hover { - text-decoration: underline; - } - - } - &-service { - @include govuk-font($size: 19); border-bottom: 1px solid $border-colour; margin: 0 0 10px; position: relative; + font-size: 0; &-name { - + @include bold-19; padding: $padding-top 0 $padding-bottom 0; + display: inline-block; max-width: 50%; - + overflow: hidden; + white-space: nowrap; + text-overflow: ellipsis; } &-switch { + @include core-19; + text-decoration: none; text-align: right; position: absolute; top: 0; right: 0; padding: $padding-top 0 $padding-bottom $gutter-half; + &:hover { + color: $link-hover-colour; + text-decoration: underline; + } + &:focus { outline: none; border-bottom: 1px solid $yellow; border-left: 10px solid $yellow; border-right: 3px solid $yellow; right: -3px; + color: $text-colour; } } &-back-to { + @include core-19; padding: $padding-top $gutter-half $padding-bottom 0; display: inline-block; + text-decoration: none; + + &:hover { + text-decoration: underline; + color: $link-hover-colour; + } } @@ -76,7 +66,14 @@ &-organisation-link { + @include core-19; + display: inline-block; max-width: 25%; + white-space: nowrap; + overflow: hidden; + text-overflow: ellipsis; + font-weight: normal; + text-decoration: none; padding: $padding-top 20px $padding-bottom 0; margin-right: 7px; box-sizing: border-box; @@ -100,8 +97,13 @@ border-color: $secondary-text-colour; } - // hack to make the focus style fit in the navigation bar + &:hover { + color: $link-hover-colour; + text-decoration: underline; + } + &:focus { + color: $text-colour; outline: none; box-shadow: 0 1px 0 0 $focus-colour, -3px 0 0 0 $focus-colour, -3px 1px 0 0 $focus-colour; } @@ -109,6 +111,7 @@ } li { + @include core-19; margin: 0; list-style-type: none; } @@ -126,9 +129,14 @@ } &:hover { + color: $link-hover-colour; text-decoration: underline; } + &:focus { + color: $text-colour; + } + &.selected { @include bold-19; position: relative; diff --git a/app/assets/stylesheets/components/page-footer.scss b/app/assets/stylesheets/components/page-footer.scss index 56611d425..cdf95ff65 100644 --- a/app/assets/stylesheets/components/page-footer.scss +++ b/app/assets/stylesheets/components/page-footer.scss @@ -8,9 +8,26 @@ line-height: 40px; padding: 1px 0 0 15px; + a { + + &:visited, + &:link { + color: $error-colour; + display: inline-block; + vertical-align: center; + } + + &:hover, + &:active { + color: $mellow-red; + } + + } + } &-delete-link-without-button { + @include core-19; padding: 0; display: inline-block; } diff --git a/app/assets/stylesheets/components/table.scss b/app/assets/stylesheets/components/table.scss index 3b4a4a49b..61dba8ed5 100644 --- a/app/assets/stylesheets/components/table.scss +++ b/app/assets/stylesheets/components/table.scss @@ -212,6 +212,15 @@ color: $error-colour; font-weight: bold; + a { + + &:link, + &:visited { + color: $error-colour; + } + + } + .status-hint { display: block; font-weight: normal; @@ -347,12 +356,22 @@ background: transparent; } - &:active:before, - &:focus:before { - border-color: $yellow; - border-style: solid; - border-width: 15px 3px 15px 15px; - right: -3px; + &:hover { + color: $link-hover-colour; + } + + &:active, + &:focus { + + color: $black; + + &:before { + border-color: $yellow; + border-style: solid; + border-width: 15px 3px 15px 15px; + right: -3px; + } + } } diff --git a/app/assets/stylesheets/components/task-list.scss b/app/assets/stylesheets/components/task-list.scss index 3330fd32d..ae751d7ea 100644 --- a/app/assets/stylesheets/components/task-list.scss +++ b/app/assets/stylesheets/components/task-list.scss @@ -31,8 +31,13 @@ $indicator-colour: $black; padding-right: 20%; position: relative; + &:hover { + color: $link-hover-colour; + } + &:focus { outline: none; + color: $black; box-shadow: -3px 0 0 0 $focus-colour, 3px 0 0 0 $focus-colour; border-color: transparent; top: -1px; diff --git a/app/assets/stylesheets/components/tick-cross.scss b/app/assets/stylesheets/components/tick-cross.scss index 53bf6588c..4136dab7e 100644 --- a/app/assets/stylesheets/components/tick-cross.scss +++ b/app/assets/stylesheets/components/tick-cross.scss @@ -61,12 +61,22 @@ background: transparent; } - &:active:before, - &:focus:before { - border-color: $yellow; - border-style: solid; - border-width: 15px 3px 15px 15px; - right: -3px; + &:hover { + color: $link-hover-colour; + } + + &:active, + &:focus { + + color: $black; + + &:before { + border-color: $yellow; + border-style: solid; + border-width: 15px 3px 15px 15px; + right: -3px; + } + } } diff --git a/app/assets/stylesheets/components/vendor/previous-next-navigation.scss b/app/assets/stylesheets/components/vendor/previous-next-navigation.scss index 8fc2213a0..0e060f12c 100644 --- a/app/assets/stylesheets/components/vendor/previous-next-navigation.scss +++ b/app/assets/stylesheets/components/vendor/previous-next-navigation.scss @@ -54,6 +54,10 @@ $is-ie: false !default; padding: $gutter-half; text-decoration: none; + &:visited { + color: $link-colour; + } + &:hover, &:active { background-color: $canvas-colour; diff --git a/app/assets/stylesheets/globals.scss b/app/assets/stylesheets/globals.scss index b24b39ea4..9da8fb427 100644 --- a/app/assets/stylesheets/globals.scss +++ b/app/assets/stylesheets/globals.scss @@ -5,16 +5,6 @@ width: device-width; } -// To be removed when all text uses the GOV.UK Frontend New Transport font styles. -// At present, some text gets these styles due to being in a GOV.UK Frontend component -// or a link. -// This ensures all text will have these styles applied, until it can be moved to use -// the GOV.UK Frontend font styles. -body { - -webkit-font-smoothing: antialiased; - -moz-osx-font-smoothing: grayscale; -} - b, strong { font-weight: 600; @@ -51,6 +41,34 @@ input[type="search"]::-webkit-search-decoration { -webkit-appearance: none; } +// To be removed when all links follow the GOV.UK Frontend conventions: +// https://design-system.service.gov.uk/styles/typography/#links +a { + /* Give a strong clear visual idea as to what is currently in focus */ + -webkit-tap-highlight-color: rgba(0, 0, 0, 0.3); + + &:link { + color: $link-colour; + } + + &:visited { + color: $link-visited-colour; + } + + &:hover { + color: $link-hover-colour; + } + + &:active { + color: $link-active-colour; + } + + &:focus { + background-color: $focus-colour; + outline: 3px solid $focus-colour; + } +} + // Each selector, and then the whole block when only one remains, to be removed when the // element comes from the corresponding GOV.UK Frontend component: // - https://design-system.service.gov.uk/components/text-input/ diff --git a/app/assets/stylesheets/govuk-frontend/extensions.scss b/app/assets/stylesheets/govuk-frontend/extensions.scss index dfb5d7ae7..0d4b693fa 100644 --- a/app/assets/stylesheets/govuk-frontend/extensions.scss +++ b/app/assets/stylesheets/govuk-frontend/extensions.scss @@ -8,30 +8,3 @@ } } -// Extends govuk-link to create a class of link that causes a destructive action -// Based on styles of link in: -// https://github.com/alphagov/govuk-frontend/blob/v2.13.0/src/helpers/_links.scss -// -// Note: all destructive actions must have a confirmation step these links navigate to -@mixin govuk-link-style-destructive-no-visited-state { - &:link, - &:visited { - color: $govuk-error-colour; - } - - &:hover { - color: govuk-tint($govuk-error-colour, 25%); - } - - // When focussed, the text colour needs to be darker to ensure that colour - // contrast is still acceptable against the focus colour - // Activated links are usually focused so this applies to them as well - &:active, - &:focus { - color: $govuk-focus-text-colour; - } -} - -.govuk-link--destructive { - @include govuk-link-style-destructive-no-visited-state; -} diff --git a/app/assets/stylesheets/local/_typography.scss b/app/assets/stylesheets/local/_typography.scss deleted file mode 100644 index 401562515..000000000 --- a/app/assets/stylesheets/local/_typography.scss +++ /dev/null @@ -1,62 +0,0 @@ -@import 'settings/all'; -@import 'helpers/all'; - -@mixin destructive-link-style-default { - &:link { - color: $govuk-error-colour; - } - - &:visited { - color: $govuk-link-visited-colour; - } - - &:hover { - color: govuk-tint( $govuk-error-colour, 25% ); - } - - &:active { - color: $govuk-link-active-colour; - } - - // When focussed, the text colour needs to be darker to ensure that colour - // contrast is still acceptable - &:focus { - color: $govuk-focus-text-colour; - } -} - -@mixin destructive-link-style-no-visited-state { - &:link { - color: $govuk-error-colour; - } - - &:visited { - color: $govuk-error-colour; - } - - &:hover { - color: govuk-tint( $govuk-error-colour, 25% ); - } - - &:active { - color: $govuk-link-active-colour; - } - - // When focussed, the text colour needs to be darker to ensure that colour - // contrast is still acceptable - &:focus { - color: $govuk-focus-text-colour; - } -} - -// mimics styles for govuk-link: -// https://github.com/alphagov/govuk-frontend/blob/063cd8e2470b62b824c6e50ca66342ac7a95d2d8/package/core/_links.scss#L7 -.destructive-link { - @include govuk-link-common; - @include destructive-link-style-default; - @include govuk-link-print-friendly; -} - -.destructive-link--no-visited-state { - @include destructive-link-style-no-visited-state; -} diff --git a/app/assets/stylesheets/main.scss b/app/assets/stylesheets/main.scss index bff09e95e..cec02421b 100644 --- a/app/assets/stylesheets/main.scss +++ b/app/assets/stylesheets/main.scss @@ -36,7 +36,6 @@ $path: '/static/images/'; @import './govuk-frontend/all'; // Specific to this application -@import 'local/typography'; @import 'grids'; @import 'components/cookie-message'; @import 'components/site-footer'; diff --git a/app/assets/stylesheets/views/notification.scss b/app/assets/stylesheets/views/notification.scss index 0961dc815..e26268f56 100644 --- a/app/assets/stylesheets/views/notification.scss +++ b/app/assets/stylesheets/views/notification.scss @@ -6,14 +6,18 @@ &.error { - color: $govuk-error-colour; + color: $error-colour; font-weight: bold; + a { + color: $error-colour; + } + } &-cancelled { @include bold-19; - color: $govuk-error-colour; + color: $error-colour; } } diff --git a/app/main/validators.py b/app/main/validators.py index 7ef28cdb9..63f36d5f5 100644 --- a/app/main/validators.py +++ b/app/main/validators.py @@ -46,8 +46,7 @@ class ValidGovEmail: message = ( 'Enter a government email address.' ' If you think you should have access' - ' contact us' - ).format(url_for('main.support')) + ' contact us').format(url_for('main.support')) if not is_gov_user(field.data.lower()): raise ValidationError(message) diff --git a/app/navigation.py b/app/navigation.py index 3f94bbc9f..dd6aeecc4 100644 --- a/app/navigation.py +++ b/app/navigation.py @@ -7,7 +7,7 @@ class Navigation: mapping = {} exclude = {} - selected_class = "selected" + selected_attribute = "class=selected" def __init__(self): self.mapping = { @@ -32,7 +32,7 @@ class Navigation: def is_selected(self, navigation_item): if request.endpoint in self.mapping[navigation_item]: - return " " + self.selected_class + return self.selected_attribute return '' @staticmethod @@ -42,6 +42,8 @@ class Navigation: class HeaderNavigation(Navigation): + selected_attribute = "class=active" + mapping = { 'support': { 'bat_phone', diff --git a/app/templates/components/big-number.html b/app/templates/components/big-number.html index 8b5176a04..8ca33b3fb 100644 --- a/app/templates/components/big-number.html +++ b/app/templates/components/big-number.html @@ -1,6 +1,6 @@ {% macro big_number(number, label, link=None, currency='', smaller=False, smallest=False) %} {% if link %} - + {% endif %}

                @@ -42,7 +42,7 @@
                {% if failures %} {% if failure_link %} - + {{ "{:,}".format(failures) }} failed – {{ failure_percentage }}% diff --git a/app/templates/components/browse-list.html b/app/templates/components/browse-list.html index b75d09218..d59e9ae37 100644 --- a/app/templates/components/browse-list.html +++ b/app/templates/components/browse-list.html @@ -5,7 +5,7 @@ {% for item in items %} {% if item.title and item.link %}
              • - {{ item.title }} + {{ item.title }} {% if item.hint %}
                {{ item.hint }} diff --git a/app/templates/components/file-upload.html b/app/templates/components/file-upload.html index 1908f1e48..647629248 100644 --- a/app/templates/components/file-upload.html +++ b/app/templates/components/file-upload.html @@ -32,7 +32,7 @@ {% if alternate_link and alternate_link_text %} - or {{ alternate_link_text }} + or {{ alternate_link_text }} {% endif %} diff --git a/app/templates/components/folder-path.html b/app/templates/components/folder-path.html index 0d1900745..5400e91c2 100644 --- a/app/templates/components/folder-path.html +++ b/app/templates/components/folder-path.html @@ -17,12 +17,12 @@ {% else %} {% if folder.id %} {% if current_user.has_template_folder_permission(folder) %} - {{ folder.name }} + {{ folder.name }} {% else %} {{ folder.name }} {% endif %} {% else %} - Templates + Templates {% endif %} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% endif %} @@ -40,7 +40,7 @@ {% if folder_path %}

                {% if folder_path|length == 1 %} - Services + Services {{ folder_path_separator() }} {% endif %} {% for folder in folder_path %} @@ -51,15 +51,15 @@ {% else %} {% if folder.id %} {% if current_user.has_template_folder_permission(folder) %} - {{ folder.name }} + {{ folder.name }} {% else %} {{ folder.name }} {% endif %} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% elif folder.parent_id == None %} - {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} + {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% else %} - {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} + {{ from_service.name }} {% if not loop.last %}{{ folder_path_separator() }}{% endif %} {% endif %} {% endif %} {% endfor %} diff --git a/app/templates/components/page-footer.html b/app/templates/components/page-footer.html index 4d06641d5..fb9f478be 100644 --- a/app/templates/components/page-footer.html +++ b/app/templates/components/page-footer.html @@ -26,11 +26,11 @@ {% endif %} {% if delete_link %} - {{ delete_link_text }} + {{ delete_link_text }} {% endif %} {% if secondary_link and secondary_link_text %} - {{ secondary_link_text }} + {{ secondary_link_text }} {% endif %}

                {% endmacro %} diff --git a/app/templates/components/pill.html b/app/templates/components/pill.html index d6a416522..bcbb5408b 100644 --- a/app/templates/components/pill.html +++ b/app/templates/components/pill.html @@ -13,7 +13,7 @@
                {% else %}
              • - + {% endif %} {% if show_count %} {{ big_number(count, **big_number_args) }} diff --git a/app/templates/components/previous-next-navigation.html b/app/templates/components/previous-next-navigation.html index 483dc3f18..b73846c6a 100644 --- a/app/templates/components/previous-next-navigation.html +++ b/app/templates/components/previous-next-navigation.html @@ -4,7 +4,7 @@
              • diff --git a/app/templates/error/401.html b/app/templates/error/401.html index be999a765..74747f50e 100644 --- a/app/templates/error/401.html +++ b/app/templates/error/401.html @@ -4,6 +4,6 @@

                You’re not authorised to see this page

                -

                Sign in to GOV.UK Notify and try again.

                +

                Sign in to GOV.UK Notify and try again.

                {% endblock %} diff --git a/app/templates/error/404.html b/app/templates/error/404.html index 170b4acc0..acb43af52 100644 --- a/app/templates/error/404.html +++ b/app/templates/error/404.html @@ -13,7 +13,7 @@ If you pasted the web address, check you copied the entire address.

                - If the web address is correct or you selected a link or button, contact us. + If the web address is correct or you selected a link or button, contact us.

                diff --git a/app/templates/error/410.html b/app/templates/error/410.html index 170b4acc0..acb43af52 100644 --- a/app/templates/error/410.html +++ b/app/templates/error/410.html @@ -13,7 +13,7 @@ If you pasted the web address, check you copied the entire address.

                - If the web address is correct or you selected a link or button, contact us. + If the web address is correct or you selected a link or button, contact us.

                diff --git a/app/templates/error/413.html b/app/templates/error/413.html index 28304e083..4dfddc603 100644 --- a/app/templates/error/413.html +++ b/app/templates/error/413.html @@ -12,7 +12,7 @@ Files must be smaller than 5 MB.

                - Go back and try again. + Go back and try again.

                diff --git a/app/templates/error/500.html b/app/templates/error/500.html index 0d352163b..0d3109996 100644 --- a/app/templates/error/500.html +++ b/app/templates/error/500.html @@ -10,10 +10,10 @@ Try again later.

                - You can check our system status page to see if there are any known issues. + You can check our system status page to see if there are any known issues.

                - To report a problem, email notify-support@digital.cabinet-office.gov.uk + To report a problem, email notify-support@digital.cabinet-office.gov.uk

                diff --git a/app/templates/main_nav.html b/app/templates/main_nav.html index e953e1332..92c05dd6c 100644 --- a/app/templates/main_nav.html +++ b/app/templates/main_nav.html @@ -5,32 +5,32 @@ diff --git a/app/templates/org_nav.html b/app/templates/org_nav.html index 7d7156ab4..a9f518e11 100644 --- a/app/templates/org_nav.html +++ b/app/templates/org_nav.html @@ -1,10 +1,10 @@ diff --git a/app/templates/org_template.html b/app/templates/org_template.html index be9994c86..32bbdab14 100644 --- a/app/templates/org_template.html +++ b/app/templates/org_template.html @@ -8,12 +8,12 @@
                - Back to top + Back to top
                diff --git a/app/templates/views/choose-account.html b/app/templates/views/choose-account.html index 144696473..bfde30431 100644 --- a/app/templates/views/choose-account.html +++ b/app/templates/views/choose-account.html @@ -21,7 +21,7 @@ {% endif %} {% for org in organisations %}
              • - {{ org.name }} + {{ org.name }}

                {{ org.count_of_live_services }} live service{% if org.count_of_live_services != 1 %}s{% endif %} @@ -30,7 +30,7 @@ {% endfor %} {% for service in services %}

              • - {{ service.name }} + {{ service.name }}
              • {% endfor %} {% if show_heading %} @@ -64,7 +64,7 @@

                A developer should be able to set up the API client and start sending test messages in around 30 minutes. A full integration can take a few days, depending on the other systems you’re using.

                Integrate directly with the API

                If you cannot use the client libraries, you can integrate directly with the API instead.

                -

                Read the REST API documentation (this link opens in a new tab).

                +

                Read the REST API documentation (this link opens in a new tab).

                {% endblock %} diff --git a/app/templates/views/edit-user-permissions.html b/app/templates/views/edit-user-permissions.html index e7d8fd378..9847bf65b 100644 --- a/app/templates/views/edit-user-permissions.html +++ b/app/templates/views/edit-user-permissions.html @@ -25,17 +25,11 @@ ) }}

                - {{ user.email_address }}  - - Change email address - + {{ user.email_address }} Change

                {% if mobile_number %}

                - {{ mobile_number }}  - - Change mobile number - + {{ mobile_number }} Change

                {% endif %}
                diff --git a/app/templates/views/email-branding/select-branding.html b/app/templates/views/email-branding/select-branding.html index 267e04143..9ffdcc341 100644 --- a/app/templates/views/email-branding/select-branding.html +++ b/app/templates/views/email-branding/select-branding.html @@ -15,7 +15,7 @@ {% for brand in email_brandings %} diff --git a/app/templates/views/features.html b/app/templates/views/features.html index 4c41e46cf..a0cdf2be3 100644 --- a/app/templates/views/features.html +++ b/app/templates/views/features.html @@ -12,13 +12,13 @@

                If you work for central government, a local authority or the NHS, you can use GOV.UK Notify to keep your users updated.

                Notify makes it easy to create, customise and send:

                You do not need any technical knowledge to use Notify.

                {% if not current_user.is_authenticated %} -

                Create an account for free and try it yourself.

                +

                Create an account for free and try it yourself.

                {% endif %}

                Reusable message templates

                @@ -27,18 +27,18 @@

                Personalised content

                Notify makes it easy to send personalised messages from a single template.

                -

                See how to personalise your content.

                +

                See how to personalise your content.

                Bulk sending

                To send a batch of messages at once, upload a list of contact details to Notify. If you’re sending emails and text messages, you can also schedule the date and time you want them to be sent.

                API integration

                You can integrate the Notify API with your web application or back-office system to send messages automatically.

                -

                Read our API documentation for more information.

                +

                Read our API documentation for more information.

                Reporting

                Notify’s real-time dashboard lets you see the number of messages sent. You can also check the current status of any message to see when it was delivered.

                -

                Read more about the delivery status of your messages.

                +

                Read more about the delivery status of your messages.

                Permissions

                Control which members of your team can see, create, edit and send messages.

                @@ -58,7 +58,7 @@

                We send messages through several different providers. If one provider fails, Notify switches to another so that your messages are not affected.

                -

                Visit GOV.UK Performance to see how Notify is performing.

                +

                Visit GOV.UK Performance to see how Notify is performing.

                Security

                Notify protects and manages data to meet the needs of government services.

                @@ -68,10 +68,10 @@

                Two-factor authentication

                Notify uses two-factor authentication (2FA) to keep your account secure. When you sign in, we’ll send a unique one-time code to your phone and ask you to enter it before we let you use your account.

                -

                Read more about security. +

                Read more about security.

                Support

                Notify provides 24-hour online support. If you have an emergency outside office hours, we’ll reply within 30 minutes.

                -

                Find out more about support.

                +

                Find out more about support.

                {% endblock %} diff --git a/app/templates/views/features/emails.html b/app/templates/views/features/emails.html index 63d283ce8..f9ddc5693 100644 --- a/app/templates/views/features/emails.html +++ b/app/templates/views/features/emails.html @@ -10,7 +10,7 @@

                Emails

                Send an unlimited number of emails for free with GOV.UK Notify.

                {% if not current_user.is_authenticated %} -

                Create an account and try Notify for yourself.

                +

                Create an account and try Notify for yourself.

                {% endif %}

                Features

                @@ -20,11 +20,11 @@
              • personalise the content of your emails
              • send and schedule bulk messages
              -

              You can also integrate with our API to send emails automatically.

              +

              You can also integrate with our API to send emails automatically.

              Email branding

              Add your organisation’s logo and brand colour to email templates.

              -

              See how to change your email branding.

              +

              See how to change your email branding.

              Send files by email

              Notify offers a safe and reliable way to send files by email.

              @@ -35,16 +35,16 @@
            22. email attachments are often marked as spam
            23. -

              Contact us if you want to send files by email.

              -

              Read our API documentation for more information.

              +

              Contact us if you want to send files by email.

              +

              Read our API documentation for more information.

              Add a reply-to address

              Notify lets you choose the email address that users reply to.

              Emails with a reply-to address seem more trustworthy and are less likely to be labelled as spam.

              -

              See how to add a reply-to address.

              +

              See how to add a reply-to address.

              Pricing

              It’s free to send emails through Notify.

              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/features/letters.html b/app/templates/views/features/letters.html index 94a53fd91..c779951b3 100644 --- a/app/templates/views/features/letters.html +++ b/app/templates/views/features/letters.html @@ -10,7 +10,7 @@

              Letters

              GOV.UK Notify will print, pack and post your letters for you.

              {% if not current_user.is_authenticated %} -

              Create an account and try Notify for yourself.

              +

              Create an account and try Notify for yourself.

              {% endif %}

              Features

              @@ -20,7 +20,7 @@
            24. personalise the content of your letter
            25. send bulk mail
            26. -

              You can also integrate with our API to send letters automatically.

              +

              You can also integrate with our API to send letters automatically.

              Choose your postage

              Notify can send letters by first or second class post.

              @@ -29,11 +29,11 @@

              Branding

              Add your organisation’s logo to your letter templates.

              -

              See how to change your letter branding.

              +

              See how to change your letter branding.

              Upload your own letters

              You can create reusable letter templates in Notify, or upload and send your own letters with the Notify API.

              -

              Read our documentation.

              +

              Read our documentation.

              Pricing

              It costs between 30p and 76p (plus VAT) to send a letter. Prices include:

              @@ -44,6 +44,6 @@
            27. first or second class postage
            28. Letters can be up to 10 pages long (5 double-sided sheets of paper).

              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/features/text-messages.html b/app/templates/views/features/text-messages.html index 0fe4b3ed5..270e192f5 100644 --- a/app/templates/views/features/text-messages.html +++ b/app/templates/views/features/text-messages.html @@ -10,7 +10,7 @@

              Text messages

              Send thousands of free text messages to UK and international numbers with GOV.UK Notify.

              {% if not current_user.is_authenticated %} -

              Create an account and try Notify for yourself.

              +

              Create an account and try Notify for yourself.

              {% endif %}

              Features

              @@ -19,16 +19,16 @@
            29. create reusable text message templates
            30. personalise the content of your texts
            31. send and schedule bulk messages
            32. -

              You can also integrate with our API to send text messages automatically.

              +

              You can also integrate with our API to send text messages automatically.

              Receive text messages

              Let people send messages to your service or reply to your texts.

              You can see and reply to the messages you receive when you sign in to Notify. If you’re using our API, you can set up your own automated processes to manage replies.

              -

              Contact us to request a unique number for text message replies.

              +

              Contact us to request a unique number for text message replies.

              Show people who your texts are from

              When you send a text message with Notify, the sender name tells people who it's from.

              -

              See how to change the text message sender.

              +

              See how to change the text message sender.

              Pricing

              Each service you add has a free annual allowance. After that it costs 1.58 pence (plus VAT) to send a text to a UK number.

              @@ -36,6 +36,6 @@
              • 250,000 free text messages for central government services
              • 25,000 free text messages for other public sector services
              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/find-services/find-services-by-name.html b/app/templates/views/find-services/find-services-by-name.html index 2fbb8f402..04ef957bf 100644 --- a/app/templates/views/find-services/find-services-by-name.html +++ b/app/templates/views/find-services/find-services-by-name.html @@ -43,7 +43,7 @@
                {% for service in services_found %}
              • - {{ service.name }} + {{ service.name }}

              • {% endfor %} diff --git a/app/templates/views/find-users/find-users-by-email.html b/app/templates/views/find-users/find-users-by-email.html index 296977b9f..fc9380456 100644 --- a/app/templates/views/find-users/find-users-by-email.html +++ b/app/templates/views/find-users/find-users-by-email.html @@ -43,7 +43,7 @@
                  {% for user in users_found %}
                • - {{ user.email_address }} + {{ user.email_address }}

                  {{ user.name }}


                • diff --git a/app/templates/views/find-users/user-information.html b/app/templates/views/find-users/user-information.html index e45b948c5..aa8d699a2 100644 --- a/app/templates/views/find-users/user-information.html +++ b/app/templates/views/find-users/user-information.html @@ -19,7 +19,7 @@ @@ -35,7 +35,7 @@ @@ -62,7 +62,7 @@ {% endif %} {% if user.state == 'active' %} - + Archive user diff --git a/app/templates/views/get-started.html b/app/templates/views/get-started.html index 489791f17..2fc4390c1 100644 --- a/app/templates/views/get-started.html +++ b/app/templates/views/get-started.html @@ -14,7 +14,7 @@
                  1. Check if GOV.UK Notify is right for you

                    -

                    Read about our features, pricing and roadmap.

                    +

                    Read about our features, pricing and roadmap.

                    {{ govukDetails({ "summaryText": "Organisations that can use Notify", "html": ''' @@ -35,15 +35,15 @@
                  2. Create an account

                    {% if not current_user.is_authenticated %} -

                    Create an account for free and add your first Notify service. When you add a new service it will start in trial mode.

                    +

                    Create an account for free and add your first Notify service. When you add a new service it will start in trial mode.

                    {% else %} -

                    Create an account for free and add your first Notify service. When you add a new service, it will start in trial mode.

                    +

                    Create an account for free and add your first Notify service. When you add a new service, it will start in trial mode.

                    {% endif %}
                  3. Write some messages

                    -

                    Add message templates with examples of the content you plan to send. You can use our guidance to help you.

                    +

                    Add message templates with examples of the content you plan to send. You can use our guidance to help you.

                  4. @@ -52,15 +52,15 @@

                    Review your settings to add message branding, reply-to addresses and sender information.

                    Add team members and check their permissions.

                    {% else %} -

                    Review your settings to add message branding, reply-to addresses and sender information.

                    -

                    Add team members and check their permissions.

                    +

                    Review your settings to add message branding, reply-to addresses and sender information.

                    +

                    Add team members and check their permissions.

                    {% endif %}
                  5. Set up an API integration (optional)

                    You can use the Notify API to send messages automatically.

                    -

                    Our documentation explains how to integrate the API with a web application or back office system.

                    +

                    Our documentation explains how to integrate the API with a web application or back office system.

                  6. @@ -68,9 +68,9 @@ {% if not current_user.is_authenticated or not current_service %}

                    When you’re ready to send messages to people outside your team, go to the Settings page and select Request to go live. We’ll approve your request within one working day.

                    {% else %} -

                    You should request to go live when you’re ready to send messages to people outside your team. We’ll approve your request within one working day.

                    +

                    You should request to go live when you’re ready to send messages to people outside your team. We’ll approve your request within one working day.

                    {% endif %} -

                    Check how to pay if you’re planning to send letters or exceed the free text message allowance.

                    +

                    Check how to pay if you’re planning to send letters or exceed the free text message allowance.

                  diff --git a/app/templates/views/guidance/branding-and-customisation.html b/app/templates/views/guidance/branding-and-customisation.html index 0d017d65d..44d8c1072 100644 --- a/app/templates/views/guidance/branding-and-customisation.html +++ b/app/templates/views/guidance/branding-and-customisation.html @@ -12,10 +12,10 @@

                  This page explains how to:

                  Change your email branding

                  @@ -31,7 +31,7 @@

                  Add a reply-to email address

                  -

                  You can choose the email address that your users reply to. You must add at least one reply-to address for your service before you can request to go live.

                  +

                  You can choose the email address that your users reply to. You must add at least one reply-to address for your service before you can request to go live.

                  To add a reply-to email address:

                  diff --git a/app/templates/views/guidance/create-and-send-messages.html b/app/templates/views/guidance/create-and-send-messages.html index a72f8eb64..5f94387d7 100644 --- a/app/templates/views/guidance/create-and-send-messages.html +++ b/app/templates/views/guidance/create-and-send-messages.html @@ -9,7 +9,7 @@

                  Send messages

                  -

                  Create an account to see a short tutorial explaining how to create and send messages.

                  +

                  Create an account to see a short tutorial explaining how to create and send messages.

                  Bulk sending

                  diff --git a/app/templates/views/guidance/edit-and-format-messages.html b/app/templates/views/guidance/edit-and-format-messages.html index a97d57484..eb74e2e7d 100644 --- a/app/templates/views/guidance/edit-and-format-messages.html +++ b/app/templates/views/guidance/edit-and-format-messages.html @@ -11,10 +11,10 @@

                  This page explains how to:

                  Format your content

                  @@ -30,7 +30,7 @@ diff --git a/app/templates/views/guidance/index.html b/app/templates/views/guidance/index.html index a4db4270d..14ba6abe4 100644 --- a/app/templates/views/guidance/index.html +++ b/app/templates/views/guidance/index.html @@ -15,9 +15,9 @@

                  It explains how to:

                  More information

                  @@ -25,10 +25,10 @@

                  The GOV.UK Service Manual has advice on:

                  {% endblock %} diff --git a/app/templates/views/guidance/send-files-by-email.html b/app/templates/views/guidance/send-files-by-email.html index febb10243..331039a2e 100644 --- a/app/templates/views/guidance/send-files-by-email.html +++ b/app/templates/views/guidance/send-files-by-email.html @@ -8,8 +8,8 @@

                  Send files by email

                  -

                  Contact us if you want to send files by email.

                  +

                  Contact us if you want to send files by email.

                  -

                  Then follow the instructions to send a file by email in our API documentation.

                  +

                  Then follow the instructions to send a file by email in our API documentation.

                  {% endblock %} diff --git a/app/templates/views/guidance/upload-a-letter.html b/app/templates/views/guidance/upload-a-letter.html index 8211c3de4..619b2a5c3 100644 --- a/app/templates/views/guidance/upload-a-letter.html +++ b/app/templates/views/guidance/upload-a-letter.html @@ -35,8 +35,8 @@

                  To help you set up your letter, you can download our:

                  diff --git a/app/templates/views/inbound-sms-admin.html b/app/templates/views/inbound-sms-admin.html index f0052d399..31ecef8f3 100644 --- a/app/templates/views/inbound-sms-admin.html +++ b/app/templates/views/inbound-sms-admin.html @@ -46,8 +46,8 @@ Inbound Numbers {% for value in inbound_num_list.data: %} - {{value.number}} - + {{value.number}} + {% if value.active %} Active @@ -56,13 +56,13 @@ Inbound Numbers {% else %} Inactive {% endif %} - - - {{ value.service.name }} - + + + {{ value.service.name }} + {% endfor %} -{% endblock %} +{% endblock %} \ No newline at end of file diff --git a/app/templates/views/integration-testing.html b/app/templates/views/integration-testing.html index 121fca034..c1a18677a 100644 --- a/app/templates/views/integration-testing.html +++ b/app/templates/views/integration-testing.html @@ -14,7 +14,7 @@

                  This information has moved.

                  - Refer to the documentation + Refer to the documentation for the client library you are using.

                  diff --git a/app/templates/views/jobs/job.html b/app/templates/views/jobs/job.html index e8cbf7f6c..79080d928 100644 --- a/app/templates/views/jobs/job.html +++ b/app/templates/views/jobs/job.html @@ -25,7 +25,7 @@

              - Download live services csv report + Download live services csv report

              - Download performance platform report (.xlsx) + Download performance platform report (.xlsx)

              - Monthly notification statuses for live services + Monthly notification statuses for live services

              - Usage for all services + Usage for all services

              {% endblock %} diff --git a/app/templates/views/platform-admin/services.html b/app/templates/views/platform-admin/services.html index e0a7eed18..e899c0a96 100644 --- a/app/templates/views/platform-admin/services.html +++ b/app/templates/views/platform-admin/services.html @@ -49,7 +49,7 @@ {% call row() %} {% call field(border=False) %} - {{ service['name'] }} + {{ service['name'] }} {% endcall %} {{ stats_fields('email', service['stats']) }} diff --git a/app/templates/views/pricing/how-to-pay.html b/app/templates/views/pricing/how-to-pay.html index a3bf6bd19..9554377fc 100644 --- a/app/templates/views/pricing/how-to-pay.html +++ b/app/templates/views/pricing/how-to-pay.html @@ -18,7 +18,7 @@

              @@ -51,7 +51,7 @@

              - Contact us if you need help raising a purchase order. + Contact us if you need help raising a purchase order.

              {% endblock %} diff --git a/app/templates/views/pricing/index.html b/app/templates/views/pricing/index.html index 49c85c61b..4502ac9f0 100644 --- a/app/templates/views/pricing/index.html +++ b/app/templates/views/pricing/index.html @@ -20,13 +20,13 @@

              {% if not current_user.is_authenticated %} - Create an account then add as many different services as you need to.

              + Create an account then add as many different services as you need to.

              {% else %} You can add as many different services as you need to. {% endif %}

              -

              When you add a new service it will start in trial mode.

              +

              When you add a new service it will start in trial mode.

              Emails

              It’s free to send emails through Notify.

              @@ -40,7 +40,7 @@
            33. 25,000 free text messages for other public sector services
            34. It costs 1.58 pence (plus VAT) for each text message you send after you've used your free allowance.

              -

              See how to pay. +

              See how to pay.

              Long text messages

              If a text message is longer than 160 characters (including spaces), it’ll be charged as more than one message:

              diff --git a/app/templates/views/privacy.html b/app/templates/views/privacy.html index 875348fba..b4f2cf6de 100644 --- a/app/templates/views/privacy.html +++ b/app/templates/views/privacy.html @@ -23,7 +23,7 @@

              For the credentials used to access GOV.UK Notify, Cabinet Office is the data controller.

              -

              For more information see the Information Commissioner’s Office (ICO) Data Protection Public Register. +

              For more information see the Information Commissioner’s Office (ICO) Data Protection Public Register. The Cabinet Office registration number is: Z7414053

              What data we collect from you

              @@ -120,7 +120,7 @@

              GDS Privacy Team
              - gds-privacy-office@digital.cabinet-office.gov.uk + gds-privacy-office@digital.cabinet-office.gov.uk

              @@ -129,18 +129,18 @@

              Data Protection Officer
              - DPO@cabinetoffice.gov.uk
              + DPO@cabinetoffice.gov.uk
              Data Protection Officer
              Cabinet Office
              70 Whitehall
              London SW1A 2AS

              -

              If you have a complaint, you can also contact the Information Commissioner's Office (ICO). The ICO is an independent regulator set up to uphold information rights.

              +

              If you have a complaint, you can also contact the Information Commissioner's Office (ICO). The ICO is an independent regulator set up to uphold information rights.

              Information Commissioner’s Office
              - casework@ico.org.uk
              + casework@ico.org.uk
              0303 123 1113
              Wycliffe House
              Water Lane
              diff --git a/app/templates/views/providers/providers.html b/app/templates/views/providers/providers.html index 73f435c75..4314f8fc6 100644 --- a/app/templates/views/providers/providers.html +++ b/app/templates/views/providers/providers.html @@ -12,7 +12,7 @@ Providers

              SMS

              - Change priority + Change priority {% call(item, row_number) list_table( domestic_sms_providers, diff --git a/app/templates/views/roadmap.html b/app/templates/views/roadmap.html index 0e0a0cc02..085f408bf 100644 --- a/app/templates/views/roadmap.html +++ b/app/templates/views/roadmap.html @@ -11,7 +11,7 @@

              The GOV.UK Notify roadmap shows the things we’re working on and when we hope to have them ready for you to use.

              Notify is in public beta. This means it’s fully operational and supported, but we’re still adding new features. The roadmap is a guide to what we have planned, but some things might change.

              -

              You can contact us if you have any questions about the roadmap or suggestions for new features.

              +

              You can contact us if you have any questions about the roadmap or suggestions for new features.

              January to March 2020

              diff --git a/app/templates/views/security.html b/app/templates/views/security.html index 5e0b39108..d66b76acb 100644 --- a/app/templates/views/security.html +++ b/app/templates/views/security.html @@ -51,7 +51,7 @@
            35. your email address and password
            36. a text message code that Notify sends to your phone
            37. -

              If signing in with a text message is a problem for your team, contact us to find out about using an email link instead.

              +

              If signing in with a text message is a problem for your team, contact us to find out about using an email link instead.

              Information risk management

              Our approach to information risk management follows NCSC guidance. It assesses:

              @@ -65,8 +65,8 @@

              How we manage risks on Notify

              Things we do to manage risks on Notify include:

                -
              • formal risk assessments based on ISO 2700:2011 and National Cyber Security Centre guidance
              • -
              • CHECK-based testing, both annually and when any major changes are made to Notify
              • +
              • formal risk assessments based on ISO 2700:2011 and National Cyber Security Centre guidance
              • +
              • CHECK-based testing, both annually and when any major changes are made to Notify
              • residual risk statement preparation and active management of the risk treatment plan
              • regular updates to the Privacy Impact Assessment
              • security impact assessments
              • @@ -77,8 +77,8 @@

                Notify also has approval from the Office of the Government’s SIRO to host data within the EEA.

                Classifications and security vetting

                -

                You can use Notify to send messages classified as ‘OFFICIAL’ or ‘OFFICIAL-SENSITIVE’ under the Government Security Classifications policy.

                -

                You must not use Notify to send ‘special category data’, as defined in the General Data Protection Regulation (GDPR).

                -

                The Notify team has Security Check (SC) level clearance from United Kingdom Security Vetting (UKSV).

                +

                You can use Notify to send messages classified as ‘OFFICIAL’ or ‘OFFICIAL-SENSITIVE’ under the Government Security Classifications policy.

                +

                You must not use Notify to send ‘special category data’, as defined in the General Data Protection Regulation (GDPR).

                +

                The Notify team has Security Check (SC) level clearance from United Kingdom Security Vetting (UKSV).

                {% endblock %} diff --git a/app/templates/views/send-test.html b/app/templates/views/send-test.html index 5ed3da4a1..20c1728f3 100644 --- a/app/templates/views/send-test.html +++ b/app/templates/views/send-test.html @@ -31,13 +31,13 @@ {% if skip_link %} {% endif %} {% if link_to_upload %}

                - + Upload a list of {{ recipient_count_label(999, template.template_type) }}

                diff --git a/app/templates/views/send.html b/app/templates/views/send.html index f9bc93275..64772b9e6 100644 --- a/app/templates/views/send.html +++ b/app/templates/views/send.html @@ -46,7 +46,7 @@ {% endcall %}

                Your file will populate this template ({{ template.name }})

                diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index 3b1db42c0..a073efb1d 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -263,7 +263,7 @@

                {% if current_user.has_permissions('manage_service') %} To remove these restrictions, you can send us a - request to go live. + request to go live. {% else %} Your service manager can ask to have these restrictions removed. {% endif %} @@ -279,7 +279,7 @@

                Problems or comments? - Give feedback. + Give feedback.

                {% endif %} @@ -318,7 +318,7 @@ {{ text_field('Organisation')}} {% call field() %} {% if current_service.organisation_id %} - + {{ current_service.organisation.name }} {% else %} @@ -375,13 +375,13 @@ {% if current_service.active and (current_service.trial_mode or current_user.platform_admin) %}

                - + Delete this service {% if current_user.platform_admin %} - + Suspend service @@ -394,7 +394,7 @@ Service suspended - + Resume service diff --git a/app/templates/views/service-settings/email-reply-to/_verify-updates.html b/app/templates/views/service-settings/email-reply-to/_verify-updates.html index a6cc0d476..ccd22dfd5 100644 --- a/app/templates/views/service-settings/email-reply-to/_verify-updates.html +++ b/app/templates/views/service-settings/email-reply-to/_verify-updates.html @@ -15,7 +15,7 @@

                - Refresh + Refresh

                {% elif verification_status == "success" %} {{ banner("‘{}’ is ready to use".format(reply_to_email_address), type='default', with_tick=True) }} diff --git a/app/templates/views/service-settings/email_reply_to.html b/app/templates/views/service-settings/email_reply_to.html index c163fdaec..3c687ddd9 100644 --- a/app/templates/views/service-settings/email_reply_to.html +++ b/app/templates/views/service-settings/email_reply_to.html @@ -31,7 +31,7 @@ {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if current_service.count_email_reply_to_addresses > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/service-settings/letter-contact-details.html b/app/templates/views/service-settings/letter-contact-details.html index f57c5b2f0..57527ec58 100644 --- a/app/templates/views/service-settings/letter-contact-details.html +++ b/app/templates/views/service-settings/letter-contact-details.html @@ -22,7 +22,7 @@ Blank {% if current_service.default_letter_contact_block %} {% if current_user.has_permissions('manage_service') %} - Make default + Make default {% endif %} {% else %} (default) @@ -40,7 +40,7 @@ {% endif %}

                {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if letter_contact_details|length > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/service-settings/preview-letter-branding.html b/app/templates/views/service-settings/preview-letter-branding.html index 82e54509d..9a5395e48 100644 --- a/app/templates/views/service-settings/preview-letter-branding.html +++ b/app/templates/views/service-settings/preview-letter-branding.html @@ -17,7 +17,7 @@ {{ form.hidden_tag() }} {% endcall %} diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index 46991cd0c..15ea7e6a1 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -69,7 +69,7 @@ When we receive your request we’ll get back to you within one working day.

                - By requesting to go live you’re agreeing to our terms of use. + By requesting to go live you’re agreeing to our terms of use.

                {% call form_wrapper() %} {{ page_footer('Request to go live') }} diff --git a/app/templates/views/service-settings/set-auth-type.html b/app/templates/views/service-settings/set-auth-type.html index aaa2c2744..722f24bbe 100644 --- a/app/templates/views/service-settings/set-auth-type.html +++ b/app/templates/views/service-settings/set-auth-type.html @@ -24,7 +24,7 @@ or an email link.

                - You can set the sign-in method for individual team members. + You can set the sign-in method for individual team members.

                {% else %}

                @@ -34,7 +34,7 @@ Your team members sign in with a text message code.

                - Contact us if signing in with a text message is a problem for your team. + Contact us if signing in with a text message is a problem for your team.

                {% endif %} diff --git a/app/templates/views/service-settings/set-inbound-sms.html b/app/templates/views/service-settings/set-inbound-sms.html index bd9fda22f..72a2cb743 100644 --- a/app/templates/views/service-settings/set-inbound-sms.html +++ b/app/templates/views/service-settings/set-inbound-sms.html @@ -23,17 +23,17 @@ You can still send text messages from a sender name if you need to, but users will not be able to reply to those messages.

                - Contact us if you want to switch this feature off. + Contact us if you want to switch this feature off.

                {% if current_user.has_permissions('manage_api_keys') %}

                You can set up callbacks for received text messages on the - API integration page. + API integration page.

                {% endif %} {% else %}

                - Contact us if you want to be able to receive text messages from your users. + Contact us if you want to be able to receive text messages from your users.

                We’ll create a unique phone number for your service that they can reply to. diff --git a/app/templates/views/service-settings/set-international-sms.html b/app/templates/views/service-settings/set-international-sms.html index 400d47cc5..8327c8b4d 100644 --- a/app/templates/views/service-settings/set-international-sms.html +++ b/app/templates/views/service-settings/set-international-sms.html @@ -20,7 +20,7 @@ Messages to international mobile numbers are charged at 1, 2, or 3 times the cost of messages to UK mobile numbers.

                - See pricing for the list + See pricing for the list of rates.

                {% call form_wrapper() %} diff --git a/app/templates/views/service-settings/set-letter.html b/app/templates/views/service-settings/set-letter.html index 96f8b4e0c..7d2f85c64 100644 --- a/app/templates/views/service-settings/set-letter.html +++ b/app/templates/views/service-settings/set-letter.html @@ -20,7 +20,7 @@ It costs between 30p and 76p to send a letter using Notify.

                - See pricing for the list + See pricing for the list of rates.

                {% call form_wrapper() %} diff --git a/app/templates/views/service-settings/set-sms.html b/app/templates/views/service-settings/set-sms.html index 1c442e1b8..ef7d62ecb 100644 --- a/app/templates/views/service-settings/set-sms.html +++ b/app/templates/views/service-settings/set-sms.html @@ -26,7 +26,7 @@ after your free allowance.

                - See pricing for more details. + See pricing for more details.

                {% call form_wrapper() %} {{ radios(form.enabled) }} diff --git a/app/templates/views/service-settings/sms-senders.html b/app/templates/views/service-settings/sms-senders.html index 7fcf59770..e36003fc9 100644 --- a/app/templates/views/service-settings/sms-senders.html +++ b/app/templates/views/service-settings/sms-senders.html @@ -33,7 +33,7 @@ {% endif %} {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if current_service.count_sms_senders > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/signedout.html b/app/templates/views/signedout.html index 2b6bd0479..66e379a32 100644 --- a/app/templates/views/signedout.html +++ b/app/templates/views/signedout.html @@ -16,10 +16,10 @@ @@ -38,7 +38,7 @@ "classes": "product-page-button button-container__button govuk-!-margin-right-3", "href": url_for('main.register' ) }) }} - or sign in if you’ve used + or sign in if you’ve used it before @@ -135,7 +135,7 @@

                See the - list of services and organisations. + list of services and organisations.

                @@ -163,7 +163,7 @@

                There’s no monthly charge, no setup fee and no procurement process.

                -

                Find out more about pricing. +

                Find out more about pricing.

                @@ -180,7 +180,7 @@ and is supported 24 hours a day, 7 days a week.

                - Contact us if you have a question or want + Contact us if you have a question or want to give feedback.

                diff --git a/app/templates/views/signin.html b/app/templates/views/signin.html index c51349b9a..047d51c8c 100644 --- a/app/templates/views/signin.html +++ b/app/templates/views/signin.html @@ -27,7 +27,7 @@

                Sign in

                If you do not have an account, you can - create one now. + create one now.

                {% endif %} diff --git a/app/templates/views/styleguide.html b/app/templates/views/styleguide.html index 34cbe4ea6..430ffb399 100644 --- a/app/templates/views/styleguide.html +++ b/app/templates/views/styleguide.html @@ -16,11 +16,11 @@ {% block maincolumn_content %}

                - www.notify.works/_styleguide + www.notify.works/_styleguide

                - View source + View source

                Banner

                @@ -125,7 +125,7 @@ {{ boolean_field(True) }} {{ boolean_field(False) }} {% call field(align='right') %} - Change + Change {% endcall %} {% endcall %} {% endcall %} @@ -173,7 +173,7 @@ {% endcall %} {% endcall %} diff --git a/app/templates/views/support/bat-phone.html b/app/templates/views/support/bat-phone.html index 82b7b6972..6a48c0d4b 100644 --- a/app/templates/views/support/bat-phone.html +++ b/app/templates/views/support/bat-phone.html @@ -15,7 +15,7 @@

                First, check the - system status page. + system status page. You do not need to contact us if the problem you’re having is listed on that page.

                @@ -33,11 +33,11 @@

                Any other problems

                - Fill in this form + Fill in this form and we’ll get back to you by the next working day.

                - Back to support + Back to support

                diff --git a/app/templates/views/support/index.html b/app/templates/views/support/index.html index 77ba37be2..f6106e732 100644 --- a/app/templates/views/support/index.html +++ b/app/templates/views/support/index.html @@ -20,7 +20,7 @@ {{ page_footer('Continue') }} {% endcall %} -

                You can also contact us on Slack.

                +

                You can also contact us on Slack.

                Office hours

                Our office hours are 9:30am to 5:30pm, Monday to Friday.

                diff --git a/app/templates/views/support/report-problem.html b/app/templates/views/support/report-problem.html index 99c250640..12f40e2c1 100644 --- a/app/templates/views/support/report-problem.html +++ b/app/templates/views/support/report-problem.html @@ -19,7 +19,7 @@

                - Check our system status + Check our system status page to see if there are any known issues with GOV.UK Notify.

                diff --git a/app/templates/views/templates/_template.html b/app/templates/views/templates/_template.html index a6550a7a7..eecee2ece 100644 --- a/app/templates/views/templates/_template.html +++ b/app/templates/views/templates/_template.html @@ -23,7 +23,7 @@ {% endif %} {% if current_user.has_permissions('send_messages', restrict_admin_usage=True) and not letter_too_long %} @@ -31,14 +31,14 @@ {% else %} {% if current_user.has_permissions('send_messages', restrict_admin_usage=True) %} {% endif %} {% if current_user.has_permissions('manage_templates') %} @@ -51,14 +51,14 @@
                {% if current_user.has_permissions('manage_templates') and template.template_type == 'letter' %} {% if not current_service.letter_branding_id %} - Add logo + Add logo {% endif %} - Change - Edit + Change + Edit {% if current_service.count_letter_contact_details %} - Edit + Edit {% else %} - Edit + Edit {% endif %} {% endif %} {{ template|string }} diff --git a/app/templates/views/templates/_template_list.html b/app/templates/views/templates/_template_list.html index 5bcb03501..03956452b 100644 --- a/app/templates/views/templates/_template_list.html +++ b/app/templates/views/templates/_template_list.html @@ -34,16 +34,16 @@ {% endif %}

                {% for ancestor in item.ancestors %} - + {{- format_item_name(ancestor.name) -}} {% endfor %} {% if item.is_folder %} - + {{ format_item_name(item.name) }} {% else %} - + {{ format_item_name(item.name) }} {% endif %} diff --git a/app/templates/views/templates/action_blocked.html b/app/templates/views/templates/action_blocked.html index c7b4b09c3..84bb59b8e 100644 --- a/app/templates/views/templates/action_blocked.html +++ b/app/templates/views/templates/action_blocked.html @@ -21,7 +21,7 @@

                If you need to send {{ message_count_label(999, notification_type, suffix='') }} - get in touch with the GOV.UK Notify team. + get in touch with the GOV.UK Notify team.

                diff --git a/app/templates/views/templates/choose-reply.html b/app/templates/views/templates/choose-reply.html index 823790da5..fa1681cef 100644 --- a/app/templates/views/templates/choose-reply.html +++ b/app/templates/views/templates/choose-reply.html @@ -42,16 +42,16 @@

                {% for ancestor in item.ancestors %} - + {{ ancestor.name }} / {% endfor %} {% if item.is_folder %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %} diff --git a/app/templates/views/templates/choose.html b/app/templates/views/templates/choose.html index 99812fc89..95691fc49 100644 --- a/app/templates/views/templates/choose.html +++ b/app/templates/views/templates/choose.html @@ -54,7 +54,7 @@

                {% if current_user.has_permissions('manage_templates') and current_template_folder_id and user_has_template_folder_permission %} {% endif %}
                diff --git a/app/templates/views/templates/choose_history.html b/app/templates/views/templates/choose_history.html index 327932172..f8a045028 100644 --- a/app/templates/views/templates/choose_history.html +++ b/app/templates/views/templates/choose_history.html @@ -14,6 +14,6 @@ {% endfor %}

                - Back to current templates + Back to current templates

                {% endblock %} diff --git a/app/templates/views/templates/copy.html b/app/templates/views/templates/copy.html index 7aac461ec..84c5a36ed 100644 --- a/app/templates/views/templates/copy.html +++ b/app/templates/views/templates/copy.html @@ -25,23 +25,23 @@

                {% for ancestor in item.ancestors %} {% if ancestor.is_service %} - + {% else %} - + {% endif %} {{ ancestor.name }} {% endfor %} {% if item.is_service %} - + {{ item.name }} {% elif item.is_folder %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %} diff --git a/app/templates/views/templates/set-template-sender.html b/app/templates/views/templates/set-template-sender.html index 5f8d449bf..75f76f686 100644 --- a/app/templates/views/templates/set-template-sender.html +++ b/app/templates/views/templates/set-template-sender.html @@ -23,7 +23,7 @@ hide_legend=True ) }} {{ page_footer('Continue') }} - Add new sender + Add new sender {% endcall %} diff --git a/app/templates/views/templates/template.html b/app/templates/views/templates/template.html index f9e00c136..410680fe7 100644 --- a/app/templates/views/templates/template.html +++ b/app/templates/views/templates/template.html @@ -60,21 +60,21 @@

                  - See previous versions + See previous versions
                {% endif %} {% if current_user.has_permissions('manage_templates') and user_has_template_permission %} {% if not template._template.archived %} - Delete this template + Delete this template   {% endif %} {% if template.template_type != 'letter' %} {% if not template._template.redact_personalisation %} - Hide personalisation after sending + Hide personalisation after sending {% else %}

                Personalisation is hidden after sending

                diff --git a/app/templates/views/terms-of-use.html b/app/templates/views/terms-of-use.html index 2974c2734..5109906c8 100644 --- a/app/templates/views/terms-of-use.html +++ b/app/templates/views/terms-of-use.html @@ -20,9 +20,9 @@
              • tell us immediately if you have any security breaches
              • keep your API keys secure
              • get the right levels of consent (to send messages and to use data)
              • -
              • not send unsolicited messages, only ones related to a transaction or something the user has subscribed to be updated about (check the Service Manual if you’re not sure)
              • +
              • not send unsolicited messages, only ones related to a transaction or something the user has subscribed to be updated about (check the Service Manual if you’re not sure)
              • - send messages that meet the GOV.UK Service Manual standards for writing text messages and emails
              • + send messages that meet the GOV.UK Service Manual standards for writing text messages and emails
              • not send messages containing any personally or commercially sensitive information
              • check that the data you add to Notify is accurate and complies with data protection legislation
              @@ -32,14 +32,14 @@
              • send all the messages you pass to us, as long as they meet our guidelines
              • - show how Notify is performing (through our performance and status pages) + show how Notify is performing (through our performance and status pages)
              • -
              • keep your data secure
              • +
              • keep your data secure
              • give you one month’s notice by email if we change our terms of use or delivery providers

              Leaving Notify

              -

              You can leave Notify at any time. Just contact us and we’ll close your account.

              +

              You can leave Notify at any time. Just contact us and we’ll close your account.

              When you leave Notify, all your data will be deleted.

              {% endblock %} diff --git a/app/templates/views/trial-mode.html b/app/templates/views/trial-mode.html index 4a83f3ebd..316bc3b30 100644 --- a/app/templates/views/trial-mode.html +++ b/app/templates/views/trial-mode.html @@ -18,13 +18,13 @@ {% if current_service and current_service.trial_mode %}

              - To remove these restrictions, you can request to go live.

              + To remove these restrictions, you can request to go live.

              {% else %}

              To remove these restrictions:

                -
              1. Sign in to Notify.
              2. +
              3. Sign in to Notify.
              4. Go to the Settings page.
              5. Select Request to go live.
              diff --git a/app/templates/views/uploads/choose-file.html b/app/templates/views/uploads/choose-file.html index 897926997..3897a6019 100644 --- a/app/templates/views/uploads/choose-file.html +++ b/app/templates/views/uploads/choose-file.html @@ -33,7 +33,7 @@ )}}

              You can upload a single letter as a PDF.

              -

              Your file must meet our letter specification.

              +

              Your file must meet our letter specification.

              diff --git a/app/templates/views/uploads/preview.html b/app/templates/views/uploads/preview.html index 05e70e5a8..718cf8c6d 100644 --- a/app/templates/views/uploads/preview.html +++ b/app/templates/views/uploads/preview.html @@ -24,7 +24,7 @@ button_text='Upload your file again' ) }} - Back to top + Back to top {% elif current_service.trial_mode %} diff --git a/app/templates/views/usage.html b/app/templates/views/usage.html index a91a4814f..294d25dfd 100644 --- a/app/templates/views/usage.html +++ b/app/templates/views/usage.html @@ -132,7 +132,7 @@

              What counts as 1 text message?
              - See pricing. + See pricing.

              diff --git a/app/templates/views/using-notify.html b/app/templates/views/using-notify.html index 41127b2b6..f986accf4 100644 --- a/app/templates/views/using-notify.html +++ b/app/templates/views/using-notify.html @@ -19,11 +19,11 @@

              Find out more about:

            38. email attachments are often marked as spam
            39. -

              Contact us if you want to send files by email.

              -

              Read our API documentation for more information.

              +

              Contact us if you want to send files by email.

              +

              Read our API documentation for more information.

              Add a reply-to address

              Notify lets you choose the email address that users reply to.

              @@ -45,6 +45,6 @@

              Pricing

              It’s free to send emails through Notify.

              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/features/letters.html b/app/templates/views/features/letters.html index c779951b3..19ccbf6a6 100644 --- a/app/templates/views/features/letters.html +++ b/app/templates/views/features/letters.html @@ -10,7 +10,7 @@

              Letters

              GOV.UK Notify will print, pack and post your letters for you.

              {% if not current_user.is_authenticated %} -

              Create an account and try Notify for yourself.

              +

              Create an account and try Notify for yourself.

              {% endif %}

              Features

              @@ -20,7 +20,7 @@
            40. personalise the content of your letter
            41. send bulk mail
            42. -

              You can also integrate with our API to send letters automatically.

              +

              You can also integrate with our API to send letters automatically.

              Choose your postage

              Notify can send letters by first or second class post.

              @@ -33,7 +33,7 @@

              Upload your own letters

              You can create reusable letter templates in Notify, or upload and send your own letters with the Notify API.

              -

              Read our documentation.

              +

              Read our documentation.

              Pricing

              It costs between 30p and 76p (plus VAT) to send a letter. Prices include:

              @@ -44,6 +44,6 @@
            43. first or second class postage
            44. Letters can be up to 10 pages long (5 double-sided sheets of paper).

              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/features/text-messages.html b/app/templates/views/features/text-messages.html index 270e192f5..80d6f644b 100644 --- a/app/templates/views/features/text-messages.html +++ b/app/templates/views/features/text-messages.html @@ -10,7 +10,7 @@

              Text messages

              Send thousands of free text messages to UK and international numbers with GOV.UK Notify.

              {% if not current_user.is_authenticated %} -

              Create an account and try Notify for yourself.

              +

              Create an account and try Notify for yourself.

              {% endif %}

              Features

              @@ -19,12 +19,12 @@
            45. create reusable text message templates
            46. personalise the content of your texts
            47. send and schedule bulk messages
            48. -

              You can also integrate with our API to send text messages automatically.

              +

              You can also integrate with our API to send text messages automatically.

              Receive text messages

              Let people send messages to your service or reply to your texts.

              You can see and reply to the messages you receive when you sign in to Notify. If you’re using our API, you can set up your own automated processes to manage replies.

              -

              Contact us to request a unique number for text message replies.

              +

              Contact us to request a unique number for text message replies.

              Show people who your texts are from

              When you send a text message with Notify, the sender name tells people who it's from.

              @@ -36,6 +36,6 @@
              • 250,000 free text messages for central government services
              • 25,000 free text messages for other public sector services
              -

              See pricing for more details.

              +

              See pricing for more details.

              {% endblock %} diff --git a/app/templates/views/find-services/find-services-by-name.html b/app/templates/views/find-services/find-services-by-name.html index 04ef957bf..a1fa28fda 100644 --- a/app/templates/views/find-services/find-services-by-name.html +++ b/app/templates/views/find-services/find-services-by-name.html @@ -43,7 +43,7 @@
                {% for service in services_found %}
              • - {{ service.name }} + {{ service.name }}

              • {% endfor %} diff --git a/app/templates/views/find-users/find-users-by-email.html b/app/templates/views/find-users/find-users-by-email.html index fc9380456..296977b9f 100644 --- a/app/templates/views/find-users/find-users-by-email.html +++ b/app/templates/views/find-users/find-users-by-email.html @@ -43,7 +43,7 @@
                  {% for user in users_found %}
                • - {{ user.email_address }} + {{ user.email_address }}

                  {{ user.name }}


                • diff --git a/app/templates/views/find-users/user-information.html b/app/templates/views/find-users/user-information.html index aa8d699a2..43bb4c5c3 100644 --- a/app/templates/views/find-users/user-information.html +++ b/app/templates/views/find-users/user-information.html @@ -19,7 +19,7 @@ @@ -35,7 +35,7 @@ @@ -62,7 +62,7 @@ {% endif %} {% if user.state == 'active' %} - + Archive user diff --git a/app/templates/views/get-started.html b/app/templates/views/get-started.html index 2fc4390c1..489791f17 100644 --- a/app/templates/views/get-started.html +++ b/app/templates/views/get-started.html @@ -14,7 +14,7 @@
                  1. Check if GOV.UK Notify is right for you

                    -

                    Read about our features, pricing and roadmap.

                    +

                    Read about our features, pricing and roadmap.

                    {{ govukDetails({ "summaryText": "Organisations that can use Notify", "html": ''' @@ -35,15 +35,15 @@
                  2. Create an account

                    {% if not current_user.is_authenticated %} -

                    Create an account for free and add your first Notify service. When you add a new service it will start in trial mode.

                    +

                    Create an account for free and add your first Notify service. When you add a new service it will start in trial mode.

                    {% else %} -

                    Create an account for free and add your first Notify service. When you add a new service, it will start in trial mode.

                    +

                    Create an account for free and add your first Notify service. When you add a new service, it will start in trial mode.

                    {% endif %}
                  3. Write some messages

                    -

                    Add message templates with examples of the content you plan to send. You can use our guidance to help you.

                    +

                    Add message templates with examples of the content you plan to send. You can use our guidance to help you.

                  4. @@ -52,15 +52,15 @@

                    Review your settings to add message branding, reply-to addresses and sender information.

                    Add team members and check their permissions.

                    {% else %} -

                    Review your settings to add message branding, reply-to addresses and sender information.

                    -

                    Add team members and check their permissions.

                    +

                    Review your settings to add message branding, reply-to addresses and sender information.

                    +

                    Add team members and check their permissions.

                    {% endif %}
                  5. Set up an API integration (optional)

                    You can use the Notify API to send messages automatically.

                    -

                    Our documentation explains how to integrate the API with a web application or back office system.

                    +

                    Our documentation explains how to integrate the API with a web application or back office system.

                  6. @@ -68,9 +68,9 @@ {% if not current_user.is_authenticated or not current_service %}

                    When you’re ready to send messages to people outside your team, go to the Settings page and select Request to go live. We’ll approve your request within one working day.

                    {% else %} -

                    You should request to go live when you’re ready to send messages to people outside your team. We’ll approve your request within one working day.

                    +

                    You should request to go live when you’re ready to send messages to people outside your team. We’ll approve your request within one working day.

                    {% endif %} -

                    Check how to pay if you’re planning to send letters or exceed the free text message allowance.

                    +

                    Check how to pay if you’re planning to send letters or exceed the free text message allowance.

                  diff --git a/app/templates/views/inbound-sms-admin.html b/app/templates/views/inbound-sms-admin.html index 31ecef8f3..8a83b6313 100644 --- a/app/templates/views/inbound-sms-admin.html +++ b/app/templates/views/inbound-sms-admin.html @@ -58,7 +58,7 @@ Inbound Numbers {% endif %} - {{ value.service.name }} + {{ value.service.name }} {% endfor %} diff --git a/app/templates/views/integration-testing.html b/app/templates/views/integration-testing.html index c1a18677a..121fca034 100644 --- a/app/templates/views/integration-testing.html +++ b/app/templates/views/integration-testing.html @@ -14,7 +14,7 @@

                  This information has moved.

                  - Refer to the documentation + Refer to the documentation for the client library you are using.

                  diff --git a/app/templates/views/jobs/job.html b/app/templates/views/jobs/job.html index 79080d928..2e06b56a4 100644 --- a/app/templates/views/jobs/job.html +++ b/app/templates/views/jobs/job.html @@ -25,7 +25,7 @@
                -

                If signing in with a text message is a problem for your team, contact us to find out about using an email link instead.

                +

                If signing in with a text message is a problem for your team, contact us to find out about using an email link instead.

                Information risk management

                Our approach to information risk management follows NCSC guidance. It assesses:

                @@ -65,8 +65,8 @@

                How we manage risks on Notify

                Things we do to manage risks on Notify include:

                  -
                • formal risk assessments based on ISO 2700:2011 and National Cyber Security Centre guidance
                • -
                • CHECK-based testing, both annually and when any major changes are made to Notify
                • +
                • formal risk assessments based on ISO 2700:2011 and National Cyber Security Centre guidance
                • +
                • CHECK-based testing, both annually and when any major changes are made to Notify
                • residual risk statement preparation and active management of the risk treatment plan
                • regular updates to the Privacy Impact Assessment
                • security impact assessments
                • @@ -77,8 +77,8 @@

                  Notify also has approval from the Office of the Government’s SIRO to host data within the EEA.

                  Classifications and security vetting

                  -

                  You can use Notify to send messages classified as ‘OFFICIAL’ or ‘OFFICIAL-SENSITIVE’ under the Government Security Classifications policy.

                  -

                  You must not use Notify to send ‘special category data’, as defined in the General Data Protection Regulation (GDPR).

                  -

                  The Notify team has Security Check (SC) level clearance from United Kingdom Security Vetting (UKSV).

                  +

                  You can use Notify to send messages classified as ‘OFFICIAL’ or ‘OFFICIAL-SENSITIVE’ under the Government Security Classifications policy.

                  +

                  You must not use Notify to send ‘special category data’, as defined in the General Data Protection Regulation (GDPR).

                  +

                  The Notify team has Security Check (SC) level clearance from United Kingdom Security Vetting (UKSV).

                  {% endblock %} diff --git a/app/templates/views/send-test.html b/app/templates/views/send-test.html index 20c1728f3..5ed3da4a1 100644 --- a/app/templates/views/send-test.html +++ b/app/templates/views/send-test.html @@ -31,13 +31,13 @@ {% if skip_link %} {% endif %} {% if link_to_upload %}

                  - + Upload a list of {{ recipient_count_label(999, template.template_type) }}

                  diff --git a/app/templates/views/send.html b/app/templates/views/send.html index 64772b9e6..f9bc93275 100644 --- a/app/templates/views/send.html +++ b/app/templates/views/send.html @@ -46,7 +46,7 @@ {% endcall %}

                  Your file will populate this template ({{ template.name }})

                  diff --git a/app/templates/views/service-settings.html b/app/templates/views/service-settings.html index a073efb1d..2e819dd6a 100644 --- a/app/templates/views/service-settings.html +++ b/app/templates/views/service-settings.html @@ -263,7 +263,7 @@

                  {% if current_user.has_permissions('manage_service') %} To remove these restrictions, you can send us a - request to go live. + request to go live. {% else %} Your service manager can ask to have these restrictions removed. {% endif %} @@ -279,7 +279,7 @@

                  Problems or comments? - Give feedback. + Give feedback.

                  {% endif %} @@ -318,7 +318,7 @@ {{ text_field('Organisation')}} {% call field() %} {% if current_service.organisation_id %} - + {{ current_service.organisation.name }} {% else %} @@ -375,13 +375,13 @@ {% if current_service.active and (current_service.trial_mode or current_user.platform_admin) %}

                  - + Delete this service {% if current_user.platform_admin %} - + Suspend service @@ -394,7 +394,7 @@ Service suspended - + Resume service diff --git a/app/templates/views/service-settings/email-reply-to/_verify-updates.html b/app/templates/views/service-settings/email-reply-to/_verify-updates.html index ccd22dfd5..a6cc0d476 100644 --- a/app/templates/views/service-settings/email-reply-to/_verify-updates.html +++ b/app/templates/views/service-settings/email-reply-to/_verify-updates.html @@ -15,7 +15,7 @@

                  - Refresh + Refresh

                  {% elif verification_status == "success" %} {{ banner("‘{}’ is ready to use".format(reply_to_email_address), type='default', with_tick=True) }} diff --git a/app/templates/views/service-settings/email_reply_to.html b/app/templates/views/service-settings/email_reply_to.html index 3c687ddd9..c163fdaec 100644 --- a/app/templates/views/service-settings/email_reply_to.html +++ b/app/templates/views/service-settings/email_reply_to.html @@ -31,7 +31,7 @@ {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if current_service.count_email_reply_to_addresses > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/service-settings/letter-contact-details.html b/app/templates/views/service-settings/letter-contact-details.html index 57527ec58..f57c5b2f0 100644 --- a/app/templates/views/service-settings/letter-contact-details.html +++ b/app/templates/views/service-settings/letter-contact-details.html @@ -22,7 +22,7 @@ Blank {% if current_service.default_letter_contact_block %} {% if current_user.has_permissions('manage_service') %} - Make default + Make default {% endif %} {% else %} (default) @@ -40,7 +40,7 @@ {% endif %}

                  {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if letter_contact_details|length > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/service-settings/preview-letter-branding.html b/app/templates/views/service-settings/preview-letter-branding.html index 9a5395e48..82e54509d 100644 --- a/app/templates/views/service-settings/preview-letter-branding.html +++ b/app/templates/views/service-settings/preview-letter-branding.html @@ -17,7 +17,7 @@ {{ form.hidden_tag() }} {% endcall %} diff --git a/app/templates/views/service-settings/request-to-go-live.html b/app/templates/views/service-settings/request-to-go-live.html index 15ea7e6a1..46991cd0c 100644 --- a/app/templates/views/service-settings/request-to-go-live.html +++ b/app/templates/views/service-settings/request-to-go-live.html @@ -69,7 +69,7 @@ When we receive your request we’ll get back to you within one working day.

                  - By requesting to go live you’re agreeing to our terms of use. + By requesting to go live you’re agreeing to our terms of use.

                  {% call form_wrapper() %} {{ page_footer('Request to go live') }} diff --git a/app/templates/views/service-settings/set-auth-type.html b/app/templates/views/service-settings/set-auth-type.html index 722f24bbe..aaa2c2744 100644 --- a/app/templates/views/service-settings/set-auth-type.html +++ b/app/templates/views/service-settings/set-auth-type.html @@ -24,7 +24,7 @@ or an email link.

                  - You can set the sign-in method for individual team members. + You can set the sign-in method for individual team members.

                  {% else %}

                  @@ -34,7 +34,7 @@ Your team members sign in with a text message code.

                  - Contact us if signing in with a text message is a problem for your team. + Contact us if signing in with a text message is a problem for your team.

                  {% endif %} diff --git a/app/templates/views/service-settings/set-inbound-sms.html b/app/templates/views/service-settings/set-inbound-sms.html index 72a2cb743..bd9fda22f 100644 --- a/app/templates/views/service-settings/set-inbound-sms.html +++ b/app/templates/views/service-settings/set-inbound-sms.html @@ -23,17 +23,17 @@ You can still send text messages from a sender name if you need to, but users will not be able to reply to those messages.

                  - Contact us if you want to switch this feature off. + Contact us if you want to switch this feature off.

                  {% if current_user.has_permissions('manage_api_keys') %}

                  You can set up callbacks for received text messages on the - API integration page. + API integration page.

                  {% endif %} {% else %}

                  - Contact us if you want to be able to receive text messages from your users. + Contact us if you want to be able to receive text messages from your users.

                  We’ll create a unique phone number for your service that they can reply to. diff --git a/app/templates/views/service-settings/set-international-sms.html b/app/templates/views/service-settings/set-international-sms.html index 8327c8b4d..400d47cc5 100644 --- a/app/templates/views/service-settings/set-international-sms.html +++ b/app/templates/views/service-settings/set-international-sms.html @@ -20,7 +20,7 @@ Messages to international mobile numbers are charged at 1, 2, or 3 times the cost of messages to UK mobile numbers.

                  - See pricing for the list + See pricing for the list of rates.

                  {% call form_wrapper() %} diff --git a/app/templates/views/service-settings/set-letter.html b/app/templates/views/service-settings/set-letter.html index 7d2f85c64..96f8b4e0c 100644 --- a/app/templates/views/service-settings/set-letter.html +++ b/app/templates/views/service-settings/set-letter.html @@ -20,7 +20,7 @@ It costs between 30p and 76p to send a letter using Notify.

                  - See pricing for the list + See pricing for the list of rates.

                  {% call form_wrapper() %} diff --git a/app/templates/views/service-settings/set-sms.html b/app/templates/views/service-settings/set-sms.html index ef7d62ecb..1c442e1b8 100644 --- a/app/templates/views/service-settings/set-sms.html +++ b/app/templates/views/service-settings/set-sms.html @@ -26,7 +26,7 @@ after your free allowance.

                  - See pricing for more details. + See pricing for more details.

                  {% call form_wrapper() %} {{ radios(form.enabled) }} diff --git a/app/templates/views/service-settings/sms-senders.html b/app/templates/views/service-settings/sms-senders.html index e36003fc9..7fcf59770 100644 --- a/app/templates/views/service-settings/sms-senders.html +++ b/app/templates/views/service-settings/sms-senders.html @@ -33,7 +33,7 @@ {% endif %} {% if current_user.has_permissions('manage_service') %} - Change + Change {% endif %} {% if current_service.count_sms_senders > 1 %} {{ api_key(item.id, thing="ID") }} diff --git a/app/templates/views/signedout.html b/app/templates/views/signedout.html index 66e379a32..2b6bd0479 100644 --- a/app/templates/views/signedout.html +++ b/app/templates/views/signedout.html @@ -16,10 +16,10 @@ @@ -38,7 +38,7 @@ "classes": "product-page-button button-container__button govuk-!-margin-right-3", "href": url_for('main.register' ) }) }} - or sign in if you’ve used + or sign in if you’ve used it before @@ -135,7 +135,7 @@

                  See the - list of services and organisations. + list of services and organisations.

                  @@ -163,7 +163,7 @@

                  There’s no monthly charge, no setup fee and no procurement process.

                  -

                  Find out more about pricing. +

                  Find out more about pricing.

                  @@ -180,7 +180,7 @@ and is supported 24 hours a day, 7 days a week.

                  - Contact us if you have a question or want + Contact us if you have a question or want to give feedback.

                  diff --git a/app/templates/views/signin.html b/app/templates/views/signin.html index 46f651c15..e23f71cd2 100644 --- a/app/templates/views/signin.html +++ b/app/templates/views/signin.html @@ -27,7 +27,7 @@

                  Sign in

                  If you do not have an account, you can - create one now. + create one now.

                  {% endif %} diff --git a/app/templates/views/styleguide.html b/app/templates/views/styleguide.html index 430ffb399..34cbe4ea6 100644 --- a/app/templates/views/styleguide.html +++ b/app/templates/views/styleguide.html @@ -16,11 +16,11 @@ {% block maincolumn_content %}

                  - www.notify.works/_styleguide + www.notify.works/_styleguide

                  - View source + View source

                  Banner

                  @@ -125,7 +125,7 @@ {{ boolean_field(True) }} {{ boolean_field(False) }} {% call field(align='right') %} - Change + Change {% endcall %} {% endcall %} {% endcall %} @@ -173,7 +173,7 @@ {% endcall %} {% endcall %} diff --git a/app/templates/views/support/bat-phone.html b/app/templates/views/support/bat-phone.html index 6a48c0d4b..82b7b6972 100644 --- a/app/templates/views/support/bat-phone.html +++ b/app/templates/views/support/bat-phone.html @@ -15,7 +15,7 @@

                  First, check the - system status page. + system status page. You do not need to contact us if the problem you’re having is listed on that page.

                  @@ -33,11 +33,11 @@

                  Any other problems

                  - Fill in this form + Fill in this form and we’ll get back to you by the next working day.

                  - Back to support + Back to support

                  diff --git a/app/templates/views/support/index.html b/app/templates/views/support/index.html index f6106e732..77ba37be2 100644 --- a/app/templates/views/support/index.html +++ b/app/templates/views/support/index.html @@ -20,7 +20,7 @@ {{ page_footer('Continue') }} {% endcall %} -

                  You can also contact us on Slack.

                  +

                  You can also contact us on Slack.

                  Office hours

                  Our office hours are 9:30am to 5:30pm, Monday to Friday.

                  diff --git a/app/templates/views/support/report-problem.html b/app/templates/views/support/report-problem.html index 12f40e2c1..99c250640 100644 --- a/app/templates/views/support/report-problem.html +++ b/app/templates/views/support/report-problem.html @@ -19,7 +19,7 @@

                  - Check our system status + Check our system status page to see if there are any known issues with GOV.UK Notify.

                  diff --git a/app/templates/views/templates/_template.html b/app/templates/views/templates/_template.html index eecee2ece..a6550a7a7 100644 --- a/app/templates/views/templates/_template.html +++ b/app/templates/views/templates/_template.html @@ -23,7 +23,7 @@ {% endif %} {% if current_user.has_permissions('send_messages', restrict_admin_usage=True) and not letter_too_long %} @@ -31,14 +31,14 @@ {% else %} {% if current_user.has_permissions('send_messages', restrict_admin_usage=True) %} {% endif %} {% if current_user.has_permissions('manage_templates') %} @@ -51,14 +51,14 @@
                  {% if current_user.has_permissions('manage_templates') and template.template_type == 'letter' %} {% if not current_service.letter_branding_id %} - Add logo + Add logo {% endif %} - Change - Edit + Change + Edit {% if current_service.count_letter_contact_details %} - Edit + Edit {% else %} - Edit + Edit {% endif %} {% endif %} {{ template|string }} diff --git a/app/templates/views/templates/_template_list.html b/app/templates/views/templates/_template_list.html index 03956452b..5bcb03501 100644 --- a/app/templates/views/templates/_template_list.html +++ b/app/templates/views/templates/_template_list.html @@ -34,16 +34,16 @@ {% endif %}

                  {% for ancestor in item.ancestors %} - + {{- format_item_name(ancestor.name) -}} {% endfor %} {% if item.is_folder %} - + {{ format_item_name(item.name) }} {% else %} - + {{ format_item_name(item.name) }} {% endif %} diff --git a/app/templates/views/templates/action_blocked.html b/app/templates/views/templates/action_blocked.html index 84bb59b8e..c7b4b09c3 100644 --- a/app/templates/views/templates/action_blocked.html +++ b/app/templates/views/templates/action_blocked.html @@ -21,7 +21,7 @@

                  If you need to send {{ message_count_label(999, notification_type, suffix='') }} - get in touch with the GOV.UK Notify team. + get in touch with the GOV.UK Notify team.

                  diff --git a/app/templates/views/templates/choose-reply.html b/app/templates/views/templates/choose-reply.html index fa1681cef..823790da5 100644 --- a/app/templates/views/templates/choose-reply.html +++ b/app/templates/views/templates/choose-reply.html @@ -42,16 +42,16 @@

                  {% for ancestor in item.ancestors %} - + {{ ancestor.name }} / {% endfor %} {% if item.is_folder %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %} diff --git a/app/templates/views/templates/choose.html b/app/templates/views/templates/choose.html index 95691fc49..99812fc89 100644 --- a/app/templates/views/templates/choose.html +++ b/app/templates/views/templates/choose.html @@ -54,7 +54,7 @@

                  {% if current_user.has_permissions('manage_templates') and current_template_folder_id and user_has_template_folder_permission %} {% endif %}
                  diff --git a/app/templates/views/templates/choose_history.html b/app/templates/views/templates/choose_history.html index f8a045028..327932172 100644 --- a/app/templates/views/templates/choose_history.html +++ b/app/templates/views/templates/choose_history.html @@ -14,6 +14,6 @@ {% endfor %}

                  - Back to current templates + Back to current templates

                  {% endblock %} diff --git a/app/templates/views/templates/copy.html b/app/templates/views/templates/copy.html index 84c5a36ed..7aac461ec 100644 --- a/app/templates/views/templates/copy.html +++ b/app/templates/views/templates/copy.html @@ -25,23 +25,23 @@

                  {% for ancestor in item.ancestors %} {% if ancestor.is_service %} - + {% else %} - + {% endif %} {{ ancestor.name }} {% endfor %} {% if item.is_service %} - + {{ item.name }} {% elif item.is_folder %} - + {{ item.name }} {% else %} - + {{ item.name }} {% endif %} diff --git a/app/templates/views/templates/set-template-sender.html b/app/templates/views/templates/set-template-sender.html index 75f76f686..5f8d449bf 100644 --- a/app/templates/views/templates/set-template-sender.html +++ b/app/templates/views/templates/set-template-sender.html @@ -23,7 +23,7 @@ hide_legend=True ) }} {{ page_footer('Continue') }} - Add new sender + Add new sender {% endcall %} diff --git a/app/templates/views/templates/template.html b/app/templates/views/templates/template.html index 410680fe7..bce2ec075 100644 --- a/app/templates/views/templates/template.html +++ b/app/templates/views/templates/template.html @@ -60,21 +60,21 @@

                    - See previous versions + See previous versions
                  {% endif %} {% if current_user.has_permissions('manage_templates') and user_has_template_permission %} {% if not template._template.archived %} - Delete this template + Delete this template   {% endif %} {% if template.template_type != 'letter' %} {% if not template._template.redact_personalisation %} - Hide personalisation after sending + Hide personalisation after sending {% else %}

                  Personalisation is hidden after sending

                  diff --git a/app/templates/views/terms-of-use.html b/app/templates/views/terms-of-use.html index 5109906c8..2974c2734 100644 --- a/app/templates/views/terms-of-use.html +++ b/app/templates/views/terms-of-use.html @@ -20,9 +20,9 @@
                • tell us immediately if you have any security breaches
                • keep your API keys secure
                • get the right levels of consent (to send messages and to use data)
                • -
                • not send unsolicited messages, only ones related to a transaction or something the user has subscribed to be updated about (check the Service Manual if you’re not sure)
                • +
                • not send unsolicited messages, only ones related to a transaction or something the user has subscribed to be updated about (check the Service Manual if you’re not sure)
                • - send messages that meet the GOV.UK Service Manual standards for writing text messages and emails
                • + send messages that meet the GOV.UK Service Manual standards for writing text messages and emails
                • not send messages containing any personally or commercially sensitive information
                • check that the data you add to Notify is accurate and complies with data protection legislation
                @@ -32,14 +32,14 @@
                • send all the messages you pass to us, as long as they meet our guidelines
                • - show how Notify is performing (through our performance and status pages) + show how Notify is performing (through our performance and status pages)
                • -
                • keep your data secure
                • +
                • keep your data secure
                • give you one month’s notice by email if we change our terms of use or delivery providers

                Leaving Notify

                -

                You can leave Notify at any time. Just contact us and we’ll close your account.

                +

                You can leave Notify at any time. Just contact us and we’ll close your account.

                When you leave Notify, all your data will be deleted.

                {% endblock %} diff --git a/app/templates/views/trial-mode.html b/app/templates/views/trial-mode.html index 316bc3b30..a367876c2 100644 --- a/app/templates/views/trial-mode.html +++ b/app/templates/views/trial-mode.html @@ -18,7 +18,7 @@ {% if current_service and current_service.trial_mode %}

                - To remove these restrictions, you can request to go live.

                + To remove these restrictions, you can request to go live.

                {% else %}

                To remove these restrictions: diff --git a/app/templates/views/uploads/choose-file.html b/app/templates/views/uploads/choose-file.html index 3897a6019..897926997 100644 --- a/app/templates/views/uploads/choose-file.html +++ b/app/templates/views/uploads/choose-file.html @@ -33,7 +33,7 @@ )}}

                You can upload a single letter as a PDF.

                -

                Your file must meet our letter specification.

                +

                Your file must meet our letter specification.

                diff --git a/app/templates/views/uploads/preview.html b/app/templates/views/uploads/preview.html index 718cf8c6d..05e70e5a8 100644 --- a/app/templates/views/uploads/preview.html +++ b/app/templates/views/uploads/preview.html @@ -24,7 +24,7 @@ button_text='Upload your file again' ) }} - Back to top + Back to top {% elif current_service.trial_mode %} diff --git a/app/templates/views/usage.html b/app/templates/views/usage.html index 294d25dfd..a91a4814f 100644 --- a/app/templates/views/usage.html +++ b/app/templates/views/usage.html @@ -132,7 +132,7 @@

                What counts as 1 text message?
                - See pricing. + See pricing.

                diff --git a/app/templates/views/using-notify.html b/app/templates/views/using-notify.html index f986accf4..41127b2b6 100644 --- a/app/templates/views/using-notify.html +++ b/app/templates/views/using-notify.html @@ -19,11 +19,11 @@

                Find out more about: