From 3010ae1d9e9e92ce385dd239830dc215a7bb493c Mon Sep 17 00:00:00 2001 From: Beverly Nguyen Date: Thu, 24 Oct 2024 16:28:42 -0700 Subject: [PATCH 1/4] changed guidance to best practices --- ...ite.svg => best-practices-card-sprite.svg} | 0 .../uswds/_uswds-theme-custom-styles.scss | 22 +- app/main/views/index.py | 52 ++--- app/main/views/sub_navigation_dictionaries.py | 6 +- .../{guidance => best-practices}/cards.html | 6 +- .../circle_number.html | 0 .../nav_breadcrumb.html | 4 +- .../best-practices/benchmark-performance.html | 145 +++++++++++++ .../views/best-practices/best-practices.html | 62 ++++++ .../views/best-practices/clear-goals.html | 201 ++++++++++++++++++ .../views/best-practices/establish-trust.html | 190 +++++++++++++++++ .../best-practices/multiple-languages.html | 30 +++ .../best-practices/rules-and-regulations.html | 126 +++++++++++ .../best-practices/write-for-action.html | 106 +++++++++ 14 files changed, 905 insertions(+), 45 deletions(-) rename app/assets/images/{guidance-card-sprite.svg => best-practices-card-sprite.svg} (100%) rename app/templates/components/{guidance => best-practices}/cards.html (85%) rename app/templates/components/{guidance => best-practices}/circle_number.html (100%) rename app/templates/components/{guidance => best-practices}/nav_breadcrumb.html (78%) create mode 100644 app/templates/views/best-practices/benchmark-performance.html create mode 100644 app/templates/views/best-practices/best-practices.html create mode 100644 app/templates/views/best-practices/clear-goals.html create mode 100644 app/templates/views/best-practices/establish-trust.html create mode 100644 app/templates/views/best-practices/multiple-languages.html create mode 100644 app/templates/views/best-practices/rules-and-regulations.html create mode 100644 app/templates/views/best-practices/write-for-action.html diff --git a/app/assets/images/guidance-card-sprite.svg b/app/assets/images/best-practices-card-sprite.svg similarity index 100% rename from app/assets/images/guidance-card-sprite.svg rename to app/assets/images/best-practices-card-sprite.svg diff --git a/app/assets/sass/uswds/_uswds-theme-custom-styles.scss b/app/assets/sass/uswds/_uswds-theme-custom-styles.scss index cd5bb3e58..554a6dfc9 100644 --- a/app/assets/sass/uswds/_uswds-theme-custom-styles.scss +++ b/app/assets/sass/uswds/_uswds-theme-custom-styles.scss @@ -676,28 +676,28 @@ details form { margin-top: 0; } -ol.guidance-list { +ol.best-practices-list { counter-reset: item; list-style-type: none; padding-left: 0; } -ol.guidance-list.set-two { +ol.best-practices-list.set-two { counter-reset: item 6; } -ol.guidance-list.set-three { +ol.best-practices-list.set-three { counter-reset: item 10; } -ol.guidance-list li { +ol.best-practices-list li { counter-increment: item; margin-bottom: 15px; position: relative; padding-left: 40px; } -ol.guidance-list li::before { +ol.best-practices-list li::before { content: counter(item); background-color: #005ea2; color: white; @@ -713,11 +713,11 @@ ol.guidance-list li::before { top: 0; } -li.guidance { +li.best-practices { padding-bottom: 50px; } -div.guidance { +div.best-practices { height: 400px } @@ -820,7 +820,7 @@ $do-dont-top-bar-width: 1; } @media (max-width: 758px) { - .guidance-flex-container { + .best-practices-flex-container { flex-direction: column; } } @@ -838,18 +838,18 @@ li.linked-card:hover > div:first-child:hover { li.linked-card:hover h4, li.linked-card:hover p, li.linked-card:hover svg, -.guidance_card_img:hover{ +.best-practices_card_img:hover{ color: #005ea2; } -.guidance_card_img { +.best-practices_card_img { display: block; width: 50%; height: auto; margin: 0 auto; } -.guidance_link { +.best-practices_link { text-decoration: none; } diff --git a/app/main/views/index.py b/app/main/views/index.py index 79ff2474c..30234fefc 100644 --- a/app/main/views/index.py +++ b/app/main/views/index.py @@ -11,21 +11,21 @@ from app.main import main from app.main.views.pricing import CURRENT_SMS_RATE from app.main.views.sub_navigation_dictionaries import ( features_nav, - guidance_nav, + best_practices_nav, using_notify_nav, ) from app.utils.user import user_is_logged_in from notifications_utils.url_safe_token import generate_token -feature_guidance_enabled = ( - os.getenv("FEATURE_GUIDANCE_ENABLED", "false").lower() == "true" +feature_best_practices_enabled = ( + os.getenv("FEATURE_BEST_PRACTICES_ENABLED", "false").lower() == "true" ) # Hook to check for guidance routes @main.before_request def check_guidance_feature(): - if request.path.startswith("/guidance") and not feature_guidance_enabled: + if request.path.startswith("/best_practices") and not feature_best_practices_enabled: abort(404) @@ -204,66 +204,66 @@ def trial_mode_new(): ) -@main.route("/guidance") +@main.route("/best-practices") @user_is_logged_in -def guidance(): +def best_practices(): return render_template( - "views/guidance/guidance.html", - navigation_links=guidance_nav(), + "views/best-practices/best-practices.html", + navigation_links=best_practices_nav(), ) -@main.route("/guidance/clear-goals") +@main.route("/best-practices/clear-goals") @user_is_logged_in def clear_goals(): return render_template( - "views/guidance/clear-goals.html", - navigation_links=guidance_nav(), + "views/best-practices/clear-goals.html", + navigation_links=best_practices_nav(), ) -@main.route("/guidance/rules-and-regulations") +@main.route("/best-practices/rules-and-regulations") @user_is_logged_in def rules_and_regulations(): return render_template( - "views/guidance/rules-and-regulations.html", - navigation_links=guidance_nav(), + "views/best-practices/rules-and-regulations.html", + navigation_links=best_practices_nav(), ) -@main.route("/guidance/establish-trust") +@main.route("/best-practices/establish-trust") @user_is_logged_in def establish_trust(): return render_template( - "views/guidance/establish-trust.html", - navigation_links=guidance_nav(), + "views/best-practices/establish-trust.html", + navigation_links=best_practices_nav(), ) -@main.route("/guidance/write-for-action") +@main.route("/best-practices/write-for-action") @user_is_logged_in def write_for_action(): return render_template( - "views/guidance/write-for-action.html", - navigation_links=guidance_nav(), + "views/best-practices/write-for-action.html", + navigation_links=best_practices_nav(), ) -@main.route("/guidance/multiple-languages") +@main.route("/best-practices/multiple-languages") @user_is_logged_in def multiple_languages(): return render_template( - "views/guidance/multiple-languages.html", - navigation_links=guidance_nav(), + "views/best-practices/multiple-languages.html", + navigation_links=best_practices_nav(), ) -@main.route("/guidance/benchmark-performance") +@main.route("/best-practices/benchmark-performance") @user_is_logged_in def benchmark_performance(): return render_template( - "views/guidance/benchmark-performance.html", - navigation_links=guidance_nav(), + "views/best-practices/benchmark-performance.html", + navigation_links=best_practices_nav(), ) diff --git a/app/main/views/sub_navigation_dictionaries.py b/app/main/views/sub_navigation_dictionaries.py index c3a2b3dd6..0689c198d 100644 --- a/app/main/views/sub_navigation_dictionaries.py +++ b/app/main/views/sub_navigation_dictionaries.py @@ -60,11 +60,11 @@ def using_notify_nav(): ] -def guidance_nav(): +def best_practices_nav(): return [ { - "name": "Guidance", - "link": "main.guidance", + "name": "Best Practices", + "link": "main.best_practices", }, { "name": "Clear goals", diff --git a/app/templates/components/guidance/cards.html b/app/templates/components/best-practices/cards.html similarity index 85% rename from app/templates/components/guidance/cards.html rename to app/templates/components/best-practices/cards.html index a60889fac..089a8a5a6 100644 --- a/app/templates/components/guidance/cards.html +++ b/app/templates/components/best-practices/cards.html @@ -24,12 +24,12 @@ {% if item.svg_src or item.image_src%}
{% if item.svg_src %} - {{item.card_heading}} image + {{item.card_heading}} image {% endif %}
{% endif %} diff --git a/app/templates/components/guidance/circle_number.html b/app/templates/components/best-practices/circle_number.html similarity index 100% rename from app/templates/components/guidance/circle_number.html rename to app/templates/components/best-practices/circle_number.html diff --git a/app/templates/components/guidance/nav_breadcrumb.html b/app/templates/components/best-practices/nav_breadcrumb.html similarity index 78% rename from app/templates/components/guidance/nav_breadcrumb.html rename to app/templates/components/best-practices/nav_breadcrumb.html index d6cba4cb6..fb5124356 100644 --- a/app/templates/components/guidance/nav_breadcrumb.html +++ b/app/templates/components/best-practices/nav_breadcrumb.html @@ -1,8 +1,8 @@