mirror of
https://github.com/GSA/notifications-admin.git
synced 2026-07-09 19:04:33 -04:00
Clean up code to remove unnecessary paths.
Status code was overcomplex, given how we control the inputs. Now, it expects a single value, rather than a comma separated list, and if you give something it doesn't expect it just returns all. Note, it won't select the correct box - but if you've been manually editing the URL that's your own problem ¯\_(ツ)_/¯ Also, as this page will only ever be shown from the tour (tutorial), it doesn't need some non-help things - such as the download csv button and associated endpoint.
This commit is contained in:
17
app/utils.py
17
app/utils.py
@@ -155,23 +155,6 @@ def generate_notifications_csv(**kwargs):
|
||||
raise Exception("Should never reach here")
|
||||
|
||||
|
||||
def generate_single_notification_csv(notification):
|
||||
fieldnames = ['Recipient', 'Template', 'Type', 'Status', 'Time']
|
||||
yield ','.join(fieldnames) + '\n'
|
||||
|
||||
values = [
|
||||
notification['to'],
|
||||
notification['template']['name'],
|
||||
notification['template']['template_type'],
|
||||
notification['status'],
|
||||
notification['created_at']
|
||||
]
|
||||
line = ','.join(str(i) for i in values) + '\n'
|
||||
yield line
|
||||
|
||||
return
|
||||
|
||||
|
||||
def get_page_from_request():
|
||||
if 'page' in request.args:
|
||||
try:
|
||||
|
||||
Reference in New Issue
Block a user