darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 18:58:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

rename verify to complete in api endpoint

Browse Source 
it was changed in this PR: https://github.com/alphagov/notifications-api/pull/3260
This commit is contained in:
Leo Hemsted
2021-06-03 12:46:31 +01:00
parent 26ad20719f
commit 0993792137
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/notify_client/user_api_client.py
View File

@@ -128,8 +128,7 @@ class UserApiClient(NotifyAdminAPIClient):
@cache.delete('user-{user_id}') @cache.delete('user-{user_id}')
def complete_webauthn_login_attempt(self, user_id, is_successful): def complete_webauthn_login_attempt(self, user_id, is_successful):
data = {'successful': is_successful} data = {'successful': is_successful}
# TODO: Change this to `/complete/webauthn-login` endpoint = f'/user/{user_id}/complete/webauthn-login'
endpoint = f'/user/{user_id}/verify/webauthn-login'
try: try:
self.post(endpoint, data=data) self.post(endpoint, data=data)
return True, '' return True, ''

4
tests/app/notify_client/test_user_client.py
View File

@@ -273,7 +273,7 @@ def test_complete_webauthn_login_attempt_returns_true_and_no_message_normally(fa
resp = user_api_client.complete_webauthn_login_attempt(fake_uuid, is_successful=True) resp = user_api_client.complete_webauthn_login_attempt(fake_uuid, is_successful=True)
expected_data = {'successful': True} expected_data = {'successful': True}
mock_post.assert_called_once_with(f'/user/{fake_uuid}/verify/webauthn-login', data=expected_data) mock_post.assert_called_once_with(f'/user/{fake_uuid}/complete/webauthn-login', data=expected_data)
assert resp == (True, '') assert resp == (True, '')
@@ -293,7 +293,7 @@ def test_complete_webauthn_login_attempt_returns_false_and_message_on_403(fake_u
resp = user_api_client.complete_webauthn_login_attempt(fake_uuid, is_successful=True) resp = user_api_client.complete_webauthn_login_attempt(fake_uuid, is_successful=True)
expected_data = {'successful': True} expected_data = {'successful': True}
mock_post.assert_called_once_with(f'/user/{fake_uuid}/verify/webauthn-login', data=expected_data) mock_post.assert_called_once_with(f'/user/{fake_uuid}/complete/webauthn-login', data=expected_data)
assert resp == (False, 'forbidden') assert resp == (False, 'forbidden')