diff --git a/app/main/views/send.py b/app/main/views/send.py index 4332c7ddb..10f74bb41 100644 --- a/app/main/views/send.py +++ b/app/main/views/send.py @@ -52,12 +52,14 @@ def get_example_csv_fields(column_headers, use_example_as_example, submitted_fie def get_example_csv_rows(template, use_example_as_example=True, submitted_fields=False): return { - "email": ["test@example.com"] - if use_example_as_example - else [current_user.email_address], - "sms": ["12223334444"] - if use_example_as_example - else [current_user.mobile_number], + "email": ( + ["test@example.com"] + if use_example_as_example + else [current_user.email_address] + ), + "sms": ( + ["12223334444"] if use_example_as_example else [current_user.mobile_number] + ), }[template.template_type] + get_example_csv_fields( ( placeholder @@ -511,12 +513,14 @@ def _check_messages(service_id, template_id, upload_id, preview_row): template=template, max_initial_rows_shown=50, max_errors_shown=50, - guestlist=itertools.chain.from_iterable( - [user.name, user.mobile_number, user.email_address] - for user in Users(service_id) - ) - if current_service.trial_mode - else None, + guestlist=( + itertools.chain.from_iterable( + [user.name, user.mobile_number, user.email_address] + for user in Users(service_id) + ) + if current_service.trial_mode + else None + ), remaining_messages=remaining_messages, allow_international_sms=current_service.has_permission("international_sms"), ) @@ -905,13 +909,9 @@ def send_notification(service_id, template_id): return redirect( url_for( - ".view_notification", + ".view_job", service_id=service_id, - from_job=upload_id, - notification_id=notifications["notifications"][0]["id"], - # used to show the final step of the tour (help=3) or not show - # a back link on a just sent one off notification (help=0) - help=request.args.get("help"), + job_id=upload_id, ) ) diff --git a/app/templates/views/notifications/notification.html b/app/templates/views/notifications/notification.html index 5a03daf3d..e5a41d422 100644 --- a/app/templates/views/notifications/notification.html +++ b/app/templates/views/notifications/notification.html @@ -20,19 +20,27 @@ {{ page_header( 1|message_count_label(template.template_type, suffix='') | capitalize ) }} +

{% if help %} -

‘{{ template.name }}’

+ ‘{{ template.name }}’ + {% else %} + ‘{{ template.name }}’ {% endif %} -
-
-

{{ template.name }} - {{ current_service.name }}

-

- Was sent on {{ created_at|format_datetime_short_12h }} by {{ created_by.name }} + was sent + {% if job and job.original_file_name != 'Report' %} + {% set destination = + {'email': 'an email address', 'sms': 'a phone number'} %} + to {{ destination[template.template_type] }} from + {{ job.original_file_name }} + {% elif created_by %} + by {{ created_by.name }} + {% endif %} + {{ created_at|format_datetime_human }}

-
-
- {{ template|string }} +
+ {{ template|string }} +
{% if template.template_type == 'email' %}
diff --git a/tests/app/main/views/test_send.py b/tests/app/main/views/test_send.py index 7448c44cf..c1714c668 100644 --- a/tests/app/main/views/test_send.py +++ b/tests/app/main/views/test_send.py @@ -2056,7 +2056,7 @@ def test_create_job_should_call_api( _expected_status=200, ) - assert original_file_name in page.text + assert "Message status" in page.text mock_create_job.assert_called_with( job_id,