darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 09:29:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

don't log 404s as ERROR

Browse Source
This commit is contained in:
Leo Hemsted
2018-02-12 16:02:33 +00:00
parent 01a2852a69
commit 08fb149b5f
1 changed files with 9 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
app/__init__.py
View File

@@ -430,7 +430,6 @@ def useful_headers_after_request(response):
def register_errorhandlers(application): # noqa (C901 too complex) def register_errorhandlers(application): # noqa (C901 too complex)
def _error_response(error_code): def _error_response(error_code):
application.logger.exception('Admin app errored with %s', error_code)
resp = make_response(render_template("error/{0}.html".format(error_code)), error_code) resp = make_response(render_template("error/{0}.html".format(error_code)), error_code)
return useful_headers_after_request(resp) return useful_headers_after_request(resp)
@@ -469,19 +468,6 @@ def register_errorhandlers(application): # noqa (C901 too complex)
def handle_no_permissions(error): def handle_no_permissions(error):
return _error_response(401) return _error_response(401)
@application.errorhandler(500)
def handle_exception(error):
if current_app.config.get('DEBUG', None):
raise error
return _error_response(500)
@application.errorhandler(Exception)
def handle_bad_request(error):
# We want the Flask in browser stacktrace
if current_app.config.get('DEBUG', None):
raise error
return _error_response(500)
@application.errorhandler(BadSignature) @application.errorhandler(BadSignature)
def handle_bad_token(error): def handle_bad_token(error):
# if someone has a malformed token # if someone has a malformed token
@@ -509,6 +495,15 @@ def register_errorhandlers(application): # noqa (C901 too complex)
), 400) ), 400)
return useful_headers_after_request(resp) return useful_headers_after_request(resp)
@application.errorhandler(500)
@application.errorhandler(Exception)
def handle_bad_request(error):
current_app.logger.exception(error)
# We want the Flask in browser stacktrace
if current_app.config.get('DEBUG', None):
raise error
return _error_response(500)
def setup_event_handlers(): def setup_event_handlers():
from flask_login import user_logged_in from flask_login import user_logged_in