darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

The performance of the inbox page had degraded to the point of failing to load.

Browse Source 
We pin pointed the problem to a bad loop that was calling the format_phone_number_human_readable 216 for 25 rows, yikes.

This PR fixes that performance problem.
This commit is contained in:
Rebecca Law
2018-02-01 13:26:28 +00:00
parent 0d23775a62
commit 07e5e67bd0
1 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/main/views/dashboard.py
View File

@@ -227,15 +227,17 @@ def get_inbox_partials(service_id):
if 'inbound_sms' not in current_service['permissions']: if 'inbound_sms' not in current_service['permissions']:
abort(403) abort(403)
messages_to_show = list()
inbound_messages = service_api_client.get_inbound_sms(service_id) inbound_messages = service_api_client.get_inbound_sms(service_id)
messages_to_show = {}
# get the most recent message for each number
for message in inbound_messages: for message in inbound_messages:
if format_phone_number_human_readable(message['user_number']) not in { human_readable = format_phone_number_human_readable(message['user_number'])
format_phone_number_human_readable(message['user_number']) if human_readable not in messages_to_show:
for message in messages_to_show messages_to_show[human_readable] = message
}:
messages_to_show.append(message) count_of_users = len(messages_to_show)
messages_to_show = reversed(sorted(messages_to_show.values(), key=lambda x: x['created_at']))
if not inbound_messages: if not inbound_messages:
inbound_number = inbound_number_client.get_inbound_sms_number_for_service(service_id)['data']['number'] inbound_number = inbound_number_client.get_inbound_sms_number_for_service(service_id)['data']['number']
@@ -244,9 +246,9 @@ def get_inbox_partials(service_id):
return {'messages': render_template( return {'messages': render_template(
'views/dashboard/_inbox_messages.html', 'views/dashboard/_inbox_messages.html',
messages=messages_to_show, messages=list(messages_to_show),
count_of_messages=len(inbound_messages), count_of_messages=len(inbound_messages),
count_of_users=len(messages_to_show), count_of_users=count_of_users,
inbound_number=inbound_number, inbound_number=inbound_number,
)} )}