diff --git a/app/templates/views/templates/manage-template-folder.html b/app/templates/views/templates/manage-template-folder.html index 2b14dee9f..f2aa3748f 100644 --- a/app/templates/views/templates/manage-template-folder.html +++ b/app/templates/views/templates/manage-template-folder.html @@ -23,6 +23,9 @@ {% call form_wrapper(action=url_for('main.manage_template_folder', service_id=current_service.id, template_folder_id=template_folder_id)) %} {{ textbox(form.name) }} + {% if current_service.has_permission("edit_folder_permissions") %} +
Users who can see this folder:
+ {% endif %} {{ page_footer( 'Save', delete_link=url_for( diff --git a/tests/app/main/views/test_template_folders.py b/tests/app/main/views/test_template_folders.py index 00f22ef34..d59f20e6e 100644 --- a/tests/app/main/views/test_template_folders.py +++ b/tests/app/main/views/test_template_folders.py @@ -415,11 +415,15 @@ def test_can_create_email_template_with_parent_folder( data['parent_folder_id']) +@pytest.mark.parametrize("folder_permissions, expected_len", [(['edit_folder_permissions'], 1), ([], 0)]) def test_get_manage_folder_page( client_request, service_one, mock_get_template_folders, + folder_permissions, + expected_len ): + service_one["permissions"] += folder_permissions folder_id = str(uuid.uuid4()) mock_get_template_folders.return_value = [ {'id': folder_id, 'name': 'folder_two', 'parent_id': None}, @@ -437,9 +441,12 @@ def test_get_manage_folder_page( assert page.select_one('input[name=name]')['value'] == 'folder_two' delete_link = page.find('a', string="Delete this folder") expected_delete_url = "/services/{}/templates/folders/{}/delete".format(service_one['id'], folder_id) - assert expected_delete_url in delete_link["href"] + assert len(page.select('p[id=users-with-permissions]')) == expected_len + if expected_len == 1: + assert page.select('p[id=users-with-permissions]')[0].text == "Users who can see this folder:" + def test_manage_folder_page_404s(client_request, service_one, mock_get_template_folders): client_request.get(