darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 05:29:38 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor loop to separate function and use user model

Browse Source 
when getting a list of security keys

Also test separately that we are correctly choosing key out of list
of security keys. Previously we have done it as a part
of testing pages where where we were calling API to get a list
of keys, but then choosing one of those keys based on id.

Also remove redundant second test credential after PR review

Also remove redundant return value from mocks in update name tests
This commit is contained in:
Pea Tyczynska
2021-05-25 11:15:57 +01:00
parent 8501aa4ad6
commit 04d1d97d4c
2 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/main/views/user_profile.py
View File

@@ -243,6 +243,10 @@ def user_profile_security_keys():
)
def get_key_from_list_of_keys(key_id, list_of_keys):
return next((key for key in list_of_keys if key.id == key_id), None)
@main.route(
"/user-profile/security-keys/<uuid:key_id>/manage",
methods=['GET', 'POST'],
@@ -255,16 +259,16 @@ def user_profile_security_keys():
)
@user_is_platform_admin
def user_profile_manage_security_key(key_id):
security_keys = user_api_client.get_webauthn_credentials_for_user(current_user.id)
security_key = next((key for key in security_keys if key["id"] == key_id), None)
security_keys = current_user.webauthn_credentials
security_key = get_key_from_list_of_keys(key_id, security_keys)
if not security_key:
abort(404)
form = ChangeSecurityKeyNameForm(security_key_name=security_key["name"])
form = ChangeSecurityKeyNameForm(security_key_name=security_key.name)
if form.validate_on_submit():
if form.security_key_name.data != security_key["name"]:
if form.security_key_name.data != security_key.name:
user_api_client.update_webauthn_credential_name_for_user(
user_id=current_user.id,
credential_id=key_id,