darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-18 21:49:37 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix unnecessary call to organisation API endpoint

Browse Source 
We’re caching the organisation name, but still talking to the API
to see if the organisation exists.

`Service().organisation_id` only goes to the JSON for the service.

`Service().organisation` makes a separate API call.

We only need the former to know if a service belongs to an organisation.
This commit is contained in:
Chris Hill-Scott
2020-04-02 15:06:03 +01:00
parent a709ee4a29
commit 047ca8a48c
3 changed files with 54 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/templates/views/service-settings.html
View File

@@ -296,7 +296,7 @@
{% call row() %}
{{ text_field('Live')}}
{% if current_service.trial_mode and not current_service.organisation %}
{% if current_service.trial_mode and not current_service.organisation_id %}
{{ text_field('No (organisation must be set first)') }}
{{ text_field('') }}
{% else %}