darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-05 21:38:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add descriptive links to /service-settings/email-reply-to page

Browse Source 
The links had no descriptive text, so all read 'Change'. This adds
hidden text specific to the item they relate to.
This commit is contained in:
Katie Smith
2021-02-23 14:12:10 +00:00
parent 1f9ea4a72f
commit 0416b841b3
2 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/templates/views/service-settings/email_reply_to.html
View File

@@ -35,7 +35,9 @@
</div> </div>
<div class="govuk-grid-column-one-quarter"> <div class="govuk-grid-column-one-quarter">
{% if current_user.has_permissions('manage_service') %} {% if current_user.has_permissions('manage_service') %}
<a class="govuk-link govuk-link--no-visited-state user-list-edit-link" href="{{ url_for('.service_edit_email_reply_to', service_id =current_service.id, reply_to_email_id = item.id) }}">Change</a> <a class="govuk-link govuk-link--no-visited-state user-list-edit-link"href="{{ url_for('.service_edit_email_reply_to', service_id =current_service.id, reply_to_email_id = item.id) }}">
Change<span class="govuk-visually-hidden"> {{ item.email_address }}</span>
</a>
{% endif %} {% endif %}
</div> </div>
</div> </div>

8
tests/app/main/views/test_service_settings.py
View File

@@ -2190,7 +2190,7 @@ def test_and_more_hint_appears_on_settings_with_more_than_just_a_single_sender(
@pytest.mark.parametrize('sender_list_page, index, expected_output', [ @pytest.mark.parametrize('sender_list_page, index, expected_output', [
('main.service_email_reply_to', 0, 'test@example.com (default) Change'), ('main.service_email_reply_to', 0, 'test@example.com (default) Change test@example.com'),
('main.service_letter_contact_details', 1, '1 Example Street (default) Change'), ('main.service_letter_contact_details', 1, '1 Example Street (default) Change'),
('main.service_sms_senders', 0, 'GOVUK (default) Change') ('main.service_sms_senders', 0, 'GOVUK (default) Change')
]) ])
@@ -2227,9 +2227,9 @@ def test_api_ids_dont_show_on_option_pages_with_a_single_sender(
'app.service_api_client.get_reply_to_email_addresses', 'app.service_api_client.get_reply_to_email_addresses',
create_multiple_email_reply_to_addresses(), create_multiple_email_reply_to_addresses(),
[ [
'test@example.com (default) Change ID: 1234', 'test@example.com (default) Change test@example.com ID: 1234',
'test2@example.com Change ID: 5678', 'test2@example.com Change test2@example.com ID: 5678',
'test3@example.com Change ID: 9457', 'test3@example.com Change test3@example.com ID: 9457',
], ],
), ( ), (
'main.service_letter_contact_details', 'main.service_letter_contact_details',