darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix tests

Browse Source
This commit is contained in:
Kenneth Kehl
2023-11-14 08:38:11 -08:00
parent d1682c641d
commit 040f4b4f9f
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/app/main/views/test_sign_out.py
View File

@@ -1,16 +1,17 @@
from flask import url_for
from tests.conftest import SERVICE_ONE_ID from tests.conftest import SERVICE_ONE_ID
def test_render_sign_out_redirects_to_sign_in(client_request): def test_render_sign_out_redirects_to_sign_in(client_request):
# TODO with the change to using login.gov, we no longer redirect directly to the sign in page.
# Instead we redirect to login.gov which redirects us to the sign in page. However, the
# test for the expected redirect being "/" is buried in conftest and looks fragile.
# After we move to login.gov officially and get rid of other forms of signing it, it should
# be refactored.
with client_request.session_transaction() as session: with client_request.session_transaction() as session:
assert session assert session
client_request.get( client_request.get(
"main.sign_out", "main.sign_out",
_expected_redirect=url_for( _expected_status=302,
"main.index",
),
) )
with client_request.session_transaction() as session: with client_request.session_transaction() as session:
assert not session assert not session
@@ -42,9 +43,6 @@ def test_sign_out_user(
client_request.get( client_request.get(
"main.sign_out", "main.sign_out",
_expected_status=302, _expected_status=302,
_expected_redirect=url_for(
"main.index",
),
) )
with client_request.session_transaction() as session: with client_request.session_transaction() as session:
assert session.get("user_id") is None assert session.get("user_id") is None