darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-06 15:08:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Reorder the methods called in sign out

Browse Source 
We found another scenario where signing out of the db can cause a 500.
If the user archives their trial mode service, current_service.active = false, then signs out, the current user was being signed out client side first, meaning current_user is now an Anonymous user, next the call to the API is made to log out user on db, all calls to NotifyApiClient `check_inactive_service`, which is only authorised if user is platform_admin, but an AnonymousUser does not have that attribute, so a 500 is raise.
Seemed a bit cleaner to change the User.signout method to rather than the `check_inactive_service` method for current_user.is_authenticated.
This commit is contained in:
Rebecca Law
2020-02-05 15:58:15 +00:00
parent a4a6ad04f7
commit 039628cff7
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/user.py
View File

@@ -154,10 +154,10 @@ class User(JSONModel, UserMixin):
return True return True
def sign_out(self): def sign_out(self):
# Update the db so the server also knows the user is logged out.
session.clear() session.clear()
# Update the db so the server also knows the user is logged out.
self.update(current_session_id=None)
logout_user() logout_user()
return self.update(current_session_id=None)
@property @property
def sms_auth(self): def sms_auth(self):