diff --git a/app/main/views/sign_out.py b/app/main/views/sign_out.py index d4add09ea..de0ca58e1 100644 --- a/app/main/views/sign_out.py +++ b/app/main/views/sign_out.py @@ -8,7 +8,6 @@ from app.main import main @main.route('/sign-out', methods=(['GET'])) @login_required def sign_out(): - if session.get('service_name', None): - session.pop('service_name') + session.clear() logout_user() return redirect(url_for('main.index')) diff --git a/tests/app/main/views/test_sign_out.py b/tests/app/main/views/test_sign_out.py index cf7b5a665..1be46f423 100644 --- a/tests/app/main/views/test_sign_out.py +++ b/tests/app/main/views/test_sign_out.py @@ -1,6 +1,4 @@ -from datetime import datetime from flask import url_for -from app.main.dao import users_dao def test_render_sign_out_redirects_to_sign_in(app_): @@ -24,6 +22,8 @@ def test_sign_out_user(app_, email = 'valid@example.gov.uk' password = 'val1dPassw0rd!' with app_.test_client() as client: + with client.session_transaction() as session: + print('session: {}'.format(session)) client.login(api_user_active) # Check we are logged in response = client.get( @@ -33,3 +33,4 @@ def test_sign_out_user(app_, assert response.status_code == 302 assert response.location == url_for( 'main.index', _external=True) + assert session.get('ItsdangerousSession') is None