darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-11 09:28:27 -04:00
Code Issues Packages Projects Releases Wiki Activity

move status mapping logic to the api client

Browse Source 
also added tests 👼
This commit is contained in:
Leo Hemsted
2017-09-20 16:02:15 +01:00
parent f8fab35ee7
commit 03397f416e
4 changed files with 41 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/app/notify_client/test_notification_client.py
View File

@@ -1,6 +1,11 @@
import uuid
import pytest
from app.notify_client.notification_api_client import NotificationApiClient
from tests import single_notification_json, notification_json
@pytest.mark.parametrize("arguments,expected_call", [
(
@@ -55,3 +60,23 @@ def test_get_notification(mocker):
mock_get.assert_called_once_with(
url='/service/foo/notifications/bar'
)
def test_get_api_notifications_changes_letter_statuses(mocker):
service_id = str(uuid.uuid4())
sms_notification = single_notification_json(service_id, notification_type='sms', status='created')
email_notification = single_notification_json(service_id, notification_type='email', status='created')
letter_notification = single_notification_json(service_id, notification_type='letter', status='created')
notis = notification_json(service_id=service_id, rows=0)
notis['notifications'] = [sms_notification, email_notification, letter_notification]
mock_post = mocker.patch('app.notify_client.notification_api_client.NotificationApiClient.get', return_value=notis)
ret = NotificationApiClient().get_api_notifications_for_service(service_id)
assert ret['notifications'][0]['notification_type'] == 'sms'
assert ret['notifications'][1]['notification_type'] == 'email'
assert ret['notifications'][2]['notification_type'] == 'letter'
assert ret['notifications'][0]['status'] == 'created'
assert ret['notifications'][1]['status'] == 'created'
assert ret['notifications'][2]['status'] == 'accepted'