darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-23 07:46:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Flag go live requests from DWP

Browse Source 
It’s not enough to check that they’ve signed the agreement. We have to
make sure we inform them every time a service wants to go live.
This commit is contained in:
Chris Hill-Scott
2019-02-19 10:54:27 +00:00
parent 8986e1db32
commit 032cbf9a17
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/utils.py
View File

@@ -440,6 +440,8 @@ class AgreementInfo:
@property @property
def as_human_readable(self): def as_human_readable(self):
if self.canonical_domain and 'dwp' in self.canonical_domain:
return 'DWP - Requires OED approval'
if self.agreement_signed: if self.agreement_signed:
return 'Yes, on behalf of {}'.format(self.owner) return 'Yes, on behalf of {}'.format(self.owner)
elif self.owner: elif self.owner:

12
tests/app/test_utils.py
View File

@@ -305,6 +305,18 @@ def test_get_valid_agreement_info_known_details(domain_or_email_address):
) )
@pytest.mark.parametrize("domain_or_email_address", (
"test@dwp.gov.uk", "test@dwp.gsi.gov.uk",
))
def test_dwp_go_live_requests_are_flagged(domain_or_email_address):
agreement_info = AgreementInfo(domain_or_email_address)
assert agreement_info.owner == "Department for Work and Pensions"
assert agreement_info.agreement_signed is True
assert agreement_info.as_human_readable == (
'DWP - Requires OED approval'
)
@pytest.mark.parametrize("domain_or_email_address, is_canonical", ( @pytest.mark.parametrize("domain_or_email_address, is_canonical", (
("test@dclgdatamart.co.uk", False), ("test@dclgdatamart.co.uk", False),
("test@communities.gsi.gov.uk", False), ("test@communities.gsi.gov.uk", False),