darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-08-24 00:07:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Changing the labels on the sevice setting page.

Browse Source 
We added `Upload letters` to the platform admin service settings, which makes is confusing when next to `Upload documents`.
Also `User auth type editting` is a confusing label

`User auth type editting` --> `Email authentication`
`Uploading documents` --> `Send file by email`
This commit is contained in:
Rebecca Law
2019-08-06 16:57:40 +01:00
parent 5e39163277
commit 026a01a090
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/main/views/service_settings/test_service_setting_permissions.py
View File

@@ -70,9 +70,9 @@ def test_service_set_permission(
({'restricted': True}, '.service_switch_live', {}, 'Live Off Change'),
({'restricted': False}, '.service_switch_live', {}, 'Live On Change'),
({'permissions': ['upload_document']},
'.service_switch_can_upload_document', {}, 'Uploading documents On Change'),
'.service_switch_can_upload_document', {}, 'Send files by email On Change'),
({'permissions': []},
'.service_switch_can_upload_document', {}, 'Uploading documents Off Change'),
'.service_switch_can_upload_document', {}, 'Send files by email Off Change'),
({'permissions': ['sms']}, '.service_set_inbound_number', {}, 'Receive inbound SMS Off Change'),
({'permissions': ['letter']},
'.service_set_permission', {'permission': 'upload_letters'}, 'Uploading letters Off Change'),

8
tests/app/main/views/test_service_settings.py
View File

@@ -109,8 +109,8 @@ def mock_get_service_settings_page_common(
'Letter branding Not set Change',
'Data retention email Change',
'Receive inbound SMS Off Change',
'User auth type editing Off Change',
'Uploading documents Off Change',
'Email authentication Off Change',
'Send files by email Off Change',
]),
])
def test_should_show_overview(
@@ -3655,7 +3655,7 @@ def test_service_switch_can_upload_document_shows_permission_page_if_service_con
follow_redirects=True
)
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert normalize_spaces(page.h1.text) == 'Uploading documents'
assert normalize_spaces(page.h1.text) == 'Send files by email'
def test_service_switch_can_upload_document_turning_permission_on_with_no_contact_details_shows_form(
@@ -3703,7 +3703,7 @@ def test_service_switch_can_upload_document_lets_contact_details_be_added_and_sh
)
page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
assert normalize_spaces(page.h1.text) == 'Uploading documents'
assert normalize_spaces(page.h1.text) == 'Send files by email'
@pytest.mark.parametrize('user', (