separate urgent and p1 concepts in feedback.

p1 == "should notify team be alerted of this (via pagerduty)"
urgent == "should the user be told we'll look at it"

* If it's in office hours, it's always urgent. It's never a P1 because
  we'll notice it anyway
* If it's outside of office hours, it's urgent and P1 if it's severe,
  otherwise it's neither

app/main/views/feedback.py

@@ -3,7 +3,6 @@ from datetime import datetime
 import pytz
 from flask import abort, redirect, render_template, request, session, url_for
 from flask_login import current_user
-from notifications_utils.clients.zendesk.zendesk_client import ZendeskError
 
 from app import (
     convert_to_boolean,
@@ -77,10 +76,16 @@ def feedback(ticket_type):
     else:
         severe = None
 
-    urgent = (
-        in_business_hours() or
-        (ticket_type == PROBLEM_TICKET_TYPE and severe)
-    )
+    p1 = False
+    urgent = False
+
+    if in_business_hours():
+        # if we're in the office, it's urgent (aka we'll get back in 30 mins)
+        urgent = True
+    elif ticket_type == PROBLEM_TICKET_TYPE and severe:
+        # out of hours, it's only a p1 and it's only urgent if it's a p1
+        urgent = True
+        p1 = True
 
     anonymous = (
         (not form.email_address.data) and
@@ -116,17 +121,14 @@ def feedback(ticket_type):
             form.feedback.data
         )
 
-        try:
-            zendesk_client.create_ticket(
-                subject='Notify feedback {}'.format(user_name),
-                message=feedback_msg,
-                ticket_type=ticket_type,
-                p1=urgent,
-                user_email=user_email,
-                user_name=user_name
-            )
-        except ZendeskError:
-            abort(500, "Feedback submission failed")
+        zendesk_client.create_ticket(
+            subject='Notify feedback',
+            message=feedback_msg,
+            ticket_type=ticket_type,
+            p1=p1,
+            user_email=user_email,
+            user_name=user_name
+        )
         return redirect(url_for('.thanks', urgent=urgent, anonymous=anonymous))
 
     if not form.feedback.data:

app/templates/views/service-settings.html

@@ -336,7 +336,7 @@
         {% endif %}
         <li class="bottom-gutter">
           <a href="{{ url_for('.service_switch_email_auth', service_id=current_service.id) }}" class="button">
-            {{ 'Stop editing user auth' if 'email_auth' in current_service.permissions else 'Allow editing user auth' }}
+            {{ 'Stop user auth type editing' if 'email_auth' in current_service.permissions else 'Allow user auth type editing' }}
           </a>
         </li>
         {% if current_service.active %}