darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-18 05:30:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2208 from alphagov/label-message-type-search

Browse Source 
Label the search box dependent on message type
This commit is contained in:
Chris Hill-Scott
2018-08-09 09:37:01 +01:00
committed by GitHub
parent 4256c56b7a 214bfa9873
commit 015d656d34
3 changed files with 32 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
tests/app/main/views/test_activity.py
View File

@@ -297,13 +297,21 @@ def test_shows_message_when_no_notifications(
@pytest.mark.parametrize((
'initial_query_arguments,'
'form_post_data,'
'expected_search_box_label,'
'expected_search_box_contents'
), [
(
{},
{},
'Search by phone number or email address',
'',
),
(
{
'message_type': 'sms',
},
{},
'Search by phone number',
'',
),
(
@@ -313,6 +321,7 @@ def test_shows_message_when_no_notifications(
{
'to': '+33(0)5-12-34-56-78',
},
'Search by phone number',
'+33(0)5-12-34-56-78',
),
(
@@ -324,6 +333,7 @@ def test_shows_message_when_no_notifications(
{
'to': 'test@example.com',
},
'Search by email address',
'test@example.com',
),
])
@@ -333,6 +343,7 @@ def test_search_recipient_form(
mock_get_service_statistics,
initial_query_arguments,
form_post_data,
expected_search_box_label,
expected_search_box_contents,
):
response = logged_in_client.post(
@@ -351,11 +362,13 @@ def test_search_recipient_form(
url = urlparse(action_url)
assert url.path == '/services/{}/notifications/{}'.format(
SERVICE_ONE_ID,
initial_query_arguments['message_type']
)
initial_query_arguments.get('message_type', '')
).rstrip('/')
query_dict = parse_qs(url.query)
assert query_dict == {}
assert page.select_one('label[for=to]').text.strip() == expected_search_box_label
recipient_inputs = page.select("input[name=to]")
assert(len(recipient_inputs) == 2)