darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-07 16:08:24 -04:00
Code Issues Packages Projects Releases Wiki Activity

Hide ‘Use my email address/phone number link’

Browse Source 
This link is useful for people who are setting up templates and want to
test out how they look/how Notify works.

‘Caseworker’ users shouldn’t need to send themselves messages on a
regular basis, so this link is another thing we can take away.
This commit is contained in:
Chris Hill-Scott
2018-06-14 15:04:01 +01:00
parent 883f51b823
commit 0018ecd765
2 changed files with 25 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/main/views/send.py
View File

@@ -436,7 +436,8 @@ def send_test_step(service_id, template_id, step_index):
request.endpoint == 'main.send_one_off_step' and request.endpoint == 'main.send_one_off_step' and
step_index == 0 and step_index == 0 and
template.template_type != 'letter' and template.template_type != 'letter' and
not (template.template_type == 'sms' and current_user.mobile_number is None) not (template.template_type == 'sms' and current_user.mobile_number is None) and
current_user.has_permissions('view_activity')
): ):
skip_link = ( skip_link = (
'Use my {}'.format(first_column_headings[template.template_type][0]), 'Use my {}'.format(first_column_headings[template.template_type][0]),

31
tests/app/main/views/test_send.py
View File

@@ -1063,14 +1063,29 @@ def test_send_one_off_or_test_has_correct_page_titles(
assert (len(page.select('.banner-tour')) == 1) == tour_shown assert (len(page.select('.banner-tour')) == 1) == tour_shown
@pytest.mark.parametrize('user', ( @pytest.mark.parametrize('user, template_mock, expected_link_text, expected_link_url', [
active_user_with_permissions, (
active_caseworking_user, active_user_with_permissions,
)) mock_get_service_template,
@pytest.mark.parametrize('template_mock, expected_link_text, expected_link_url', [ 'Use my phone number',
(mock_get_service_template, 'Use my phone number', partial(url_for, 'main.send_test')), partial(url_for, 'main.send_test')
(mock_get_service_email_template, 'Use my email address', partial(url_for, 'main.send_test')), ),
(mock_get_service_letter_template, None, None), (
active_user_with_permissions,
mock_get_service_email_template,
'Use my email address',
partial(url_for, 'main.send_test')
),
(
active_user_with_permissions,
mock_get_service_letter_template,
None, None
),
(
active_caseworking_user,
mock_get_service_template,
None, None
),
]) ])
def test_send_one_off_has_skip_link( def test_send_one_off_has_skip_link(
logged_in_client, logged_in_client,