darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-09 09:49:48 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
f3db221fcb275a8b03f8ff5fc09b032ebef5b2c9
notifications-admin/app/templates/views/uploads/contact-list/too-many-columns.html

105 lines
3.8 KiB
HTML
Raw Normal View History

Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
{% extends "withnav_template.html" %}
{% from "components/banner.html" import banner_wrapper %}
{% from "components/radios.html" import radio_select %}
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
{% from "components/file-upload.html" import file_upload %}
{% from "components/back-link/macro.njk" import govukBackLink %}
{% block service_page_title %}
Error
{% endblock %}
Move back link above main content for straightforward cases This moves the back link to be above the `<main>` tag by making use of the new `backLink` block. This doesn't change the pages which are using a back link as part of the `page_header` macro yet.
2021-07-30 14:42:54 +01:00
{% block backLink %}
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
{{ govukBackLink({ "href": url_for('main.upload_contact_list', service_id=current_service.id) }) }}
Move back link above main content for straightforward cases This moves the back link to be above the `<main>` tag by making use of the new `backLink` block. This doesn't change the pages which are using a back link as part of the `page_header` macro yet.
2021-07-30 14:42:54 +01:00
{% endblock %}
{% block maincolumn_content %}
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
<div class="bottom-gutter-1-2">
{% call banner_wrapper(type='dangerous') %}
{% if not recipients|length %}
<h1 class='banner-title' data-module="track-error" data-error-type="No rows" data-error-label="{{ upload_id }}">
Your file is missing some rows
</h1>
Don’t allow paragraphs without class attribute All paragraphs should have class="govuk-body", or be otherwise custom-styled. This commit adds some extra checks to our test fixture that looks for paragraphs that don’t have any styling. Our test coverage is pretty good, so this should check almost all pages, and prevent regressions. I’ve done this in such a way that it can be extended for other elements (e.g. links) in the future.
2020-05-29 17:11:01 +01:00
<p class="govuk-body">
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
It needs at least one row of data
{%- if template_type %}.{% else %}, in a column called ‘email address’ or ‘phone number’.{% endif %}
</p>
{% elif recipients.column_headers|length == 1 %}
<h1 class='banner-title' data-module="track-error" data-error-type="Too many rows" data-error-label="{{ upload_id }}">
Your file needs a column called ‘email address’ or ‘phone number’.
</h1>
Don’t allow paragraphs without class attribute All paragraphs should have class="govuk-body", or be otherwise custom-styled. This commit adds some extra checks to our test fixture that looks for paragraphs that don’t have any styling. Our test coverage is pretty good, so this should check almost all pages, and prevent regressions. I’ve done this in such a way that it can be extended for other elements (e.g. links) in the future.
2020-05-29 17:11:01 +01:00
<p class="govuk-body">
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
Right now it has 1 column called ‘{{ recipients._raw_column_headers[0] }}’.
</p>
{% else %}
<h1 class='banner-title' data-module="track-error" data-error-type="Too many rows" data-error-label="{{ upload_id }}">
Your file has too many columns
</h1>
Don’t allow paragraphs without class attribute All paragraphs should have class="govuk-body", or be otherwise custom-styled. This commit adds some extra checks to our test fixture that looks for paragraphs that don’t have any styling. Our test coverage is pretty good, so this should check almost all pages, and prevent regressions. I’ve done this in such a way that it can be extended for other elements (e.g. links) in the future.
2020-05-29 17:11:01 +01:00
<p class="govuk-body">
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
It needs to have 1 column, called ‘email address’ or ‘phone number’.
</p>
Don’t allow paragraphs without class attribute All paragraphs should have class="govuk-body", or be otherwise custom-styled. This commit adds some extra checks to our test fixture that looks for paragraphs that don’t have any styling. Our test coverage is pretty good, so this should check almost all pages, and prevent regressions. I’ve done this in such a way that it can be extended for other elements (e.g. links) in the future.
2020-05-29 17:11:01 +01:00
<p class="govuk-body">
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
Right now it has {{ recipients._raw_column_headers|length }} columns called {{ recipients._raw_column_headers | formatted_list }}.
</p>
{% endif %}
{% endcall %}
</div>
<div class="js-stick-at-top-when-scrolling">
<div class="form-group">
{{ file_upload(
form.file,
Remove set-to-string conversion from upload code Also changes the allowed_spreadsheet_file_extensions variable to allowed_file_extensions for consistency.
2020-12-17 10:47:52 +00:00
allowed_file_extensions=allowed_file_extensions,
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
action=url_for('.upload_contact_list', service_id=current_service.id),
button_text='Upload your file again'
) }}
</div>
<a href="#content" class="govuk-link govuk-link--no-visited-state back-to-top-link">Back to top</a>
</div>
{% set column_headers = recipients._raw_column_headers if recipients.duplicate_recipient_column_headers else recipients.column_headers %}
Remove unused skip-link from contact list upload pages Since file contents are directly below the header, there is no need for a skip link moving focus to those file contents.
2020-08-18 12:25:47 +01:00
<h2 class="heading-medium" id="file-preview">{{ original_file_name }}</h2>
Let users upload a contact list to use later We increasingly have teams wanting to do business-continuity type messaging. They might be without access to their normal systems, which is where they would otherwise go to get the list of email addresses or phone numbers. So we want to give them a place in Notify where they can store their spreadsheets and use them at a later date. For the initial pass we’re going to scope this to only allowing spreadsheets with one column, ie just phone numbers/email addresses. This is because: - it minimises the amount of personal info we’re storing - it reduces the chance of getting a placeholder error when you go to send the message, which is probably a high-stress situation where you might not be able to re-generate the file The code for this is mostly copied from the existing upload CSV journey. It’s quite duplicative, but that’s what I needed to do to get this out quickly. There are opportunities for refactoring later. Similarly, I would have liked to split this up into better commit messages, but it really was a case of just bashing code out until it worked 😳 This commit does not: - implement the ‘view a contact list page’ (it just has a placeholder because the API isn’t ready at the moment) - link to this page (because it’s not ready to use yet)
2020-03-12 16:13:18 +00:00
<div class="fullscreen-content" data-module="fullscreen-table">
{% call(item, row_number) list_table(
recipients.displayed_rows,
caption=original_file_name,
caption_visible=False,
field_headings=[
'<span class="govuk-visually-hidden">Row in file</span> <span aria-hidden="true">1</span>'|safe
] + recipients._raw_column_headers
) %}
{{ index_field(item.index + 2) }}
{% for column in column_headers %}
{% if item[column].ignore %}
{{ text_field(item[column].data or '', status='default') }}
{% else %}
{{ text_field(item[column].data or '') }}
{% endif %}
{% endfor %}
{% if item[None].data %}
{% for column in item[None].data %}
{{ text_field(column, status='default') }}
{% endfor %}
{% endif %}
{% endcall %}
</div>
{% if recipients.displayed_rows|list|length < recipients|length %}
<p class="table-show-more-link">
Only showing the first {{ recipients.displayed_rows|list|length }} rows
</p>
{% endif %}
{% endblock %}
Reference in New Issue Copy Permalink