darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-09-02 17:48:50 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
f0dd59e75bc4ab2944965a7b52adf8ed5cb4012d
notifications-admin/app/templates/views/dashboard/_totals.html

28 lines
1.3 KiB
HTML
Raw Normal View History

Refactor dashboard templates Previously the structure was ``` dashboard.html |_ today.html |_ some random html |_ a few things split into partials ``` This commit simplifies the structure to just be: ``` dashboard.html |_ partial |_ partial |_ … ```
2016-06-28 08:59:08 +01:00
{% from "components/big-number.html" import big_number_with_status %}
{% from "components/message-count-label.html" import message_count_label %}
Make sure partials always have a wrapping `<div>` The diffDOM Javascript sometimes throws an error if it can’t calculate a diff between the original content of the page and the updated HTML delivered via AJAX. The problem seems to be when there’s not one, consistent top-level element for it to base its calculations on. This commit: - makes sure that all AJAX-delivered partials have a wrapping `<div>` - that this `<div>` has a consistent class name to make it clear why it’s there
2016-09-01 11:06:52 +01:00
<div class="grid-row ajax-block-container">
Add ids for dashboard numbers and stats to be used by the functional tests
2016-10-13 10:52:09 +01:00
<div id="total-email" class="column-half">
Split the JSON responses into one key per section Previously, the AJAX update for the dashboard was returning a big blob of JSON with one key. This commit splits it up to return: - one key for each section of the page - each containing a smaller chunk of HTML rendered from a partial The jobs page was already working this way (pretty much) but just needed a little tweaking to get it the same.
2016-06-28 09:07:04 +01:00
{{ big_number_with_status(
use new detailed service endpoint for dashboard totals we don't want to use the old statistics endpoints any more also a couple of quality of life changes * moves some logic out of the _totals.html template * tidies up statistics_utils
2016-07-19 17:10:48 +01:00
statistics['email']['requested'],
message_count_label(statistics['email']['requested'], 'email', suffix=''),
statistics['email']['failed'],
statistics['email']['failed_percentage'],
statistics['email']['show_warning'],
separate detailed and normal service_api_client.get_service to make it easier to mock and control return values
2016-07-20 11:46:29 +01:00
failure_link=url_for(".view_notifications", service_id=service_id, message_type='email', status='failed'),
link=url_for(".view_notifications", service_id=service_id, message_type='email', status='sending,delivered,failed')
Split the JSON responses into one key per section Previously, the AJAX update for the dashboard was returning a big blob of JSON with one key. This commit splits it up to return: - one key for each section of the page - each containing a smaller chunk of HTML rendered from a partial The jobs page was already working this way (pretty much) but just needed a little tweaking to get it the same.
2016-06-28 09:07:04 +01:00
) }}
</div>
Add ids for dashboard numbers and stats to be used by the functional tests
2016-10-13 10:52:09 +01:00
<div id="total-sms" class="column-half">
Split the JSON responses into one key per section Previously, the AJAX update for the dashboard was returning a big blob of JSON with one key. This commit splits it up to return: - one key for each section of the page - each containing a smaller chunk of HTML rendered from a partial The jobs page was already working this way (pretty much) but just needed a little tweaking to get it the same.
2016-06-28 09:07:04 +01:00
{{ big_number_with_status(
use new detailed service endpoint for dashboard totals we don't want to use the old statistics endpoints any more also a couple of quality of life changes * moves some logic out of the _totals.html template * tidies up statistics_utils
2016-07-19 17:10:48 +01:00
statistics['sms']['requested'],
message_count_label(statistics['sms']['requested'], 'sms', suffix=''),
statistics['sms']['failed'],
statistics['sms']['failed_percentage'],
statistics['sms']['show_warning'],
failure_link=url_for(".view_notifications", service_id=service_id, message_type='sms', status='failed'),
link=url_for(".view_notifications", service_id=service_id, message_type='sms', status='sending,delivered,failed')
Split the JSON responses into one key per section Previously, the AJAX update for the dashboard was returning a big blob of JSON with one key. This commit splits it up to return: - one key for each section of the page - each containing a smaller chunk of HTML rendered from a partial The jobs page was already working this way (pretty much) but just needed a little tweaking to get it the same.
2016-06-28 09:07:04 +01:00
) }}
</div>
Refactor dashboard templates Previously the structure was ``` dashboard.html |_ today.html |_ some random html |_ a few things split into partials ``` This commit simplifies the structure to just be: ``` dashboard.html |_ partial |_ partial |_ … ```
2016-06-28 08:59:08 +01:00
</div>
Reference in New Issue Copy Permalink