darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-06-02 12:30:48 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
e6f49825e5fdfd798ca2f2622f12342dfd15dbf8
notifications-admin/app/templates/components/radios.html

64 lines
2.1 KiB
HTML
Raw Normal View History

Display nested folders permissions form on user permissions page We're reusing the logic for the `move_to` nested radios field for the user folder permissions nested checkboxes. The main difference between the two forms (aside from the different input type) is that "Move" form contains the root "Templates" as an option, whereas the folder permissions doesn't. It turns out that, because of the way NestedFieldMixin.children and select_nested macro are implemented the easiest way to get the desired folder permissions behaviour is to add the root folder as a choice with a `None` value and `NONE_OPTION_VALUE = None` set on the field, which allows the `child_map` to be constructed but doesn't display the root folder checkbox itself since it gets overwritten in the final `child_map`.
2019-02-25 16:23:28 +00:00
{% from "components/select-input.html" import select, select_list, select_nested, select_wrapper, select_input %}
Make radio form components reusable for nested checkboxes For the template folders permission editing we need a nested checkboxes form that is similar to "move folder" input, except it's using checkboxes instead of radio buttons. This moves most of the macros into a shared "select-input" components file, which are wrapped by the existing radios.html by setting the required input type.
2019-02-25 14:55:26 +00:00
Change radio buttons to inline Adds ability to have inline radio buttons using the fieldset.inline functionality from gov.uk elements. Then implements this for the radio buttons for choosing postage class. Also overrides the gov uk elements styling for the inline radio buttons to place them slightly closer together as this looks better.
2019-10-09 16:16:22 +01:00
{% macro radios(field, hint=None, disable=[], option_hints={}, hide_legend=False, inline=False) %}
{{ select(field, hint, disable, option_hints, hide_legend, input="radio", inline=inline) }}
Refactor radios for reuse This commit splits up the radio buttons macro into a couple of different macros which can be used independently of each other. This makes this code easier to reuse when implementing custom radio controls.
2018-06-12 13:17:45 +01:00
{% endmacro %}
Display the template folders nested on the move template/folder form Before, all the folders were displayed in a list which was ordered but not nested. This changes the move form to nest the template folders.
2018-12-18 14:40:53 +00:00
Make radio form components reusable for nested checkboxes For the template folders permission editing we need a nested checkboxes form that is similar to "move folder" input, except it's using checkboxes instead of radio buttons. This moves most of the macros into a shared "select-input" components file, which are wrapped by the existing radios.html by setting the required input type.
2019-02-25 14:55:26 +00:00
{% macro radio_list(options, child_map, disable=[], option_hints={}) %}
Display nested folders permissions form on user permissions page We're reusing the logic for the `move_to` nested radios field for the user folder permissions nested checkboxes. The main difference between the two forms (aside from the different input type) is that "Move" form contains the root "Templates" as an option, whereas the folder permissions doesn't. It turns out that, because of the way NestedFieldMixin.children and select_nested macro are implemented the easiest way to get the desired folder permissions behaviour is to add the root folder as a choice with a `None` value and `NONE_OPTION_VALUE = None` set on the field, which allows the `child_map` to be constructed but doesn't display the root folder checkbox itself since it gets overwritten in the final `child_map`.
2019-02-25 16:23:28 +00:00
{{ select_list(options, child_map, disable, option_hints, input="radio") }}
Display the template folders nested on the move template/folder form Before, all the folders were displayed in a list which was ordered but not nested. This changes the move form to nest the template folders.
2018-12-18 14:40:53 +00:00
{% endmacro %}
Make radio form components reusable for nested checkboxes For the template folders permission editing we need a nested checkboxes form that is similar to "move folder" input, except it's using checkboxes instead of radio buttons. This moves most of the macros into a shared "select-input" components file, which are wrapped by the existing radios.html by setting the required input type.
2019-02-25 14:55:26 +00:00
{% macro radios_nested(field, child_map, hint=None, disable=[], option_hints={}, hide_legend=False) %}
Display nested folders permissions form on user permissions page We're reusing the logic for the `move_to` nested radios field for the user folder permissions nested checkboxes. The main difference between the two forms (aside from the different input type) is that "Move" form contains the root "Templates" as an option, whereas the folder permissions doesn't. It turns out that, because of the way NestedFieldMixin.children and select_nested macro are implemented the easiest way to get the desired folder permissions behaviour is to add the root folder as a choice with a `None` value and `NONE_OPTION_VALUE = None` set on the field, which allows the `child_map` to be constructed but doesn't display the root folder checkbox itself since it gets overwritten in the final `child_map`.
2019-02-25 16:23:28 +00:00
{{ select_nested(field, child_map, hint, disable, option_hints, hide_legend, input="radio") }}
Add radio buttons for choosing the API key type Best-guess wording for what the labels and question should be. Adds a macro for rendering radio buttons from a WTForms field.
2016-06-29 17:10:49 +01:00
{% endmacro %}
Add a page to set organisation and branding option Platform admin only. Adds radio buttons to choose one of: - three hard-coded branding options - organisations from a list provided by the API
2016-08-08 10:28:40 +01:00
Make radio form components reusable for nested checkboxes For the template folders permission editing we need a nested checkboxes form that is similar to "move folder" input, except it's using checkboxes instead of radio buttons. This moves most of the macros into a shared "select-input" components file, which are wrapped by the existing radios.html by setting the required input type.
2019-02-25 14:55:26 +00:00
Display the template folders nested on the move template/folder form Before, all the folders were displayed in a list which was ordered but not nested. This changes the move form to nest the template folders.
2018-12-18 14:40:53 +00:00
{% macro radio(option, disable=[], option_hints={}, data_target=None, as_list_item=False) %}
Display nested folders permissions form on user permissions page We're reusing the logic for the `move_to` nested radios field for the user folder permissions nested checkboxes. The main difference between the two forms (aside from the different input type) is that "Move" form contains the root "Templates" as an option, whereas the folder permissions doesn't. It turns out that, because of the way NestedFieldMixin.children and select_nested macro are implemented the easiest way to get the desired folder permissions behaviour is to add the root folder as a choice with a `None` value and `NONE_OPTION_VALUE = None` set on the field, which allows the `child_map` to be constructed but doesn't display the root folder checkbox itself since it gets overwritten in the final `child_map`.
2019-02-25 16:23:28 +00:00
{{ select_input(option, disable, option_hints, data_target, as_list_item, input="radio") }}
Add page where users can say they want branding At the moment branding is an undocumented feature. We get a bunch of support tickets from teams asking its possible. This commit: - lets people know it’s possible, and what the options are - is the first step towards making this process as self-service as possible In some cases we will be able to infer a user’s organisation from there email address, and Google image search their logo. So the experience for them is that they press a button and government just sorts it out for you (also known as "the dream"). In other cases we will have to get back to people asking for a copy of their logo, or to find out about their service, but this is what we have to do at the moment anyway.
2018-05-18 14:05:48 +01:00
{% endmacro %}
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
{% macro radio_select(
field,
hint=None,
wrapping_class='form-group'
) %}
Change class names for validation errors in html Implements the class name changes detailed in: https://github.com/alphagov/govuk_elements/pull/405
2017-04-10 11:16:22 +01:00
<div class="{{ wrapping_class }} {% if field.errors %} form-group-error{% endif %}">
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
<fieldset>
<legend class="form-label">
Fix duplicate labels on form inputs It’s invalid HTML to have multiple labels nested within each other. This was happening by accident because WTForms tries to be clever – when you put `{{ field.label }}` in a template it prints a `<label>` tag for you, not just the text of the label. But we put our own `<label>` tags in the HTML to have more control of them. This commit stops WTForms being so clever.
2017-02-13 09:50:26 +00:00
{{ field.label.text }}
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
{% if field.errors %}
Track form validation errors in Google analytics We started tracking upload errors in eb264f34b766d92ce79cb116b6093698de593caf This has been useful. This commit adds tracking of other form validation errors, so we can pick up if there’s a form field that’s causing people particular trouble. Also had to rewrite a very old test to look for page content in a smarter way.
2017-10-16 14:58:08 +01:00
<span class="error-message" data-module="track-error" data-error-type="{{ field.errors[0] }}" data-error-label="{{ field.name }}">
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
{{ field.errors[0] }}
</span>
{% endif %}
</legend>
Group choices for scheduling a job by day The options for scheduling a job by time should be grouped by day, because a long list of 96 options is not very usable. On the server side, this commit generates label for the next 4 days in a friendly format (ie today/tomorrow/Sunday/Monday) The Javascript component for choosing a time was built in a kind of old-school jQuery way, where it manipulated the elements on the page. The complexity of introducing groups of options was just too much for this pattern, because it involves storing a lot of state in the DOM. This commit completely rewrites the JS to: - read the initial options and groups from the HTML and store them in the object - use Hogan to completely re-render the UI from a series of Mustache templates, each of which represents a state of the UI and takes the inital options and groups - filter the choices to show when the today/tomorrow/… buttons are clicked
2016-10-11 14:17:29 +01:00
<div class="radio-select" data-module="radio-select" data-categories="{{ field.categories|join(',') }}">
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
<div class="radio-select-column">
{% for option in field %}
Make radio select work w/ new checkboxes/radios The visual appearance of radio and checkbox form inputs changed in GOV.UK Elements here: https://github.com/alphagov/govuk_elements/pull/296 This was subsequently reimplemented with different markup and no Javascript here: https://github.com/alphagov/govuk_elements/pull/406 This has meant making the following changes to our app: - changing the markup in our radio/checkbox macros to match the example markup given by GOV.UK Elements - removing the previous Javascript file because it’s no longer needed to make the radios appear visual selected - making the buttons on the scheduled job picker look like links, because the grey button style looked weird with the new radio buttons
2016-12-19 10:36:17 +00:00
<div class="multiple-choice">
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
{{ option }}
Make radio select work w/ new checkboxes/radios The visual appearance of radio and checkbox form inputs changed in GOV.UK Elements here: https://github.com/alphagov/govuk_elements/pull/296 This was subsequently reimplemented with different markup and no Javascript here: https://github.com/alphagov/govuk_elements/pull/406 This has meant making the following changes to our app: - changing the markup in our radio/checkbox macros to match the example markup given by GOV.UK Elements - removing the previous Javascript file because it’s no longer needed to make the radios appear visual selected - making the buttons on the scheduled job picker look like links, because the grey button style looked weird with the new radio buttons
2016-12-19 10:36:17 +00:00
<label for="{{ option.id }}">
{{ option.label.text }}
</label>
</div>
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
{% if loop.first %}
</div>
<div class="radio-select-column">
{% endif %}
{% endfor %}
</div>
</div>
</fieldset>
</div>
{% endmacro %}
Allow setting of caseworking on a user This commit changes the form that the user sees when inviting or editing another user, if the service has the ‘caseworking’ permission set. This will allow creating a new type of user, one who only has the `send_messages` permission, without the `view_activity` permission. We are doing this because we think there are a number of services with a lot of users who don’t need to see the dashboard, or the other team members, and that we can make a simpler interface for these users.
2018-06-12 14:29:47 +01:00
{% macro conditional_radio_panel(id) %}
Let GPs nominate service name Most GP practice services are named after the practice, which is the organisation. So rather than make people re-type the name of their organisation (and potentially make a typo) let’s just let them say ‘yes, that’s the name of my organisation’.
2019-09-05 12:10:24 +01:00
<div class="conditional-radios-panel js-hidden" id="{{ id }}">
Allow setting of caseworking on a user This commit changes the form that the user sees when inviting or editing another user, if the service has the ‘caseworking’ permission set. This will allow creating a new type of user, one who only has the `send_messages` permission, without the `view_activity` permission. We are doing this because we think there are a number of services with a lot of users who don’t need to see the dashboard, or the other team members, and that we can make a simpler interface for these users.
2018-06-12 14:29:47 +01:00
{{ caller() }}
</div>
{% endmacro %}
Reference in New Issue Copy Permalink