tests/app/notify_client/test_job_client.py

from app.notify_client.job_api_client import JobApiClient


def test_client_creates_job_data_correctly(mocker, fake_uuid):
    job_id = fake_uuid
    service_id = fake_uuid
    template_id = fake_uuid
    original_file_name = 'test.csv'
    notification_count = 1
    mocker.patch('app.notify_client.current_user', id='1')

    expected_data = {
        "id": job_id,
        "template": template_id,
        "original_file_name": original_file_name,
        "notification_count": 1,
        "created_by": '1'
    }

    expected_url = '/service/{}/job'.format(service_id)

    client = JobApiClient()
    mock_post = mocker.patch('app.notify_client.job_api_client.JobApiClient.post')

    client.create_job(job_id, service_id, template_id, original_file_name, notification_count)

    mock_post.assert_called_once_with(url=expected_url, data=expected_data)
Service and job id were incorrectly in bucket name. 2016-02-04 12:06:06 +00:00			`from app.notify_client.job_api_client import JobApiClient`


Add created_by to all appropriate requests. 2016-04-15 11:08:19 +01:00			`def test_client_creates_job_data_correctly(mocker, fake_uuid):`
			`job_id = fake_uuid`
			`service_id = fake_uuid`
			`template_id = fake_uuid`
Service and job id were incorrectly in bucket name. 2016-02-04 12:06:06 +00:00			`original_file_name = 'test.csv'`
Add count of rows in csv file as a notification count. 2016-02-22 14:52:16 +00:00			`notification_count = 1`
Make `_attach_current_user` a pure function Mutating dictionaries is gross and doesn’t work as you’d expect. Better to have the function return a new dictionary instead. Means we can be explicit that `created_by` is one of the allowed params when updating a service. 2016-08-11 14:20:43 +01:00			`mocker.patch('app.notify_client.current_user', id='1')`
Service and job id were incorrectly in bucket name. 2016-02-04 12:06:06 +00:00
			`expected_data = {`
			`"id": job_id,`
			`"template": template_id,`
			`"original_file_name": original_file_name,`
Make `_attach_current_user` a pure function Mutating dictionaries is gross and doesn’t work as you’d expect. Better to have the function return a new dictionary instead. Means we can be explicit that `created_by` is one of the allowed params when updating a service. 2016-08-11 14:20:43 +01:00			`"notification_count": 1,`
			`"created_by": '1'`
Service and job id were incorrectly in bucket name. 2016-02-04 12:06:06 +00:00			`}`

			`expected_url = '/service/{}/job'.format(service_id)`

			`client = JobApiClient()`
			`mock_post = mocker.patch('app.notify_client.job_api_client.JobApiClient.post')`

Add count of rows in csv file as a notification count. 2016-02-22 14:52:16 +00:00			`client.create_job(job_id, service_id, template_id, original_file_name, notification_count)`
Service and job id were incorrectly in bucket name. 2016-02-04 12:06:06 +00:00
			`mock_post.assert_called_once_with(url=expected_url, data=expected_data)`