app/templates/views/providers/edit-provider.html

{% extends "withoutnav_template.html" %}
{% from "components/page-header.html" import page_header %}
{% from "components/page-footer.html" import page_footer %}
{% from "components/form.html" import form_wrapper %}
{% from "components/back-link/macro.njk" import govukBackLink %}

{% block per_page_title %}
  {{provider.display_name}}
{% endblock %}

{% block backLink %}
  {{ govukBackLink({ "href": url_for('.view_providers') }) }}
{% endblock %}

{% block maincolumn_content %}

<div class="govuk-grid-row">
    <div class="govuk-grid-column-three-quarters">

        {{ page_header(provider.display_name) }}

        <p class="govuk-body">Update provider:</p>

        <ul class="list-bullet">
            <li>We only send from the highest priority provider</li>
        </ul>

        {% call form_wrapper() %}
            {{ form.priority }}
            {{ page_footer('Save') }}
        {% endcall %}

    </div>

</div>

{% endblock %}
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00			`{% extends "withoutnav_template.html" %}`
Add GOV.UK Design System style back links The Design System has standardised on back links being at the top of the page, decorated with a small text-coloured arrow. I think this makes more sense than having them at the bottom, because it suggests, in some way, being able to go back before commiting to any of the forms on the page. Whereas the things at the bottom of the page should be performing actions on what’s in the page. The reason for making this change now is that it de-clutters the area around the green buttons. This was presenting a design challenge where multiple levels of interaction were happening in the same form. Moving these back links to the top of the page should mean that, in these complicated forms, there’s one fewer thing to compete for the user’s attention. I’ve componentised this into a `page_header` macro so that the change is easier to roll out and maintain. 2019-04-29 11:44:05 +01:00			`{% from "components/page-header.html" import page_header %}`
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00			`{% from "components/page-footer.html" import page_footer %}`
Use a macro for form tags This will stop us repeatedly forgetting to add `novalidate` and `autocomplete='off'` to our forms (which is how most of them are set up). It uses sensible defaults, based on how we most-commonly configure forms: - most of our forms are `post`ed (but this can be overridden) - `autocomplete` should only be enabled where it makes sense, otherwise it’s more annoying than useful (but this can be overriden) - we should never be using HTML5 form validation because our own error styles and messages are better 2018-09-19 12:39:36 +01:00			`{% from "components/form.html" import form_wrapper %}`
Move back link outside of main where it was used in the page header The page_header macro includes an optional back link. Since the page_header is always used inside `<main>`, where the back link should not be, this stops setting the back link in the page header and instead sets it in the new `backLink` block. 2021-07-30 18:23:12 +01:00			`{% from "components/back-link/macro.njk" import govukBackLink %}`
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00
Include service name in page `<title>` In pages specific to a service (e.g. dashboard and sub pages) the title needs to distinguish which service it applies to. This is mainly to give context to screen reader users who could be managing multiple services. Implementing this uses template inheritance: `page_title` includes `per_page_title` includes `service_page_title` ‘GOV.UK Notify’ is inserted into every page title. Pages that set `service_page_title` get the service name inserted too. 2017-02-13 10:45:15 +00:00			`{% block per_page_title %}`
Replace instances of `client.login` with `client_request` We have a `client_request` fixture which does a bunch of useful stuff like: - checking the status code of the response - returning a `BeautifulSoup` object Lots of our tests still use an older fixture called `client`. This is not as good because it: - returns a raw `Response` object - doesn’t do the additional checks - means our tests contain a lot of repetetive boilerplate like `page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')` This commit converts all the tests which had a `client.login(…)` statement to use `client_request` (which is already logged in by default). Subsequent commits will remove uses of `client` in other tests, but doing it this way means the work can be broken up into more manageable chunks. 2022-01-04 10:56:25 +00:00			`{{provider.display_name}}`
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00			`{% endblock %}`

Move back link outside of main where it was used in the page header The page_header macro includes an optional back link. Since the page_header is always used inside `<main>`, where the back link should not be, this stops setting the back link in the page header and instead sets it in the new `backLink` block. 2021-07-30 18:23:12 +01:00			`{% block backLink %}`
			`{{ govukBackLink({ "href": url_for('.view_providers') }) }}`
			`{% endblock %}`

Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00			`{% block maincolumn_content %}`

Replace `grid-row` with `govuk-grid-row` Replaced all instances of `grid-row` in the HTML and JavaScript with `govuk-grid-row`, which is the new GOV.UK Frontend class. 2020-02-19 11:57:15 +00:00			`<div class="govuk-grid-row">`
Replace the `.column-...` classes in _grids.scss We had 7 classes in _grids.scss named `.column-...` which were being used to give a certain column width. These worked by using `@include grid column()`, which is now deprecated. `.column-whole` and `.column-three-quarters` can be removed and replaced with `govuk-grid-column-full` and `govuk-grid-column-three-quarters` respectively. The other column classes don't have a direct replacment in GOV.UK Frontend. To get round this, we overwrite the `$govuk-grid-width` SASS map in `extensions.scss` to add in extra widths, then use this with the `govuk-grid-column` mixin to create new classes in for our custom widths in `_grids.scss` 2020-02-20 16:55:56 +00:00			`<div class="govuk-grid-column-three-quarters">`
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00
Move back link outside of main where it was used in the page header The page_header macro includes an optional back link. Since the page_header is always used inside `<main>`, where the back link should not be, this stops setting the back link in the page header and instead sets it in the new `backLink` block. 2021-07-30 18:23:12 +01:00			`{{ page_header(provider.display_name) }}`
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00
Don’t allow paragraphs without class attribute All paragraphs should have class="govuk-body", or be otherwise custom-styled. This commit adds some extra checks to our test fixture that looks for paragraphs that don’t have any styling. Our test coverage is pretty good, so this should check almost all pages, and prevent regressions. I’ve done this in such a way that it can be extended for other elements (e.g. links) in the future. 2020-05-29 17:11:01 +01:00			`<p class="govuk-body">Update provider:</p>`
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00
			`<ul class="list-bullet">`
			`<li>We only send from the highest priority provider</li>`
			`</ul>`

Use a macro for form tags This will stop us repeatedly forgetting to add `novalidate` and `autocomplete='off'` to our forms (which is how most of them are set up). It uses sensible defaults, based on how we most-commonly configure forms: - most of our forms are `post`ed (but this can be overridden) - `autocomplete` should only be enabled where it makes sense, otherwise it’s more annoying than useful (but this can be overriden) - we should never be using HTML5 form validation because our own error styles and messages are better 2018-09-19 12:39:36 +01:00			`{% call form_wrapper() %}`
Convert IntegerFields to GovukIntegerFields Changes those fields in the following forms: - FreeSMSAllowance - ProviderForm - ProviderRatioForm - ServiceDataRetentionEditForm Includes changes to templates that use this form and associated tests. 2020-08-07 10:31:09 +01:00			`{{ form.priority }}`
Add GOV.UK Design System style back links The Design System has standardised on back links being at the top of the page, decorated with a small text-coloured arrow. I think this makes more sense than having them at the bottom, because it suggests, in some way, being able to go back before commiting to any of the forms on the page. Whereas the things at the bottom of the page should be performing actions on what’s in the page. The reason for making this change now is that it de-clutters the area around the green buttons. This was presenting a design challenge where multiple levels of interaction were happening in the same form. Moving these back links to the top of the page should mean that, in these complicated forms, there’s one fewer thing to compete for the user’s attention. I’ve componentised this into a `page_header` macro so that the change is easier to roll out and maintain. 2019-04-29 11:44:05 +01:00			`{{ page_footer('Save') }}`
Use a macro for form tags This will stop us repeatedly forgetting to add `novalidate` and `autocomplete='off'` to our forms (which is how most of them are set up). It uses sensible defaults, based on how we most-commonly configure forms: - most of our forms are `post`ed (but this can be overridden) - `autocomplete` should only be enabled where it makes sense, otherwise it’s more annoying than useful (but this can be overriden) - we should never be using HTML5 form validation because our own error styles and messages are better 2018-09-19 12:39:36 +01:00			`{% endcall %}`
Added provider management pages in. - see priority - change priority 2016-05-11 09:43:55 +01:00
			`</div>`

			`</div>`

			`{% endblock %}`