setup.cfg

[tool:pytest]
norecursedirs=node_modules bower_components
xfail_strict=true

[isort]
line_length=80
indent='    '
multi_line_output=3
known_third_party=notifications_utils,notifications_python_client
known_first_party=app,tests
include_trailing_comma=True
use_parentheses=True
bump test requirements to most recent 2016-09-09 16:29:30 +01:00			`[tool:pytest]`
define isort first party (app and tests) we were seeing isort produce different outputs locally and in docker - this was due to it having different opinions about whether the tests module (ie all our unit tests) is a first party (local) or third party (pip installed) import. It's a first party import, so by defining this in the setup.cfg isort settings, we can force it to be consistent between environments. Note: I don't know why it was different in the first place though 2018-04-25 14:12:58 +01:00			`norecursedirs=node_modules bower_components`
make xfail passes (unexpected passes) fail test runs 2017-02-23 16:36:16 +00:00			`xfail_strict=true`
Enforce order and style of imports Done using isort[1], with the following command: ``` isort -rc ./app ./tests ``` Adds linting to the `run_tests.sh` script to stop badly-sorted imports getting re-introduced. Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because I think it gives the cleanest diffs, eg: ``` from third_party import ( lib1, lib2, lib3, lib4, ) ``` 1. https://pypi.python.org/pypi/isort 2018-02-20 11:22:17 +00:00
			`[isort]`
			`line_length=80`
			`indent=' '`
			`multi_line_output=3`
define isort first party (app and tests) we were seeing isort produce different outputs locally and in docker - this was due to it having different opinions about whether the tests module (ie all our unit tests) is a first party (local) or third party (pip installed) import. It's a first party import, so by defining this in the setup.cfg isort settings, we can force it to be consistent between environments. Note: I don't know why it was different in the first place though 2018-04-25 14:12:58 +01:00			`known_third_party=notifications_utils,notifications_python_client`
			`known_first_party=app,tests`
			`include_trailing_comma=True`
Update isort config to match that in API As discussed in [1]. This has no effect on the existing imports. [1]: https://github.com/alphagov/notifications-api/pull/3175#issuecomment-795530323 2021-03-12 12:11:50 +00:00			`use_parentheses=True`