requirements_for_test.txt

-r requirements.txt
isort==5.9.3
pytest==6.2.5
pytest-env==0.6.2
pytest-mock==3.6.1
pytest-xdist==2.4.0
beautifulsoup4==4.10.0
freezegun==1.1.0
flake8==4.0.1
flake8-bugbear==21.9.2
flake8-print==4.0.0
moto==3.0.4
requests-mock==1.9.3
# used for creating manifest file locally
jinja2-cli[yaml]==0.7.0
Stop locking non-test dependencies twice Currently we have a situation where we're not running tests against new versions of dependencies, as requirements_for_test.txt is not being kept in-sync with requirements.txt by pyup. Deploys are only working because Concourse silently ignores version issues. From a deployment log: awscli 1.18.211 has requirement PyYAML<5.4,>=3.10; python_version != "3.4", but you'll have pyyaml 5.4 which is incompatible. This switches to a single requirements file for test dependencies, in order to keep it in-sync with requirements.txt i.e. we run our tests against the same versions of dependencies that we deploy with, and the build fails if we try to use package versions that are not mutually compatible, as this example PR shows [1]. ERROR: Cannot install -r requirements_for_test.txt (line 17), -r requirements_for_test.txt (line 198) and pyyaml==5.4.1 because these package versions have conflicting dependencies. We shouldn't need to have fine-grained locking on test dependencies, beyond those we want to list manually in the file. [1]: https://github.com/alphagov/notifications-admin/pull/3804 2021-02-16 17:08:03 +00:00			`-r requirements.txt`
Update isort from 5.8.0 to 5.9.3 2021-10-11 14:56:08 +01:00			`isort==5.9.3`
Update pytest from 6.2.4 to 6.2.5 2021-10-11 14:56:08 +01:00			`pytest==6.2.5`
Update requirements - install patch for jinja2 vulnerability 2021-02-02 17:13:18 +00:00			`pytest-env==0.6.2`
Update pytest-mock from 3.5.1 to 3.6.1 2021-05-31 14:54:11 +01:00			`pytest-mock==3.6.1`
Update pytest-xdist from 2.2.1 to 2.4.0 2021-10-11 14:56:09 +01:00			`pytest-xdist==2.4.0`
Update beautifulsoup4 from 4.9.3 to 4.10.0 2021-10-11 14:56:09 +01:00			`beautifulsoup4==4.10.0`
Update freezegun from 0.3.12 to 1.1.0 2021-03-08 13:55:06 +00:00			`freezegun==1.1.0`
Update flake8 from 3.9.2 to 4.0.1 2021-10-11 14:56:10 +01:00			`flake8==4.0.1`
Update flake8-bugbear from 21.4.3 to 21.9.2 2021-10-11 14:56:10 +01:00			`flake8-bugbear==21.9.2`
Update flake8-print from 3.1.4 to 4.0.0 2021-03-08 13:55:08 +00:00			`flake8-print==4.0.0`
Catch error if letter does not exist on send This repeats the pattern we already have for previewing a letter, where we assume the error is because the notification has already been sent and redirect the user to see it. I've improved the original pattern a bit: - I've DRYed-up the low-level boto code and moved the error handler there so it can be reused. - I've introduced a custom exception, which the calling code can choose to log. - I've introduced the moto library, which we use elsewhere, to make it easier to test S3 code. I've used an error level log when sending a notification - now that we have a more descriptive log, we can verify the assumption is true and then make an informed decision to downgrade the log. In future we may want to merge this handler with the similar code in utils [1], but we'll need to be careful as the utils handler is superficial - it doesn't check the reason for the error. [1]: https://github.com/alphagov/notifications-utils/blob/bce0f4e596af9451212d0026c8ecc27b636eed38/notifications_utils/s3.py#L52 2022-02-18 14:37:09 +00:00			`moto==3.0.4`
Update requests-mock from 1.8.0 to 1.9.3 2021-05-31 14:54:12 +01:00			`requests-mock==1.9.3`
Stop locking non-test dependencies twice Currently we have a situation where we're not running tests against new versions of dependencies, as requirements_for_test.txt is not being kept in-sync with requirements.txt by pyup. Deploys are only working because Concourse silently ignores version issues. From a deployment log: awscli 1.18.211 has requirement PyYAML<5.4,>=3.10; python_version != "3.4", but you'll have pyyaml 5.4 which is incompatible. This switches to a single requirements file for test dependencies, in order to keep it in-sync with requirements.txt i.e. we run our tests against the same versions of dependencies that we deploy with, and the build fails if we try to use package versions that are not mutually compatible, as this example PR shows [1]. ERROR: Cannot install -r requirements_for_test.txt (line 17), -r requirements_for_test.txt (line 198) and pyyaml==5.4.1 because these package versions have conflicting dependencies. We shouldn't need to have fine-grained locking on test dependencies, beyond those we want to list manually in the file. [1]: https://github.com/alphagov/notifications-admin/pull/3804 2021-02-16 17:08:03 +00:00			`# used for creating manifest file locally`
			`jinja2-cli[yaml]==0.7.0`