tests/app/utils/test_pagination.py

from app.utils.pagination import generate_next_dict, generate_previous_dict


def test_generate_previous_dict(client_request):
    result = generate_previous_dict('main.view_jobs', 'foo', 2, {})
    assert 'page=1' in result['url']
    assert result['title'] == 'Previous page'
    assert result['label'] == 'page 1'


def test_generate_next_dict(client_request):
    result = generate_next_dict('main.view_jobs', 'foo', 2, {})
    assert 'page=3' in result['url']
    assert result['title'] == 'Next page'
    assert result['label'] == 'page 3'


def test_generate_previous_next_dict_adds_other_url_args(client_request):
    result = generate_next_dict('main.view_notifications', 'foo', 2, {'message_type': 'blah'})
    assert 'notifications/blah' in result['url']
Move pagination utils into own module This continues the pattern established in [1], just to chip away a bit more at the random collection of stuff in utils/__init__.py. [1]: https://github.com/alphagov/notifications-admin/pull/3923 2021-06-14 11:00:05 +01:00			`from app.utils.pagination import generate_next_dict, generate_previous_dict`


Replace uses of `client` to set request context Some tests use the `client` fixture but don’t call any of its methods. The reason for doing this is because the test depends on something in the request context. This commit replaces all those instances with `client_request`, which also sets the request context. These tests are the last ones that still use the `client` fixture. By replacing it with `client_request` we will be able to say that no tests should be using the `client` fixture directly. 2022-01-04 18:33:23 +00:00			`def test_generate_previous_dict(client_request):`
Clarify variable name in pagination tests We should avoid using abbreviations, as they aren't universally understood i.e. they're not worth the small saving in typing. 2021-06-16 16:08:38 +01:00			`result = generate_previous_dict('main.view_jobs', 'foo', 2, {})`
			`assert 'page=1' in result['url']`
			`assert result['title'] == 'Previous page'`
			`assert result['label'] == 'page 1'`
Move pagination utils into own module This continues the pattern established in [1], just to chip away a bit more at the random collection of stuff in utils/__init__.py. [1]: https://github.com/alphagov/notifications-admin/pull/3923 2021-06-14 11:00:05 +01:00

Replace uses of `client` to set request context Some tests use the `client` fixture but don’t call any of its methods. The reason for doing this is because the test depends on something in the request context. This commit replaces all those instances with `client_request`, which also sets the request context. These tests are the last ones that still use the `client` fixture. By replacing it with `client_request` we will be able to say that no tests should be using the `client` fixture directly. 2022-01-04 18:33:23 +00:00			`def test_generate_next_dict(client_request):`
Clarify variable name in pagination tests We should avoid using abbreviations, as they aren't universally understood i.e. they're not worth the small saving in typing. 2021-06-16 16:08:38 +01:00			`result = generate_next_dict('main.view_jobs', 'foo', 2, {})`
			`assert 'page=3' in result['url']`
			`assert result['title'] == 'Next page'`
			`assert result['label'] == 'page 3'`
Move pagination utils into own module This continues the pattern established in [1], just to chip away a bit more at the random collection of stuff in utils/__init__.py. [1]: https://github.com/alphagov/notifications-admin/pull/3923 2021-06-14 11:00:05 +01:00

Replace uses of `client` to set request context Some tests use the `client` fixture but don’t call any of its methods. The reason for doing this is because the test depends on something in the request context. This commit replaces all those instances with `client_request`, which also sets the request context. These tests are the last ones that still use the `client` fixture. By replacing it with `client_request` we will be able to say that no tests should be using the `client` fixture directly. 2022-01-04 18:33:23 +00:00			`def test_generate_previous_next_dict_adds_other_url_args(client_request):`
Clarify variable name in pagination tests We should avoid using abbreviations, as they aren't universally understood i.e. they're not worth the small saving in typing. 2021-06-16 16:08:38 +01:00			`result = generate_next_dict('main.view_notifications', 'foo', 2, {'message_type': 'blah'})`
			`assert 'notifications/blah' in result['url']`