setup.cfg

[tool:pytest]
norecursedirs=node_modules bower_components
xfail_strict=true

[isort]
line_length=80
indent='    '
multi_line_output=3
known_third_party=notifications_utils,notifications_python_client
known_first_party=app,tests
include_trailing_comma=True

[flake8]
# W504 line break after binary operator
extend_ignore=B003, B306, W504
select=B901, B902, B903
bump test requirements to most recent 2016-09-09 16:29:30 +01:00			`[tool:pytest]`
define isort first party (app and tests) we were seeing isort produce different outputs locally and in docker - this was due to it having different opinions about whether the tests module (ie all our unit tests) is a first party (local) or third party (pip installed) import. It's a first party import, so by defining this in the setup.cfg isort settings, we can force it to be consistent between environments. Note: I don't know why it was different in the first place though 2018-04-25 14:12:58 +01:00			`norecursedirs=node_modules bower_components`
make xfail passes (unexpected passes) fail test runs 2017-02-23 16:36:16 +00:00			`xfail_strict=true`
Enforce order and style of imports Done using isort[1], with the following command: ``` isort -rc ./app ./tests ``` Adds linting to the `run_tests.sh` script to stop badly-sorted imports getting re-introduced. Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because I think it gives the cleanest diffs, eg: ``` from third_party import ( lib1, lib2, lib3, lib4, ) ``` 1. https://pypi.python.org/pypi/isort 2018-02-20 11:22:17 +00:00
			`[isort]`
			`line_length=80`
			`indent=' '`
			`multi_line_output=3`
define isort first party (app and tests) we were seeing isort produce different outputs locally and in docker - this was due to it having different opinions about whether the tests module (ie all our unit tests) is a first party (local) or third party (pip installed) import. It's a first party import, so by defining this in the setup.cfg isort settings, we can force it to be consistent between environments. Note: I don't know why it was different in the first place though 2018-04-25 14:12:58 +01:00			`known_third_party=notifications_utils,notifications_python_client`
			`known_first_party=app,tests`
			`include_trailing_comma=True`
bump reqs 2018-11-13 10:49:35 +00:00
			`[flake8]`
			`# W504 line break after binary operator`
Do extra code style checks with flake8-bugbear Flake8 Bugbear checks for some extra things that aren’t code style errors, but are likely to introduce bugs or unexpected behaviour. A good example is having mutable default function arguments, which get shared between every call to the function and therefore mutating a value in one place can unexpectedly cause it to change in another. This commit enables all the extra warnings provided by Flake8 Bugbear, except for the line length one (because we already lint for that separately). It disables: - _B003: Assigning to os.environ_ because I don’t really understand this - _B306: BaseException.message is removed in Python 3_ because I think our exceptions have a custom structure that means the `.message` attribute is still present 2019-11-01 10:43:01 +00:00			`extend_ignore=B003, B306, W504`
			`select=B901, B902, B903`