2019-03-19 11:49:10 +00:00
|
|
|
import uuid
|
2023-08-14 16:59:38 -04:00
|
|
|
from unittest.mock import call
|
2018-02-20 11:22:17 +00:00
|
|
|
|
|
|
|
|
import pytest
|
|
|
|
|
|
2018-04-19 13:15:52 +01:00
|
|
|
from app import invite_api_client, service_api_client, user_api_client
|
2018-09-26 16:41:04 +01:00
|
|
|
from tests import sample_uuid
|
2019-12-19 16:59:07 +00:00
|
|
|
from tests.conftest import SERVICE_ONE_ID
|
2018-02-21 09:26:42 +00:00
|
|
|
|
2018-09-26 16:41:04 +01:00
|
|
|
user_id = sample_uuid()
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
|
2018-02-21 09:26:42 +00:00
|
|
|
|
|
|
|
|
def test_client_gets_all_users_for_service(
|
|
|
|
|
mocker,
|
|
|
|
|
fake_uuid,
|
|
|
|
|
):
|
|
|
|
|
user_api_client.max_failed_login_count = 99 # doesn't matter for this test
|
|
|
|
|
mock_get = mocker.patch(
|
2023-08-25 09:12:23 -07:00
|
|
|
"app.notify_client.user_api_client.UserApiClient.get",
|
|
|
|
|
return_value={
|
|
|
|
|
"data": [
|
|
|
|
|
{"id": fake_uuid},
|
|
|
|
|
]
|
|
|
|
|
},
|
2018-02-21 09:26:42 +00:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
users = user_api_client.get_users_for_service(SERVICE_ONE_ID)
|
|
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_get.assert_called_once_with("/service/{}/users".format(SERVICE_ONE_ID))
|
2018-02-21 09:26:42 +00:00
|
|
|
assert len(users) == 1
|
2023-08-25 09:12:23 -07:00
|
|
|
assert users[0]["id"] == fake_uuid
|
2018-02-21 10:18:56 +00:00
|
|
|
|
|
|
|
|
|
2016-02-23 12:47:48 +00:00
|
|
|
def test_client_uses_correct_find_by_email(mocker, api_user_active):
|
2023-08-25 09:12:23 -07:00
|
|
|
expected_url = "/user/email"
|
|
|
|
|
expected_data = {"email": api_user_active["email_address"]}
|
2016-02-23 12:47:48 +00:00
|
|
|
|
2018-02-09 15:04:52 +00:00
|
|
|
user_api_client.max_failed_login_count = 1 # doesn't matter for this test
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_post = mocker.patch("app.notify_client.user_api_client.UserApiClient.post")
|
2016-02-23 12:47:48 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.get_user_by_email(api_user_active["email_address"])
|
2016-02-23 12:47:48 +00:00
|
|
|
|
2021-03-05 15:05:48 +00:00
|
|
|
mock_post.assert_called_once_with(expected_url, data=expected_data)
|
2016-11-09 15:06:02 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_client_only_updates_allowed_attributes(mocker):
|
2023-08-25 09:12:23 -07:00
|
|
|
mocker.patch("app.notify_client.current_user", id="1")
|
2016-11-09 15:06:02 +00:00
|
|
|
with pytest.raises(TypeError) as error:
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.update_user_attribute("user_id", id="1")
|
|
|
|
|
assert str(error.value) == "Not allowed to update user attributes: id"
|
2017-02-07 13:31:46 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_client_updates_password_separately(mocker, api_user_active):
|
2023-08-25 09:12:23 -07:00
|
|
|
expected_url = "/user/{}/update-password".format(api_user_active["id"])
|
|
|
|
|
expected_params = {"_password": "newpassword"}
|
2018-02-09 15:04:52 +00:00
|
|
|
user_api_client.max_failed_login_count = 1 # doesn't matter for this test
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_update_password = mocker.patch(
|
|
|
|
|
"app.notify_client.user_api_client.UserApiClient.post"
|
|
|
|
|
)
|
2017-02-07 13:31:46 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.update_password(api_user_active["id"], expected_params["_password"])
|
2017-02-07 13:31:46 +00:00
|
|
|
mock_update_password.assert_called_once_with(expected_url, data=expected_params)
|
2017-11-09 14:37:33 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_client_activates_if_pending(mocker, api_user_pending):
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_post = mocker.patch("app.notify_client.user_api_client.UserApiClient.post")
|
2018-02-09 15:04:52 +00:00
|
|
|
user_api_client.max_failed_login_count = 1 # doesn't matter for this test
|
2017-11-09 14:37:33 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.activate_user(api_user_pending["id"])
|
2017-11-09 14:37:33 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_post.assert_called_once_with(
|
|
|
|
|
"/user/{}/activate".format(api_user_pending["id"]), data=None
|
|
|
|
|
)
|
2018-02-09 15:01:20 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_client_passes_admin_url_when_sending_email_auth(
|
2021-05-12 14:57:21 +01:00
|
|
|
notify_admin,
|
2018-02-09 15:01:20 +00:00
|
|
|
mocker,
|
|
|
|
|
fake_uuid,
|
|
|
|
|
):
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_post = mocker.patch("app.notify_client.user_api_client.UserApiClient.post")
|
2018-02-09 15:01:20 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.send_verify_code(fake_uuid, "email", "ignored@example.com")
|
2018-02-09 15:01:20 +00:00
|
|
|
|
|
|
|
|
mock_post.assert_called_once_with(
|
2023-08-25 09:12:23 -07:00
|
|
|
"/user/{}/email-code".format(fake_uuid),
|
2018-02-09 15:01:20 +00:00
|
|
|
data={
|
2023-08-25 09:12:23 -07:00
|
|
|
"to": "ignored@example.com",
|
|
|
|
|
"email_auth_link_host": "http://localhost:6012",
|
|
|
|
|
},
|
2018-02-09 15:01:20 +00:00
|
|
|
)
|
2018-02-28 15:37:49 +00:00
|
|
|
|
|
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
def test_client_converts_admin_permissions_to_db_permissions_on_edit(
|
|
|
|
|
notify_admin, mocker
|
|
|
|
|
):
|
|
|
|
|
mock_post = mocker.patch("app.notify_client.user_api_client.UserApiClient.post")
|
2018-02-28 15:37:49 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.set_user_permissions(
|
|
|
|
|
"user_id", "service_id", permissions={"send_messages", "view_activity"}
|
|
|
|
|
)
|
2018-02-28 15:37:49 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
assert sorted(
|
|
|
|
|
mock_post.call_args[1]["data"]["permissions"], key=lambda x: x["permission"]
|
|
|
|
|
) == sorted(
|
|
|
|
|
[
|
|
|
|
|
{"permission": "send_texts"},
|
|
|
|
|
{"permission": "send_emails"},
|
|
|
|
|
{"permission": "view_activity"},
|
|
|
|
|
],
|
|
|
|
|
key=lambda x: x["permission"],
|
|
|
|
|
)
|
2018-02-28 15:37:49 +00:00
|
|
|
|
|
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
def test_client_converts_admin_permissions_to_db_permissions_on_add_to_service(
|
|
|
|
|
notify_admin, mocker
|
|
|
|
|
):
|
|
|
|
|
mock_post = mocker.patch(
|
|
|
|
|
"app.notify_client.user_api_client.UserApiClient.post",
|
|
|
|
|
return_value={"data": {}},
|
|
|
|
|
)
|
2018-02-28 15:37:49 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.add_user_to_service(
|
|
|
|
|
"service_id",
|
|
|
|
|
"user_id",
|
|
|
|
|
permissions={"send_messages", "view_activity"},
|
|
|
|
|
folder_permissions=[],
|
|
|
|
|
)
|
2018-02-28 15:37:49 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
assert sorted(
|
|
|
|
|
mock_post.call_args[1]["data"]["permissions"], key=lambda x: x["permission"]
|
|
|
|
|
) == sorted(
|
|
|
|
|
[
|
|
|
|
|
{"permission": "send_texts"},
|
|
|
|
|
{"permission": "send_emails"},
|
|
|
|
|
{"permission": "view_activity"},
|
|
|
|
|
],
|
|
|
|
|
key=lambda x: x["permission"],
|
|
|
|
|
)
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
|
|
|
|
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
|
|
|
(
|
2023-09-08 17:58:06 -04:00
|
|
|
"expected_cache_get_calls",
|
|
|
|
|
"cache_value",
|
|
|
|
|
"expected_api_calls",
|
|
|
|
|
"expected_cache_set_calls",
|
|
|
|
|
"expected_return_value",
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
),
|
|
|
|
|
[
|
|
|
|
|
(
|
2023-08-25 09:12:23 -07:00
|
|
|
[call("user-{}".format(user_id))],
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
b'{"data": "from cache"}',
|
|
|
|
|
[],
|
|
|
|
|
[],
|
2023-08-25 09:12:23 -07:00
|
|
|
"from cache",
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
),
|
|
|
|
|
(
|
2023-08-25 09:12:23 -07:00
|
|
|
[call("user-{}".format(user_id))],
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
None,
|
2023-08-25 09:12:23 -07:00
|
|
|
[call("/user/{}".format(user_id))],
|
|
|
|
|
[call("user-{}".format(user_id), '{"data": "from api"}', ex=604800)],
|
|
|
|
|
"from api",
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
),
|
2023-08-25 09:12:23 -07:00
|
|
|
],
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
)
|
|
|
|
|
def test_returns_value_from_cache(
|
2021-05-12 14:57:21 +01:00
|
|
|
notify_admin,
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
mocker,
|
|
|
|
|
expected_cache_get_calls,
|
|
|
|
|
cache_value,
|
|
|
|
|
expected_return_value,
|
|
|
|
|
expected_api_calls,
|
|
|
|
|
expected_cache_set_calls,
|
|
|
|
|
):
|
|
|
|
|
mock_redis_get = mocker.patch(
|
2023-08-25 09:12:23 -07:00
|
|
|
"app.extensions.RedisClient.get",
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
return_value=cache_value,
|
|
|
|
|
)
|
|
|
|
|
mock_api_get = mocker.patch(
|
2023-08-25 09:12:23 -07:00
|
|
|
"app.notify_client.NotifyAdminAPIClient.get",
|
|
|
|
|
return_value={"data": "from api"},
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
)
|
|
|
|
|
mock_redis_set = mocker.patch(
|
2023-08-25 09:12:23 -07:00
|
|
|
"app.extensions.RedisClient.set",
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
)
|
|
|
|
|
|
|
|
|
|
user_api_client.get_user(user_id)
|
|
|
|
|
|
|
|
|
|
assert mock_redis_get.call_args_list == expected_cache_get_calls
|
|
|
|
|
assert mock_api_get.call_args_list == expected_api_calls
|
|
|
|
|
assert mock_redis_set.call_args_list == expected_cache_set_calls
|
|
|
|
|
|
|
|
|
|
|
2023-10-26 08:33:59 -07:00
|
|
|
@pytest.mark.parametrize(
|
2023-09-08 17:58:06 -04:00
|
|
|
("client", "method", "extra_args", "extra_kwargs"),
|
2023-08-25 09:12:23 -07:00
|
|
|
[
|
|
|
|
|
(user_api_client, "update_user_attribute", [user_id], {}),
|
|
|
|
|
(user_api_client, "reset_failed_login_count", [user_id], {}),
|
|
|
|
|
(user_api_client, "update_password", [user_id, "hunter2"], {}),
|
|
|
|
|
(user_api_client, "verify_password", [user_id, "hunter2"], {}),
|
|
|
|
|
(user_api_client, "check_verify_code", [user_id, "", ""], {}),
|
|
|
|
|
(user_api_client, "add_user_to_service", [SERVICE_ONE_ID, user_id, [], []], {}),
|
|
|
|
|
(user_api_client, "add_user_to_organization", [sample_uuid(), user_id], {}),
|
|
|
|
|
(user_api_client, "set_user_permissions", [user_id, SERVICE_ONE_ID, []], {}),
|
|
|
|
|
(user_api_client, "activate_user", [user_id], {}),
|
|
|
|
|
(user_api_client, "archive_user", [user_id], {}),
|
|
|
|
|
(service_api_client, "remove_user_from_service", [SERVICE_ONE_ID, user_id], {}),
|
|
|
|
|
(
|
|
|
|
|
service_api_client,
|
|
|
|
|
"create_service",
|
|
|
|
|
["", "", 0, False, user_id, sample_uuid()],
|
|
|
|
|
{},
|
|
|
|
|
),
|
|
|
|
|
(invite_api_client, "accept_invite", [SERVICE_ONE_ID, user_id], {}),
|
|
|
|
|
],
|
|
|
|
|
)
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
def test_deletes_user_cache(
|
2021-05-12 14:57:21 +01:00
|
|
|
notify_admin,
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
mock_get_user,
|
|
|
|
|
mocker,
|
|
|
|
|
client,
|
|
|
|
|
method,
|
|
|
|
|
extra_args,
|
|
|
|
|
extra_kwargs,
|
|
|
|
|
):
|
2023-08-25 09:12:23 -07:00
|
|
|
mocker.patch("app.notify_client.current_user", id="1")
|
|
|
|
|
mock_redis_delete = mocker.patch("app.extensions.RedisClient.delete")
|
|
|
|
|
mock_request = mocker.patch(
|
|
|
|
|
"notifications_python_client.base.BaseAPIClient.request"
|
|
|
|
|
)
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
|
|
|
|
|
getattr(client, method)(*extra_args, **extra_kwargs)
|
|
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
assert call("user-{}".format(user_id)) in mock_redis_delete.call_args_list
|
Cache `GET /user` response in Redis
In the same way, and for the same reasons that we’re caching the service
object.
Here’s a sample of the data returned by the API – so we should make sure
that any changes to this data invalidate the cache.
If we ever change a user’s phone number (for example) directly in the
database, then we will need to invalidate this cache manually.
```python
{
'data':{
'organisations':[
'4c707b81-4c6d-4d33-9376-17f0de6e0405'
],
'logged_in_at':'2018-04-10T11:41:03.781990Z',
'id':'2c45486e-177e-40b8-997d-5f4f81a461ca',
'email_address':'test@example.gov.uk',
'platform_admin':False,
'password_changed_at':'2018-01-01 10:10:10.100000',
'permissions':{
'42a9d4f2-1444-4e22-9133-52d9e406213f':[
'manage_api_keys',
'send_letters',
'manage_users',
'manage_templates',
'view_activity',
'send_texts',
'send_emails',
'manage_settings'
],
'a928eef8-0f25-41ca-b480-0447f29b2c20':[
'manage_users',
'manage_templates',
'manage_settings',
'send_texts',
'send_emails',
'send_letters',
'manage_api_keys',
'view_activity'
],
},
'state':'active',
'mobile_number':'07700900123',
'failed_login_count':0,
'name':'Example',
'services':[
'6078a8c0-52f5-4c4f-b724-d7d1ff2d3884',
'6afe3c1c-7fda-4d8d-aa8d-769c4bdf7803',
],
'current_session_id':'fea2ade1-db0a-4c90-93e7-c64a877ce83e',
'auth_type':'sms_auth'
}
}
```
2018-04-10 13:30:52 +01:00
|
|
|
assert len(mock_request.call_args_list) == 1
|
2019-03-19 11:49:10 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_add_user_to_service_calls_correct_endpoint_and_deletes_keys_from_cache(mocker):
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_redis_delete = mocker.patch("app.extensions.RedisClient.delete")
|
2019-03-19 11:49:10 +00:00
|
|
|
|
|
|
|
|
service_id = uuid.uuid4()
|
|
|
|
|
user_id = uuid.uuid4()
|
|
|
|
|
folder_id = uuid.uuid4()
|
|
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
expected_url = "/service/{}/users/{}".format(service_id, user_id)
|
|
|
|
|
data = {"permissions": [], "folder_permissions": [folder_id]}
|
2019-03-19 11:49:10 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_post = mocker.patch("app.notify_client.user_api_client.UserApiClient.post")
|
2019-03-19 11:49:10 +00:00
|
|
|
|
|
|
|
|
user_api_client.add_user_to_service(service_id, user_id, [], [folder_id])
|
|
|
|
|
|
|
|
|
|
mock_post.assert_called_once_with(expected_url, data=data)
|
|
|
|
|
assert mock_redis_delete.call_args_list == [
|
2023-08-25 09:12:23 -07:00
|
|
|
call("user-{user_id}".format(user_id=user_id)),
|
|
|
|
|
call("service-{service_id}-template-folders".format(service_id=service_id)),
|
|
|
|
|
call("service-{service_id}".format(service_id=service_id)),
|
2019-03-19 11:49:10 +00:00
|
|
|
]
|
2021-05-07 15:00:01 +01:00
|
|
|
|
|
|
|
|
|
2022-02-02 16:24:03 +00:00
|
|
|
def test_reset_password(
|
|
|
|
|
mocker,
|
|
|
|
|
fake_uuid,
|
|
|
|
|
):
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_post = mocker.patch("app.notify_client.user_api_client.UserApiClient.post")
|
2022-02-02 16:24:03 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.send_reset_password_url("test@example.com")
|
2022-02-02 16:24:03 +00:00
|
|
|
|
|
|
|
|
mock_post.assert_called_once_with(
|
2023-08-25 09:12:23 -07:00
|
|
|
"/user/reset-password",
|
2022-02-02 16:24:03 +00:00
|
|
|
data={
|
2023-08-25 09:12:23 -07:00
|
|
|
"email": "test@example.com",
|
|
|
|
|
"admin_base_url": "http://localhost:6012",
|
2022-02-02 16:24:03 +00:00
|
|
|
},
|
|
|
|
|
)
|
2022-03-07 15:11:50 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_send_registration_email(
|
|
|
|
|
mocker,
|
|
|
|
|
fake_uuid,
|
|
|
|
|
):
|
2023-08-25 09:12:23 -07:00
|
|
|
mock_post = mocker.patch("app.notify_client.user_api_client.UserApiClient.post")
|
2022-03-07 15:11:50 +00:00
|
|
|
|
2023-08-25 09:12:23 -07:00
|
|
|
user_api_client.send_verify_email(fake_uuid, "test@example.com")
|
2022-03-07 15:11:50 +00:00
|
|
|
|
|
|
|
|
mock_post.assert_called_once_with(
|
2023-08-25 09:12:23 -07:00
|
|
|
f"/user/{fake_uuid}/email-verification",
|
2022-03-07 15:11:50 +00:00
|
|
|
data={
|
2023-08-25 09:12:23 -07:00
|
|
|
"to": "test@example.com",
|
|
|
|
|
"admin_base_url": "http://localhost:6012",
|
2022-03-07 15:11:50 +00:00
|
|
|
},
|
|
|
|
|
)
|