tests/app/test_assets.py

def test_static_404s_return(client_request):
    client_request.get_response_from_url(
        "/static/images/some-image-that-doesnt-exist.png",
        _expected_status=404,
    )
Replace uses of `client.get` and `client.post` We have a `client_request` fixture which does a bunch of useful stuff like: - checking the status code of the response - returning a `BeautifulSoup` object Lots of our tests still use an older fixture called `client`. This is not as good because it: - returns a raw `Response` object - doesn’t do the additional checks - means our tests contain a lot of repetetive boilerplate like `page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')` This commit converts all the tests which had a `client.get(…)` or `client.post(…)` statement to use their equivalents on `client_request` instead. Subsequent commits will remove uses of `client` in other tests, but doing it this way means the work can be broken up into more manageable chunks. 2022-01-04 15:40:42 +00:00			`def test_static_404s_return(client_request):`
			`client_request.get_response_from_url(`
notify-api-412 use black to enforce python coding style 2023-08-25 09:12:23 -07:00			`"/static/images/some-image-that-doesnt-exist.png",`
Replace uses of `client.get` and `client.post` We have a `client_request` fixture which does a bunch of useful stuff like: - checking the status code of the response - returning a `BeautifulSoup` object Lots of our tests still use an older fixture called `client`. This is not as good because it: - returns a raw `Response` object - doesn’t do the additional checks - means our tests contain a lot of repetetive boilerplate like `page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')` This commit converts all the tests which had a `client.get(…)` or `client.post(…)` statement to use their equivalents on `client_request` instead. Subsequent commits will remove uses of `client` in other tests, but doing it this way means the work can be broken up into more manageable chunks. 2022-01-04 15:40:42 +00:00			`_expected_status=404,`
			`)`