app/notify_client/status_api_client.py

from notifications_python_client.base import BaseAPIClient


class StatusApiClient(BaseAPIClient):
    def __init__(self):
        super().__init__("a", "b", "c")

    def init_app(self, app):
        self.base_url = app.config['API_HOST_NAME']
        self.service_id = app.config['ADMIN_CLIENT_USER_NAME']
        self.api_key = app.config['ADMIN_CLIENT_SECRET']

    def get_status(self, *params):
        return self.get(url='/_status', *params)
notifications-python_client upgraded to 0.2.5 2016-02-11 15:27:08 +00:00			`from notifications_python_client.base import BaseAPIClient`
Status update added. 2016-01-29 14:41:07 +00:00

			`class StatusApiClient(BaseAPIClient):`
Make it clear that client do not use `__init__` The clients never get passed useful values to their `__init__` methods. Rather the real values are passed through later using the `init_app` method. So it should be an error if the client is relying on the values that get passed to it’s init method. Easiest way to ensure this is by making the `__init__` method not expect any arguments and passing fake values to the `Super` call. 2016-09-12 12:14:57 +01:00			`def __init__(self):`
Remove extraneous arguments to super > dont need self.__class__, self in super - that's a python 2.x crutch. > super() is equivalent 2016-09-12 14:59:53 +01:00			`super().__init__("a", "b", "c")`
Status update added. 2016-01-29 14:41:07 +00:00
			`def init_app(self, app):`
			`self.base_url = app.config['API_HOST_NAME']`
Update Python client Just so that nobody else has to do it. Implements: - [x] https://github.com/alphagov/notifications-python-client/pull/29 Which is a breaking change requiring the renaming of method arguments. 2016-09-08 15:55:07 +01:00			`self.service_id = app.config['ADMIN_CLIENT_USER_NAME']`
			`self.api_key = app.config['ADMIN_CLIENT_SECRET']`
Status update added. 2016-01-29 14:41:07 +00:00
			`def get_status(self, *params):`
Status page now relies on the api passing else a 500 will be returned. 2016-04-06 16:36:03 +01:00			`return self.get(url='/_status', *params)`