darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-05-29 10:30:20 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
4d0da6594de60fcf37dc7796279462e32072d7a1
notifications-admin/app/templates/views/check/ok.html

108 lines
4.2 KiB
HTML
Raw Normal View History

Added main nav to logged in pages
2015-12-14 16:53:07 +00:00
{% extends "withnav_template.html" %}
Give the user better error messages for CSV files Makes uses of the additions to utils in https://github.com/alphagov/notifications-utils/pull/9 This commit strips out a lot of the complex stuff that the views and templates in this app were doing. There is now a cleaner separation of concerns: - utils returns the number and type of errors in the csv - `get_errors_for_csv` helper in this app maps the number and type of errors onto human-friendly error messages - the view and template just doing the glueing-together of all the pieces This is (hopefully) easier to understand, definitely makes the component parts easier to test in isolation, and makes it easier to give more specific error messages.
2016-03-07 18:47:05 +00:00
{% from "components/banner.html" import banner_wrapper %}
Add a component for picking the time to send a job Users need to pick a time in the next 24hrs, or send a file immediately. Rationale for this is a bit lost in time-before-holiday, but generally: ‘Now’ and ‘later’ as the inital choices makes it really clear what this feature is about conceptually. The choice of times is absolute, eg ‘1pm’ not ‘in 3 hours’
2016-08-07 09:17:49 +01:00
{% from "components/radios.html" import radio_select %}
Add row numbers to tables When a table is showing the contents of a CSV file, it should look something like a spreadsheet. The minimally skeuomorphic way to do this is by adding row numbers. This commit doesn’t - make the row numbers monospace (it’s barely noticeable and doesn’t reflect what actual spreadsheets do) - make the first column heading ‘Row’ (again, doesn’t reflect how actual spreadsheets work, and takes up more valuable space)
2016-04-05 11:16:29 +01:00
{% from "components/table.html" import list_table, field, text_field, index_field, hidden_field_heading %}
Add GOV.UK Design System style back links The Design System has standardised on back links being at the top of the page, decorated with a small text-coloured arrow. I think this makes more sense than having them at the bottom, because it suggests, in some way, being able to go back before commiting to any of the forms on the page. Whereas the things at the bottom of the page should be performing actions on what’s in the page. The reason for making this change now is that it de-clutters the area around the green buttons. This was presenting a design challenge where multiple levels of interaction were happening in the same form. Moving these back links to the top of the page should mean that, in these complicated forms, there’s one fewer thing to compete for the user’s attention. I’ve componentised this into a `page_header` macro so that the change is easier to roll out and maintain.
2019-04-29 11:44:05 +01:00
{% from "components/page-header.html" import page_header %}
Use message_count_label component For the button on the check page, we need to be able to say ‘1 text message’ or ‘55 emails’. We already have the logic to do this on the dashboard (101 text messages sent), and it’s already in a component. So this commit makes the check page use the same component.
2016-06-03 14:48:21 +01:00
{% from "components/message-count-label.html" import message_count_label %}
Replace straightforward buttons and links styled like buttons This replaces the buttons that aren't part of a macro and that we don't need to write additional styles for with their govuk-frontend equivalent. There were some links that were styled to look like buttons, so these have also been replaced with the new govuk-frontend macro. There was one button on the `choose-account.html` template that was in a section of code that was never reached - this has been deleted.
2020-01-30 14:01:13 +00:00
{% from "components/button/macro.njk" import govukButton %}
Change order of errors for bad CSV files This commit rearranges the CSV errors (again) to make them geared towards teaching you how to match placeholders to the column headers. So the order of errors now is: 1. No phone number/email column 2. Column headers don’t match placeholders 3. Missing or bad data 4. Trial mode 5. Daily limit reached This depends on: - [x] https://github.com/alphagov/notifications-utils/pull/39 for 1.
2016-06-03 13:52:15 +01:00
Add a skip link to the preview page The accessibility audit raised the issue that screen reader users could miss the table of data on the preview page, because it’s after the submit/back buttons. > The back button is before the table of error messages - a screen > reader user might read the initial error summary then get to the back > button and not realise the error detail are later in the sequence. > The send and back buttons are before the table of field values - a > screen reader user might read the template details ror summary then > get to the buttons and not realise the field details are later in the > sequence. This commit add a skip link to navigate the users directly to the table, which: - allows them to skip past a lot of content which they might already have read - makes them aware that the table exists It’s added: – as the first thing after the `<h1>` when there are no errors with the file - as the last thing in the error summary when there are errors with the file The link is hidden from those interacting with the site visually.
2017-02-13 15:20:56 +00:00
{% set file_contents_header_id = 'file-preview' %}
{% macro skip_to_file_contents() %}
Replace all visually-hidden classes These have been replaced: https://design-system.service.gov.uk/get-started/updating-your-code/#helper-class-names
2019-10-21 15:18:25 +01:00
<p class="govuk-visually-hidden">
Update all links to use GOVUK Frontend style Includes: - turning off :visited styles to match existing design - swapping heading classes used to make links bold for the GOVUK Frontend bold override class - adding visually hidden text to some links to make them work when isolated from their context We may need to revisit whether some links, such as those for documentation and features, may benefit from having some indication that their target has been visited.
2019-12-06 07:53:46 +00:00
<a class="govuk-link govuk-link--no-visited-state" href="#{{ file_contents_header_id }}">Skip to file contents</a>
Add a skip link to the preview page The accessibility audit raised the issue that screen reader users could miss the table of data on the preview page, because it’s after the submit/back buttons. > The back button is before the table of error messages - a screen > reader user might read the initial error summary then get to the back > button and not realise the error detail are later in the sequence. > The send and back buttons are before the table of field values - a > screen reader user might read the template details ror summary then > get to the buttons and not realise the field details are later in the > sequence. This commit add a skip link to navigate the users directly to the table, which: - allows them to skip past a lot of content which they might already have read - makes them aware that the table exists It’s added: – as the first thing after the `<h1>` when there are no errors with the file - as the last thing in the error summary when there are errors with the file The link is hidden from those interacting with the site visually.
2017-02-13 15:20:56 +00:00
</p>
{% endmacro %}
Include service name in page `<title>` In pages specific to a service (e.g. dashboard and sub pages) the title needs to distinguish which service it applies to. This is mainly to give context to screen reader users who could be managing multiple services. Implementing this uses template inheritance: `page_title` includes `per_page_title` includes `service_page_title` ‘GOV.UK Notify’ is inserted into every page title. Pages that set `service_page_title` get the service name inserted too.
2017-02-13 10:45:15 +00:00
{% block service_page_title %}
Remove anything error-related from the OK view If you’ve uploaded a file and everything is OK, the page that you see doesn’t need to look at any errors (because there won’t be any).
2017-07-20 09:02:08 +01:00
{{ "Preview of {}".format(template.name) }}
Create shell page for checking text messages before sending
2015-11-30 14:20:17 +00:00
{% endblock %}
Added main nav to logged in pages
2015-12-14 16:53:07 +00:00
{% block maincolumn_content %}
Add GOV.UK Design System style back links The Design System has standardised on back links being at the top of the page, decorated with a small text-coloured arrow. I think this makes more sense than having them at the bottom, because it suggests, in some way, being able to go back before commiting to any of the forms on the page. Whereas the things at the bottom of the page should be performing actions on what’s in the page. The reason for making this change now is that it de-clutters the area around the green buttons. This was presenting a design challenge where multiple levels of interaction were happening in the same form. Moving these back links to the top of the page should mean that, in these complicated forms, there’s one fewer thing to compete for the user’s attention. I’ve componentised this into a `page_header` macro so that the change is easier to roll out and maintain.
2019-04-29 11:44:05 +01:00
{{ page_header(
'Preview of {}'.format(template.name),
back_link=back_link
) }}
Move letter too long banner message over from utils, also refactor
2019-10-01 17:16:15 +01:00
{% if letter_too_long %}
Test letter too long error banner using exisitng data-error-type attribute This way we can avoid both creating an id attribute for testing and testing by content.
2019-10-24 14:17:01 +01:00
{% call banner_wrapper(type='dangerous') %}
Move letter too long banner message over from utils, also refactor
2019-10-01 17:16:15 +01:00
{% include "partials/check/letter-too-long.html" %}
{% endcall %}
{% endif %}
Remove anything error-related from the OK view If you’ve uploaded a file and everything is OK, the page that you see doesn’t need to look at any errors (because there won’t be any).
2017-07-20 09:02:08 +01:00
{{ skip_to_file_contents() }}
Error if a CSV file contains more than 50,000 rows We want to limit the number of rows someone can have in a job, because it gets too slow to process the file otherwise. This should be the first error that a user sees, because we can’t work out if there are other errors until they’ve got the file down to a processable size. This also means adding a message to say that the file can’t be displayed if it doesn’t contain any processed rows. *** https://www.pivotaltracker.com/story/show/129830161
2016-10-14 10:44:28 +01:00
Remove anything error-related from the OK view If you’ve uploaded a file and everything is OK, the page that you see doesn’t need to look at any errors (because there won’t be any).
2017-07-20 09:02:08 +01:00
{{ template|string }}
Add a skip link to the preview page The accessibility audit raised the issue that screen reader users could miss the table of data on the preview page, because it’s after the submit/back buttons. > The back button is before the table of error messages - a screen > reader user might read the initial error summary then get to the back > button and not realise the error detail are later in the sequence. > The send and back buttons are before the table of field values - a > screen reader user might read the template details ror summary then > get to the buttons and not realise the field details are later in the > sequence. This commit add a skip link to navigate the users directly to the table, which: - allows them to skip past a lot of content which they might already have read - makes them aware that the table exists It’s added: – as the first thing after the `<h1>` when there are no errors with the file - as the last thing in the error summary when there are errors with the file The link is hidden from those interacting with the site visually.
2017-02-13 15:20:56 +00:00
<div class="bottom-gutter-3-2">
Store template ID and original file name in URL At the moment you can’t press refresh on the check page if there’s errors. This is because the session gets cleared when there’s errors. This is a bad user experience. The data that this page is relying on (from the session) is: - template ID - original file name Neither of these things need to be in the session because: - they are not secret - the user can modify them already (by choosing a different template or renaming their file locally) So this commit additionally stores them in the URL.
2018-03-29 17:01:35 +01:00
<form method="post" enctype="multipart/form-data" action="{{url_for('main.start_job', service_id=current_service.id, upload_id=upload_id, original_file_name=original_file_name)}}" class='page-footer'>
Validate CSVs fully This commit extends the existing function to validate each row’s phone number to also validate that all the required data is present. It does this using the checking that the `Template` class can do when given a template and a `dict` of values.
2016-02-17 15:49:07 +00:00
<input type="hidden" name="csrf_token" value="{{ csrf_token() }}" />
Make a function for parsing `help` query param Our templates are a littered with `request.args.get('help', '0')`. This commit refactors these into a single helper method, which can be used by the view functions, then passed to the template. This makes the templates cleaner, and should make it easier to refactor `help` out of the query parameters entirely in the future.
2016-07-05 11:39:07 +01:00
<input type="hidden" name="help" value="{{ '3' if help else 0 }}" />
Tell the API which contact list a job’s come from So that we can make enhancements to the UI in the future, for example grouping jobs within their associated contact list.
2020-03-16 17:00:34 +00:00
<input type="hidden" name="contact_list_id" value="{{ request.args.get('contact_list_id', '') }}" />
Don’t show scheduler when sending letters
2017-04-26 10:49:51 +01:00
{% if choose_time_form and template.template_type != 'letter' %}
Don’t allow test messages to be scheduled For two reasons: - it’s extra stuff in tour that users dont yet need to know about - test messages are hidden from the dashboard, so you’d have no visibility of when they were sending once you’d scheduled them
2016-08-30 09:27:24 +01:00
{{ radio_select(
choose_time_form.scheduled_for,
wrapping_class='bottom-gutter-2-3'
) }}
{% endif %}
Move letter too long banner message over from utils, also refactor
2019-10-01 17:16:15 +01:00
{% if (template.template_type != 'letter' or not request.args.from_test) and not letter_too_long %}
Replace straightforward buttons and links styled like buttons This replaces the buttons that aren't part of a macro and that we don't need to write additional styles for with their govuk-frontend equivalent. There were some links that were styled to look like buttons, so these have also been replaced with the new govuk-frontend macro. There was one button on the `choose-account.html` template that was in a section of code that was never reached - this has been deleted.
2020-01-30 14:01:13 +00:00
{% set button_text %}
Send {{ count_of_recipients|format_thousands }} {{ message_count_label(count_of_recipients, template.template_type, suffix='') }}
{% endset %}
{{ govukButton({ "text": button_text }) }}
Call ‘send test’ ‘generate preview’ for letters We think that sending a test for letters will mean downloading or being emailed a PDF version of the populated template. While we haven’t changed the app to do this yet, renaming the button is a good way to get feedback about it from research.
2017-03-10 17:57:48 +00:00
{% else %}
Replace straightforward buttons and links styled like buttons This replaces the buttons that aren't part of a macro and that we don't need to write additional styles for with their govuk-frontend equivalent. There were some links that were styled to look like buttons, so these have also been replaced with the new govuk-frontend macro. There was one button on the `choose-account.html` template that was in a section of code that was never reached - this has been deleted.
2020-01-30 14:01:13 +00:00
{{ govukButton({
"element": "a",
"text": "Download as a PDF",
"href": url_for('no_cookie.check_messages_preview', service_id=current_service.id, template_id=template.id, upload_id=upload_id, filetype='pdf'),
}) }}
Call ‘send test’ ‘generate preview’ for letters We think that sending a test for letters will mean downloading or being emailed a PDF version of the populated template. While we haven’t changed the app to do this yet, renaming the button is a good way to get feedback about it from research.
2017-03-10 17:57:48 +00:00
{% endif %}
Validate CSVs fully This commit extends the existing function to validate each row’s phone number to also validate that all the required data is present. It does this using the checking that the `Template` class can do when given a template and a `dict` of values.
2016-02-17 15:49:07 +00:00
</form>
Add a skip link to the preview page The accessibility audit raised the issue that screen reader users could miss the table of data on the preview page, because it’s after the submit/back buttons. > The back button is before the table of error messages - a screen > reader user might read the initial error summary then get to the back > button and not realise the error detail are later in the sequence. > The send and back buttons are before the table of field values - a > screen reader user might read the template details ror summary then > get to the buttons and not realise the field details are later in the > sequence. This commit add a skip link to navigate the users directly to the table, which: - allows them to skip past a lot of content which they might already have read - makes them aware that the table exists It’s added: – as the first thing after the `<h1>` when there are no errors with the file - as the last thing in the error summary when there are errors with the file The link is hidden from those interacting with the site visually.
2017-02-13 15:20:56 +00:00
</div>
Hide the recipient table on send yourself a test Send yourself a test is: - a good way of explaining how placeholders work - a useful tool for checking your work before you send a big batch It’s not a good way of learning about the relationship between columns in a spreadsheet and placeholders. The ‘example spreadsheet’ thing is good at making that connection. The table on this page isn’t, because it doesn’t _feel_ like you’re making a spreadsheet with the send yourself a test feature (even though that’s what you’re doing in the background). This will be even more the case when we stop putting the input boxes horizontally on one page. By removing the table from this page it makes the page simpler, which allows people to focus on the important thing – what’s happening to their message.
2017-05-11 10:55:44 +01:00
{% if not request.args.from_test %}
<h2 class="heading-medium" id="{{ file_contents_header_id }}">{{ original_file_name }}</h2>
Change tables to scroll in-page, not full screen There were three problems with showing tables fullscreen: - it was over-optimised for very big spreadsheets, whereas most users will only have a few columns in their files - it was jarring to go from full screen and back to the normal layout - it was a bit change for existing users, where we prefer incremental changes that make things better without disrupting people’s work (where possible) So this commit changes the big table to scroll horizontally in the page, not take up the full width of the page. From the fullscreen table it keeps: - the shimming method to keep the horizontal scrollbar at the bottom of the screen at all times It introduces some more refinements to make it nicer to use: - fixing the first column, so you always know what row you’re on - adding shadows indicate where there is content that’s scrolled outside the edges of the container
2017-12-14 11:58:40 +00:00
<div class="fullscreen-content" data-module="fullscreen-table">
{% call(item, row_number) list_table(
Bring in refactored CSV processing Shouldn’t be any functional changes here, just things being named more clearly.
2018-03-05 15:57:10 +00:00
recipients.displayed_rows,
Change tables to scroll in-page, not full screen There were three problems with showing tables fullscreen: - it was over-optimised for very big spreadsheets, whereas most users will only have a few columns in their files - it was jarring to go from full screen and back to the normal layout - it was a bit change for existing users, where we prefer incremental changes that make things better without disrupting people’s work (where possible) So this commit changes the big table to scroll horizontally in the page, not take up the full width of the page. From the fullscreen table it keeps: - the shimming method to keep the horizontal scrollbar at the bottom of the screen at all times It introduces some more refinements to make it nicer to use: - fixing the first column, so you always know what row you’re on - adding shadows indicate where there is content that’s scrolled outside the edges of the container
2017-12-14 11:58:40 +00:00
caption=original_file_name,
caption_visible=False,
field_headings=[
Replace all visually-hidden classes These have been replaced: https://design-system.service.gov.uk/get-started/updating-your-code/#helper-class-names
2019-10-21 15:18:25 +01:00
'<span class="govuk-visually-hidden">Row in file</span><span aria-hidden="true">1</span>'|safe
Change tables to scroll in-page, not full screen There were three problems with showing tables fullscreen: - it was over-optimised for very big spreadsheets, whereas most users will only have a few columns in their files - it was jarring to go from full screen and back to the normal layout - it was a bit change for existing users, where we prefer incremental changes that make things better without disrupting people’s work (where possible) So this commit changes the big table to scroll horizontally in the page, not take up the full width of the page. From the fullscreen table it keeps: - the shimming method to keep the horizontal scrollbar at the bottom of the screen at all times It introduces some more refinements to make it nicer to use: - fixing the first column, so you always know what row you’re on - adding shadows indicate where there is content that’s scrolled outside the edges of the container
2017-12-14 11:58:40 +00:00
] + recipients.column_headers
) %}
{% call index_field() %}
Remove error handling code when no errors `ok.html` is only used if the file has no errors. Therefore there will never been any need to highlight which rows in the file have errors.
2018-01-15 11:20:06 +00:00
<span>
Make row in URL match displayed row Spreadsheets start at row 1 (the header row), and the values don’t start until row 2. The row numbers in our URLs start at 0, which is a concept that only makes sense to programmers. It’s more predictable and consistent to make the number in the URL match the row number displayed on the page when previewing the spreadsheet.
2018-01-15 11:35:45 +00:00
{% if (item.index + 2) == preview_row %}
Link each row in the spreadsheet We’ve heard from some users, especially those sending letters, that they’d like to check that a spreadsheet they’ve uploaded has populated the template correctly. My reckon is that seeing just one row of the spreadsheet populate the template isn’t enough to give people confidence that everything’s working properly. This commit adds links to all but the currently-previewed row. Clicking that link will populate the preview with values from that row. These pages already exist; they were created in this PR: https://github.com/alphagov/notifications-admin/pull/1696
2018-01-15 11:25:11 +00:00
{{ item.index + 2 }}
{% else %}
Update all links to use GOVUK Frontend style Includes: - turning off :visited styles to match existing design - swapping heading classes used to make links bold for the GOVUK Frontend bold override class - adding visually hidden text to some links to make them work when isolated from their context We may need to revisit whether some links, such as those for documentation and features, may benefit from having some indication that their target has been visited.
2019-12-06 07:53:46 +00:00
<a class="govuk-link govuk-link--no-visited-state" href="{{ url_for('.check_messages', service_id=current_service.id, template_id=template.id, upload_id=upload_id, row_index=(item.index + 2), original_file_name=original_file_name) }}">{{ item.index + 2 }}</a>
Link each row in the spreadsheet We’ve heard from some users, especially those sending letters, that they’d like to check that a spreadsheet they’ve uploaded has populated the template correctly. My reckon is that seeing just one row of the spreadsheet populate the template isn’t enough to give people confidence that everything’s working properly. This commit adds links to all but the currently-previewed row. Clicking that link will populate the preview with values from that row. These pages already exist; they were created in this PR: https://github.com/alphagov/notifications-admin/pull/1696
2018-01-15 11:25:11 +00:00
{% endif %}
Change tables to scroll in-page, not full screen There were three problems with showing tables fullscreen: - it was over-optimised for very big spreadsheets, whereas most users will only have a few columns in their files - it was jarring to go from full screen and back to the normal layout - it was a bit change for existing users, where we prefer incremental changes that make things better without disrupting people’s work (where possible) So this commit changes the big table to scroll horizontally in the page, not take up the full width of the page. From the fullscreen table it keeps: - the shimming method to keep the horizontal scrollbar at the bottom of the screen at all times It introduces some more refinements to make it nicer to use: - fixing the first column, so you always know what row you’re on - adding shadows indicate where there is content that’s scrolled outside the edges of the container
2017-12-14 11:58:40 +00:00
</span>
{% endcall %}
{% for column in recipients.column_headers %}
Bring in refactored CSV processing Shouldn’t be any functional changes here, just things being named more clearly.
2018-03-05 15:57:10 +00:00
{% if item[column].ignore %}
{{ text_field(item[column].data or '', status='default') }}
Change tables to scroll in-page, not full screen There were three problems with showing tables fullscreen: - it was over-optimised for very big spreadsheets, whereas most users will only have a few columns in their files - it was jarring to go from full screen and back to the normal layout - it was a bit change for existing users, where we prefer incremental changes that make things better without disrupting people’s work (where possible) So this commit changes the big table to scroll horizontally in the page, not take up the full width of the page. From the fullscreen table it keeps: - the shimming method to keep the horizontal scrollbar at the bottom of the screen at all times It introduces some more refinements to make it nicer to use: - fixing the first column, so you always know what row you’re on - adding shadows indicate where there is content that’s scrolled outside the edges of the container
2017-12-14 11:58:40 +00:00
{% else %}
Bring in refactored CSV processing Shouldn’t be any functional changes here, just things being named more clearly.
2018-03-05 15:57:10 +00:00
{{ text_field(item[column].data or '') }}
Change tables to scroll in-page, not full screen There were three problems with showing tables fullscreen: - it was over-optimised for very big spreadsheets, whereas most users will only have a few columns in their files - it was jarring to go from full screen and back to the normal layout - it was a bit change for existing users, where we prefer incremental changes that make things better without disrupting people’s work (where possible) So this commit changes the big table to scroll horizontally in the page, not take up the full width of the page. From the fullscreen table it keeps: - the shimming method to keep the horizontal scrollbar at the bottom of the screen at all times It introduces some more refinements to make it nicer to use: - fixing the first column, so you always know what row you’re on - adding shadows indicate where there is content that’s scrolled outside the edges of the container
2017-12-14 11:58:40 +00:00
{% endif %}
Hide the recipient table on send yourself a test Send yourself a test is: - a good way of explaining how placeholders work - a useful tool for checking your work before you send a big batch It’s not a good way of learning about the relationship between columns in a spreadsheet and placeholders. The ‘example spreadsheet’ thing is good at making that connection. The table on this page isn’t, because it doesn’t _feel_ like you’re making a spreadsheet with the send yourself a test feature (even though that’s what you’re doing in the background). This will be even more the case when we stop putting the input boxes horizontally on one page. By removing the table from this page it makes the page simpler, which allows people to focus on the important thing – what’s happening to their message.
2017-05-11 10:55:44 +01:00
{% endfor %}
Bring in refactored CSV processing Shouldn’t be any functional changes here, just things being named more clearly.
2018-03-05 15:57:10 +00:00
{% if item[None].data %}
{% for column in item[None].data %}
Change tables to scroll in-page, not full screen There were three problems with showing tables fullscreen: - it was over-optimised for very big spreadsheets, whereas most users will only have a few columns in their files - it was jarring to go from full screen and back to the normal layout - it was a bit change for existing users, where we prefer incremental changes that make things better without disrupting people’s work (where possible) So this commit changes the big table to scroll horizontally in the page, not take up the full width of the page. From the fullscreen table it keeps: - the shimming method to keep the horizontal scrollbar at the bottom of the screen at all times It introduces some more refinements to make it nicer to use: - fixing the first column, so you always know what row you’re on - adding shadows indicate where there is content that’s scrolled outside the edges of the container
2017-12-14 11:58:40 +00:00
{{ text_field(column, status='default') }}
{% endfor %}
{% endif %}
{% endcall %}
</div>
Hide the recipient table on send yourself a test Send yourself a test is: - a good way of explaining how placeholders work - a useful tool for checking your work before you send a big batch It’s not a good way of learning about the relationship between columns in a spreadsheet and placeholders. The ‘example spreadsheet’ thing is good at making that connection. The table on this page isn’t, because it doesn’t _feel_ like you’re making a spreadsheet with the send yourself a test feature (even though that’s what you’re doing in the background). This will be even more the case when we stop putting the input boxes horizontally on one page. By removing the table from this page it makes the page simpler, which allows people to focus on the important thing – what’s happening to their message.
2017-05-11 10:55:44 +01:00
{% endif %}
Simplify check and send SMS page This commit: - removes the row numbering so it’s easier to scan the list of phone numbers - adds subheadings for 'first three' and 'last three' - puts the 'see all' link at the end
2015-12-11 17:25:04 +00:00
Remove anything error-related from the OK view If you’ve uploaded a file and everything is OK, the page that you see doesn’t need to look at any errors (because there won’t be any).
2017-07-20 09:02:08 +01:00
{% if count_of_displayed_recipients < count_of_recipients %}
Give the user better error messages for CSV files Makes uses of the additions to utils in https://github.com/alphagov/notifications-utils/pull/9 This commit strips out a lot of the complex stuff that the views and templates in this app were doing. There is now a cleaner separation of concerns: - utils returns the number and type of errors in the csv - `get_errors_for_csv` helper in this app maps the number and type of errors onto human-friendly error messages - the view and template just doing the glueing-together of all the pieces This is (hopefully) easier to understand, definitely makes the component parts easier to test in isolation, and makes it easier to give more specific error messages.
2016-03-07 18:47:05 +00:00
<p class="table-show-more-link">
Remove error-handling code from OK page `ok.html` is only used when there’s a spreadsheet which doesn’t have any errors in it.
2017-12-14 17:55:47 +00:00
Only showing the first {{ count_of_displayed_recipients }} rows
Change wording when there are hidden rows This caused some anxiety about why the rows were being hidden. Were there problems with them? This commit reframes the wording to talk about the rows that are shown instead.
2016-04-07 14:30:28 +01:00
</p>
Show spreadsheet before template if there’s errors It’s easier to work out what the errors are in your file if you can see the big red error message right next to the contents of your file. When users get errors they tend to go back and forth between the error message and the view of the file, not the message and the template preview.
2017-05-19 08:16:41 +01:00
{% endif %}
Create shell page for checking text messages before sending
2015-11-30 14:20:17 +00:00
{% endblock %}
Reference in New Issue Copy Permalink