requirements_for_test.txt

-r requirements.txt
isort==5.7.0
pytest==6.2.2
pytest-env==0.6.2
pytest-mock==3.5.1
pytest-xdist==2.2.1
beautifulsoup4==4.9.3
freezegun==1.1.0
flake8==3.7.9
flake8-bugbear==19.8.0
flake8-print==3.1.4
requests-mock==1.7.0
# used for creating manifest file locally
jinja2-cli[yaml]==0.7.0
Stop locking non-test dependencies twice Currently we have a situation where we're not running tests against new versions of dependencies, as requirements_for_test.txt is not being kept in-sync with requirements.txt by pyup. Deploys are only working because Concourse silently ignores version issues. From a deployment log: awscli 1.18.211 has requirement PyYAML<5.4,>=3.10; python_version != "3.4", but you'll have pyyaml 5.4 which is incompatible. This switches to a single requirements file for test dependencies, in order to keep it in-sync with requirements.txt i.e. we run our tests against the same versions of dependencies that we deploy with, and the build fails if we try to use package versions that are not mutually compatible, as this example PR shows [1]. ERROR: Cannot install -r requirements_for_test.txt (line 17), -r requirements_for_test.txt (line 198) and pyyaml==5.4.1 because these package versions have conflicting dependencies. We shouldn't need to have fine-grained locking on test dependencies, beyond those we want to list manually in the file. [1]: https://github.com/alphagov/notifications-admin/pull/3804 2021-02-16 17:08:03 +00:00			`-r requirements.txt`
Update isort from 4.3.21 to 5.7.0 2021-03-08 13:55:04 +00:00			`isort==5.7.0`
Update pytest from 5.3.2 to 6.2.2 2021-03-08 13:55:05 +00:00			`pytest==6.2.2`
Update requirements - install patch for jinja2 vulnerability 2021-02-02 17:13:18 +00:00			`pytest-env==0.6.2`
Update pytest-mock from 1.11.2 to 3.5.1 2021-03-08 13:55:05 +00:00			`pytest-mock==3.5.1`
Update pytest-xdist from 1.31.0 to 2.2.1 2021-03-08 13:55:06 +00:00			`pytest-xdist==2.2.1`
Update beautifulsoup4 from 4.8.1 to 4.9.3 2021-03-08 13:55:06 +00:00			`beautifulsoup4==4.9.3`
Update freezegun from 0.3.12 to 1.1.0 2021-03-08 13:55:06 +00:00			`freezegun==1.1.0`
Keep test dependencies as-is for now These are leading to multiple failures: - flake8 fails with various issues - isort fails with various issues - pytest fails on a couple of 2FA tests While we can and should upgrade these dependencies, the priority is fixing the build so that we can do this reliably. 2021-02-16 17:33:05 +00:00			`flake8==3.7.9`
			`flake8-bugbear==19.8.0`
			`flake8-print==3.1.4`
			`requests-mock==1.7.0`
Stop locking non-test dependencies twice Currently we have a situation where we're not running tests against new versions of dependencies, as requirements_for_test.txt is not being kept in-sync with requirements.txt by pyup. Deploys are only working because Concourse silently ignores version issues. From a deployment log: awscli 1.18.211 has requirement PyYAML<5.4,>=3.10; python_version != "3.4", but you'll have pyyaml 5.4 which is incompatible. This switches to a single requirements file for test dependencies, in order to keep it in-sync with requirements.txt i.e. we run our tests against the same versions of dependencies that we deploy with, and the build fails if we try to use package versions that are not mutually compatible, as this example PR shows [1]. ERROR: Cannot install -r requirements_for_test.txt (line 17), -r requirements_for_test.txt (line 198) and pyyaml==5.4.1 because these package versions have conflicting dependencies. We shouldn't need to have fine-grained locking on test dependencies, beyond those we want to list manually in the file. [1]: https://github.com/alphagov/notifications-admin/pull/3804 2021-02-16 17:08:03 +00:00			`# used for creating manifest file locally`
			`jinja2-cli[yaml]==0.7.0`