tests/app/test_assets.py

def test_crown_logo(client_request):
    #  This image is used by the email templates, so we should be really careful to make
    #  sure that its always there.
    client_request.logout()
    client_request.get_response_from_url(
        '/static/images/email-template/crown-32px.gif',
        _expected_status=200,
    )


def test_static_404s_return(client_request):
    client_request.get_response_from_url(
        '/static/images/some-image-that-doesnt-exist.png',
        _expected_status=404,
    )
Replace uses of `client.get` and `client.post` We have a `client_request` fixture which does a bunch of useful stuff like: - checking the status code of the response - returning a `BeautifulSoup` object Lots of our tests still use an older fixture called `client`. This is not as good because it: - returns a raw `Response` object - doesn’t do the additional checks - means our tests contain a lot of repetetive boilerplate like `page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')` This commit converts all the tests which had a `client.get(…)` or `client.post(…)` statement to use their equivalents on `client_request` instead. Subsequent commits will remove uses of `client` in other tests, but doing it this way means the work can be broken up into more manageable chunks. 2022-01-04 15:40:42 +00:00			`def test_crown_logo(client_request):`
make sure static subdir 404s correctly before each request, we put the current service on the flask session, except for with the static folder, cos it's not needed.... except, if we 404, then we return the 404 template, which checks if you're logged in or not to display different nav bar items. This was crashing when current_service wasn't set, so we now set it. also cleaned up some imports and stuff in test files 2017-05-04 11:28:45 +01:00			`# This image is used by the email templates, so we should be really careful to make`
			`# sure that its always there.`
Replace uses of `client.get` and `client.post` We have a `client_request` fixture which does a bunch of useful stuff like: - checking the status code of the response - returning a `BeautifulSoup` object Lots of our tests still use an older fixture called `client`. This is not as good because it: - returns a raw `Response` object - doesn’t do the additional checks - means our tests contain a lot of repetetive boilerplate like `page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')` This commit converts all the tests which had a `client.get(…)` or `client.post(…)` statement to use their equivalents on `client_request` instead. Subsequent commits will remove uses of `client` in other tests, but doing it this way means the work can be broken up into more manageable chunks. 2022-01-04 15:40:42 +00:00			`client_request.logout()`
			`client_request.get_response_from_url(`
			`'/static/images/email-template/crown-32px.gif',`
			`_expected_status=200,`
			`)`
Host image used in email template in app Right now the crown logo in email templates is hosted on Github. Github is not a CDN. For now, hosting it in the app is a better solution. At some point we should have a CDN for all assets on the app, which would be even better. https://www.pivotaltracker.com/story/show/116952911 2016-04-07 09:15:18 +01:00

Replace uses of `client.get` and `client.post` We have a `client_request` fixture which does a bunch of useful stuff like: - checking the status code of the response - returning a `BeautifulSoup` object Lots of our tests still use an older fixture called `client`. This is not as good because it: - returns a raw `Response` object - doesn’t do the additional checks - means our tests contain a lot of repetetive boilerplate like `page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')` This commit converts all the tests which had a `client.get(…)` or `client.post(…)` statement to use their equivalents on `client_request` instead. Subsequent commits will remove uses of `client` in other tests, but doing it this way means the work can be broken up into more manageable chunks. 2022-01-04 15:40:42 +00:00			`def test_static_404s_return(client_request):`
			`client_request.get_response_from_url(`
			`'/static/images/some-image-that-doesnt-exist.png',`
			`_expected_status=404,`
			`)`