tests/app/main/test_errorhandlers.py

from flask import Response
from bs4 import BeautifulSoup
from notifications_python_client.errors import HTTPError


def test_bad_url_returns_page_not_found(client):
    response = client.get('/bad_url')
    assert response.status_code == 404
    page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')
    assert page.h1.string.strip() == 'Page could not be found'


def test_load_service_before_request_handles_404(client_request, mocker):
    exc = HTTPError(Response(status=404), 'Not found')
    get_service = mocker.patch('app.service_api_client.get_service', side_effect=exc)

    client_request.get(
        'main.service_dashboard',
        service_id='00000000-0000-0000-0000-000000000000',
        _expected_status=404
    )

    get_service.assert_called_once_with('00000000-0000-0000-0000-000000000000')
make sure load_service_before_request handles 404s if it 404s, because the service id doesn't exist, then it should die gracefully (showing a 404 error page), rather than what it currently does, which is die kicking and screaming with a 500 2017-10-30 16:59:24 +00:00			`from flask import Response`
Fix bug in error handlers. Correct spelling error 2016-03-11 10:16:06 +00:00			`from bs4 import BeautifulSoup`
make sure load_service_before_request handles 404s if it 404s, because the service id doesn't exist, then it should die gracefully (showing a 404 error page), rather than what it currently does, which is die kicking and screaming with a 500 2017-10-30 16:59:24 +00:00			`from notifications_python_client.errors import HTTPError`
Fix bug in error handlers. Correct spelling error 2016-03-11 10:16:06 +00:00

Use `client` and `logged_in_client` fixtures Wherever possible, because Don’t Repeat Yourself. 2017-02-03 12:07:21 +00:00			`def test_bad_url_returns_page_not_found(client):`
			`response = client.get('/bad_url')`
			`assert response.status_code == 404`
			`page = BeautifulSoup(response.data.decode('utf-8'), 'html.parser')`
			`assert page.h1.string.strip() == 'Page could not be found'`
make sure load_service_before_request handles 404s if it 404s, because the service id doesn't exist, then it should die gracefully (showing a 404 error page), rather than what it currently does, which is die kicking and screaming with a 500 2017-10-30 16:59:24 +00:00

			`def test_load_service_before_request_handles_404(client_request, mocker):`
			`exc = HTTPError(Response(status=404), 'Not found')`
			`get_service = mocker.patch('app.service_api_client.get_service', side_effect=exc)`

			`client_request.get(`
			`'main.service_dashboard',`
			`service_id='00000000-0000-0000-0000-000000000000',`
			`_expected_status=404`
			`)`

			`get_service.assert_called_once_with('00000000-0000-0000-0000-000000000000')`