tests/app/notify_client/test_template_statistics_client.py

import uuid

from app.notify_client.template_statistics_api_client import (
    TemplateStatisticsApiClient,
)


def test_template_statistics_client_calls_correct_api_endpoint_for_service(mocker, api_user_active):

    some_service_id = uuid.uuid4()
    expected_url = '/service/{}/template-statistics'.format(some_service_id)

    client = TemplateStatisticsApiClient()

    mock_get = mocker.patch('app.notify_client.template_statistics_api_client.TemplateStatisticsApiClient.get')

    client.get_template_statistics_for_service(some_service_id)

    mock_get.assert_called_once_with(url=expected_url, params={})


def test_template_statistics_client_calls_correct_api_endpoint_for_template(mocker, api_user_active):
    some_service_id = uuid.uuid4()
    some_template_id = uuid.uuid4()
    expected_url = '/service/{}/template-statistics/{}'.format(some_service_id, some_template_id)

    client = TemplateStatisticsApiClient()
    mock_get = mocker.patch('app.notify_client.template_statistics_api_client.TemplateStatisticsApiClient.get')

    client.get_template_statistics_for_template(some_service_id, some_template_id)

    mock_get.assert_called_once_with(url=expected_url)
Added test for template stats client. Removed date column from recently used templates table. 2016-04-05 13:49:22 +01:00			`import uuid`

Enforce order and style of imports Done using isort[1], with the following command: ``` isort -rc ./app ./tests ``` Adds linting to the `run_tests.sh` script to stop badly-sorted imports getting re-introduced. Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because I think it gives the cleanest diffs, eg: ``` from third_party import ( lib1, lib2, lib3, lib4, ) ``` 1. https://pypi.python.org/pypi/isort 2018-02-20 11:22:17 +00:00			`from app.notify_client.template_statistics_api_client import (`
			`TemplateStatisticsApiClient,`
			`)`
Added test for template stats client. Removed date column from recently used templates table. 2016-04-05 13:49:22 +01:00

only get template statistics for specific template 2016-06-07 14:28:02 +01:00			`def test_template_statistics_client_calls_correct_api_endpoint_for_service(mocker, api_user_active):`
Added test for template stats client. Removed date column from recently used templates table. 2016-04-05 13:49:22 +01:00
			`some_service_id = uuid.uuid4()`
			`expected_url = '/service/{}/template-statistics'.format(some_service_id)`

			`client = TemplateStatisticsApiClient()`

			`mock_get = mocker.patch('app.notify_client.template_statistics_api_client.TemplateStatisticsApiClient.get')`

			`client.get_template_statistics_for_service(some_service_id)`

Limit templates usage on dashboard to last 7 days Previous the table of templates on the dashboard was for all time. This commit uses the `limit_days` parameter of the API endpoint to only show template usage from the last 7 days, aligning with the big numbers shown above. 2016-04-20 13:59:24 +01:00			`mock_get.assert_called_once_with(url=expected_url, params={})`
only get template statistics for specific template 2016-06-07 14:28:02 +01:00

			`def test_template_statistics_client_calls_correct_api_endpoint_for_template(mocker, api_user_active):`
			`some_service_id = uuid.uuid4()`
			`some_template_id = uuid.uuid4()`
			`expected_url = '/service/{}/template-statistics/{}'.format(some_service_id, some_template_id)`

			`client = TemplateStatisticsApiClient()`
			`mock_get = mocker.patch('app.notify_client.template_statistics_api_client.TemplateStatisticsApiClient.get')`

			`client.get_template_statistics_for_template(some_service_id, some_template_id)`

			`mock_get.assert_called_once_with(url=expected_url)`