darkhelm/notifications-admin
1
0
Fork 0
mirror of https://github.com/GSA/notifications-admin.git synced 2026-07-08 10:28:57 -04:00
Code Issues Packages Projects Releases Wiki Activity
Files
203393de235631db0ce3c38dec85da170a634fba
notifications-admin/tests/app/main/views/test_template_history.py

71 lines
1.8 KiB
Python
Raw Normal View History

Update all dates to use utc, only in the template is it converted to british time. Template versions and template version pages added. Fix merge changes.
2016-05-11 11:20:45 +01:00
from flask import url_for
Normalize whitespace in test arguments We have a bunch of different styles of handling when function definitions span multiple lines, which they almost always do with tests. Here’s why an argument per line, single indent is best: - cleaner diffs when you change the name of a method (one line change instead of multiple lines) - works better on narrow screens, eg Github’s diff view, or with two terminals side by side on a laptop screen - works with any editor’s indenting shortcuts, no need for an IDE Also, trailing comma in the list of arguments is good because adding a new argument to a method becomes a one line, not two line diff.
2017-02-03 10:42:01 +00:00
def test_view_template_version(
Use `client` and `logged_in_client` fixtures Wherever possible, because Don’t Repeat Yourself.
2017-02-03 12:07:21 +00:00
logged_in_client,
Normalize whitespace in test arguments We have a bunch of different styles of handling when function definitions span multiple lines, which they almost always do with tests. Here’s why an argument per line, single indent is best: - cleaner diffs when you change the name of a method (one line change instead of multiple lines) - works better on narrow screens, eg Github’s diff view, or with two terminals side by side on a laptop screen - works with any editor’s indenting shortcuts, no need for an IDE Also, trailing comma in the list of arguments is good because adding a new argument to a method becomes a one line, not two line diff.
2017-02-03 10:42:01 +00:00
api_user_active,
mock_login,
mock_get_service,
mock_get_template_version,
mock_get_user,
mock_get_user_by_email,
mock_has_permissions,
fake_uuid,
):
Use `client` and `logged_in_client` fixtures Wherever possible, because Don’t Repeat Yourself.
2017-02-03 12:07:21 +00:00
service_id = fake_uuid
template_id = fake_uuid
version = 1
all_versions_link = url_for(
'main.view_template_versions',
service_id=service_id,
template_id=template_id
)
resp = logged_in_client.get(url_for(
'.view_template_version',
service_id=service_id,
template_id=template_id,
version=version))
Update all dates to use utc, only in the template is it converted to british time. Template versions and template version pages added. Fix merge changes.
2016-05-11 11:20:45 +01:00
assert resp.status_code == 200
resp_data = resp.get_data(as_text=True)
template = mock_get_template_version(service_id, template_id, version)
assert api_user_active.name in resp_data
assert template['data']['content'] in resp_data
Link back to all template versions from 1 version If you get linked to a single version of a template, you’re at a dead end. Let’s add a link to go back up a level to where you can understand the current version in context.
2016-06-12 14:35:58 +01:00
assert all_versions_link in resp_data
Update all dates to use utc, only in the template is it converted to british time. Template versions and template version pages added. Fix merge changes.
2016-05-11 11:20:45 +01:00
mock_get_template_version.assert_called_with(
service_id,
template_id,
version
)
Normalize whitespace in test arguments We have a bunch of different styles of handling when function definitions span multiple lines, which they almost always do with tests. Here’s why an argument per line, single indent is best: - cleaner diffs when you change the name of a method (one line change instead of multiple lines) - works better on narrow screens, eg Github’s diff view, or with two terminals side by side on a laptop screen - works with any editor’s indenting shortcuts, no need for an IDE Also, trailing comma in the list of arguments is good because adding a new argument to a method becomes a one line, not two line diff.
2017-02-03 10:42:01 +00:00
def test_view_template_versions(
Use `client` and `logged_in_client` fixtures Wherever possible, because Don’t Repeat Yourself.
2017-02-03 12:07:21 +00:00
logged_in_client,
Normalize whitespace in test arguments We have a bunch of different styles of handling when function definitions span multiple lines, which they almost always do with tests. Here’s why an argument per line, single indent is best: - cleaner diffs when you change the name of a method (one line change instead of multiple lines) - works better on narrow screens, eg Github’s diff view, or with two terminals side by side on a laptop screen - works with any editor’s indenting shortcuts, no need for an IDE Also, trailing comma in the list of arguments is good because adding a new argument to a method becomes a one line, not two line diff.
2017-02-03 10:42:01 +00:00
api_user_active,
mock_login,
mock_get_service,
mock_get_template_versions,
mock_get_service_template,
mock_get_user,
mock_get_user_by_email,
mock_has_permissions,
fake_uuid,
):
Use `client` and `logged_in_client` fixtures Wherever possible, because Don’t Repeat Yourself.
2017-02-03 12:07:21 +00:00
service_id = fake_uuid
template_id = fake_uuid
resp = logged_in_client.get(url_for(
'.view_template_versions',
service_id=service_id,
template_id=template_id
))
Update all dates to use utc, only in the template is it converted to british time. Template versions and template version pages added. Fix merge changes.
2016-05-11 11:20:45 +01:00
assert resp.status_code == 200
resp_data = resp.get_data(as_text=True)
versions = mock_get_template_versions(service_id, template_id)
assert api_user_active.name in resp_data
assert versions['data'][0]['content'] in resp_data
mock_get_template_versions.assert_called_with(
service_id,
template_id
)
Reference in New Issue Copy Permalink