app/status/views/healthcheck.py

from flask import current_app, jsonify, request
from notifications_python_client.errors import HTTPError

from app import status_api_client, version
from app.status import status


@status.route('/_status', methods=['GET'])
def show_status():
    if request.args.get('elb', None):
        return jsonify(status="ok"), 200
    else:
        try:
            api_status = status_api_client.get_status()
        except HTTPError as e:
            current_app.logger.exception("API failed to respond")
            return jsonify(status="error", message=str(e.message)), 500
        return jsonify(
            status="ok",
            api=api_status,
            travis_commit=version.__travis_commit__,
            travis_build_number=version.__travis_job_number__,
            build_time=version.__time__), 200
Enforce order and style of imports Done using isort[1], with the following command: ``` isort -rc ./app ./tests ``` Adds linting to the `run_tests.sh` script to stop badly-sorted imports getting re-introduced. Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because I think it gives the cleanest diffs, eg: ``` from third_party import ( lib1, lib2, lib3, lib4, ) ``` 1. https://pypi.python.org/pypi/isort 2018-02-20 11:22:17 +00:00			`from flask import current_app, jsonify, request`
This pull request removes the need for the req and pay in the claims JWT. Use the new version of the notifications-python-client. This version no longer adds the req and pay to the claims of the jwt. The change is backward compatible so an older client that sends a JWT with the extra claims will pass authentication. Once all the clients have been updated to not include the extra claims some updates to exclude them from the method signatures will happen as well. The documentation has been updated to reflect this change. https://www.pivotaltracker.com/story/show/116971293 2016-04-15 11:04:35 +01:00			`from notifications_python_client.errors import HTTPError`
Added status page - returns "OK" as JSON with a 200 - used in healthchecks 2016-01-11 14:54:23 +00:00
Enforce order and style of imports Done using isort[1], with the following command: ``` isort -rc ./app ./tests ``` Adds linting to the `run_tests.sh` script to stop badly-sorted imports getting re-introduced. Chosen style is ‘Vertical Hanging Indent’ with trailing commas, because I think it gives the cleanest diffs, eg: ``` from third_party import ( lib1, lib2, lib3, lib4, ) ``` 1. https://pypi.python.org/pypi/isort 2018-02-20 11:22:17 +00:00			`from app import status_api_client, version`
			`from app.status import status`

Fixed pep8 2016-03-03 16:50:06 +00:00
Fixed up the health check page 2016-03-03 16:41:21 +00:00			`@status.route('/_status', methods=['GET'])`
			`def show_status():`
			`if request.args.get('elb', None):`
			`return jsonify(status="ok"), 200`
			`else:`
Status page now relies on the api passing else a 500 will be returned. 2016-04-06 16:36:03 +01:00			`try:`
			`api_status = status_api_client.get_status()`
			`except HTTPError as e:`
Log failed api healthchecks 2017-11-16 16:35:24 +00:00			`current_app.logger.exception("API failed to respond")`
Status page now relies on the api passing else a 500 will be returned. 2016-04-06 16:36:03 +01:00			`return jsonify(status="error", message=str(e.message)), 500`
Fixed up the health check page 2016-03-03 16:41:21 +00:00			`return jsonify(`
			`status="ok",`
Status page now relies on the api passing else a 500 will be returned. 2016-04-06 16:36:03 +01:00			`api=api_status,`
Fixed up the health check page 2016-03-03 16:41:21 +00:00			`travis_commit=version.__travis_commit__,`
			`travis_build_number=version.__travis_job_number__,`
			`build_time=version.__time__), 200`